@@ -90,11 +90,16 @@ private return nil unless xml property = self.class.properties[name] - node = xml.at("/#{property[:path]}") - - if node + values = xml.search("/#{property[:path]}").map do |node| result = extract_result(node, property[:from]) - result = cast_result(result, property[:as]) + cast_result(result, property[:as]) + end + + case property[:cardinality] + when :many + return values + else + return values.first end end lib/feed_me/abstract_parser.rb @@ -18,6 +18,7 @@ module FeedMe property :item_id, :path => :guid property :url, :path => :link property :content, :path => :description + property :categories, :path => :category, :cardinality => :many has_one :author, :use => :Rss2PersonParser end lib/feed_me/item_parser.rb @@ -1,52 +1,52 @@ <?xml version="1.0"?> <rss version="2.0"> - <channel> - <title>Lift Off News</title> - <link>http://liftoff.msfc.nasa.gov/</link> - <description>Liftoff to Space Exploration.</description> - <language>en-us</language> - <pubDate>Tue, 10 Jun 2003 04:00:00 GMT</pubDate> - <lastBuildDate>Tue, 10 Jun 2003 09:41:01 GMT</lastBuildDate> - <docs>http://blogs.law.harvard.edu/tech/rss</docs> - <generator>Weblog Editor 2.0</generator> - <managingEditor>editor@example.com (Mary Jo)</managingEditor> - <webMaster>webmaster@example.com (John Doe)</webMaster> - <ttl>5</ttl> - <item> - <title>Star City</title> - <link>http://liftoff.msfc.nasa.gov/news/2003/news-starcity.asp</link> - <author>da_man@example.com (Chuck Norris)</author> - <description>This is content</description> - <pubDate>Tue, 03 Jun 2003 09:39:21 GMT</pubDate> - <guid>http://liftoff.msfc.nasa.gov/2003/06/03.html#item573</guid> - <category>news</category> - <category>chuck</category> - </item> - <item> - <title>Space Exploration</title> - <link>http://liftoff.msfc.nasa.gov/</link> - <description>Sky watchers in Europe, Asia, and parts of Alaska and Canada - will experience a partial eclipse of the Sun on Saturday, May 31st.</description> - <pubDate>Fri, 30 May 2003 11:06:42 GMT</pubDate> - <guid>http://liftoff.msfc.nasa.gov/2003/05/30.html#item572</guid> - </item> - <item> - <title>The Engine That Does More</title> - <link>http://liftoff.msfc.nasa.gov/news/2003/news-VASIMR.asp</link> - <description>Before man travels to Mars, NASA hopes to design new engines - that will let us fly through the Solar System more quickly. The proposed - VASIMR engine would do that.</description> - <pubDate>Tue, 27 May 2003 08:37:32 GMT</pubDate> - <guid>http://liftoff.msfc.nasa.gov/2003/05/27.html#item571</guid> - </item> - <item> - <title>Astronauts' Dirty Laundry</title> - <link>http://liftoff.msfc.nasa.gov/news/2003/news-laundry.asp</link> - <description>Compared to earlier spacecraft, the International Space - Station has many luxuries, but laundry facilities are not one of them. - Instead, astronauts have other options.</description> - <pubDate>Tue, 20 May 2003 08:56:02 GMT</pubDate> - <guid>http://liftoff.msfc.nasa.gov/2003/05/20.html#item570</guid> - </item> - </channel> + <channel> + <title>Lift Off News</title> + <link>http://liftoff.msfc.nasa.gov/</link> + <description>Liftoff to Space Exploration.</description> + <language>en-us</language> + <pubDate>Tue, 10 Jun 2003 04:00:00 GMT</pubDate> + <lastBuildDate>Tue, 10 Jun 2003 09:41:01 GMT</lastBuildDate> + <docs>http://blogs.law.harvard.edu/tech/rss</docs> + <generator>Weblog Editor 2.0</generator> + <managingEditor>editor@example.com (Mary Jo)</managingEditor> + <webMaster>webmaster@example.com (John Doe)</webMaster> + <ttl>5</ttl> + <item> + <title>Star City</title> + <link>http://liftoff.msfc.nasa.gov/news/2003/news-starcity.asp</link> + <author>da_man@example.com (Chuck Norris)</author> + <description>This is content</description> + <pubDate>Tue, 03 Jun 2003 09:39:21 GMT</pubDate> + <guid>http://liftoff.msfc.nasa.gov/2003/06/03.html#item573</guid> + <category>news</category> + <category>chuck</category> + </item> + <item> + <title>Space Exploration</title> + <link>http://liftoff.msfc.nasa.gov/</link> + <description>Sky watchers in Europe, Asia, and parts of Alaska and Canada + will experience a partial eclipse of the Sun on Saturday, May 31st.</description> + <pubDate>Fri, 30 May 2003 11:06:42 GMT</pubDate> + <guid>http://liftoff.msfc.nasa.gov/2003/05/30.html#item572</guid> + </item> + <item> + <title>The Engine That Does More</title> + <link>http://liftoff.msfc.nasa.gov/news/2003/news-VASIMR.asp</link> + <description>Before man travels to Mars, NASA hopes to design new engines + that will let us fly through the Solar System more quickly. The proposed + VASIMR engine would do that.</description> + <pubDate>Tue, 27 May 2003 08:37:32 GMT</pubDate> + <guid>http://liftoff.msfc.nasa.gov/2003/05/27.html#item571</guid> + </item> + <item> + <title>Astronauts' Dirty Laundry</title> + <link>http://liftoff.msfc.nasa.gov/news/2003/news-laundry.asp</link> + <description>Compared to earlier spacecraft, the International Space + Station has many luxuries, but laundry facilities are not one of them. + Instead, astronauts have other options.</description> + <pubDate>Tue, 20 May 2003 08:56:02 GMT</pubDate> + <guid>http://liftoff.msfc.nasa.gov/2003/05/20.html#item570</guid> + </item> + </channel> </rss> spec/fixtures/welformed.rss2 @@ -67,6 +67,12 @@ describe FeedMe::ItemParser do end end + describe '#categories' do + it "should be correct for an rss2 feed" do + @rss2.categories.should == ['news', 'chuck'] + end + end + describe '#author.name' do it "should be valid for an atom feed" do @atom.author.name.should == "Jonas Nicklas" spec/item_parser_spec.rb 3e4073fa5a6e8ae9ebbd13288f174ae9439425de Jonas Nicklas jonas.nicklas@gmail.com http://github.com/jnicklas/feed_me/commit/6e59ff90280ef5c53290f7aef03532bb21d4e41a 6e59ff90280ef5c53290f7aef03532bb21d4e41a 2009-05-10T13:05:31-07:00 2009-05-10T13:05:31-07:00 Re-add categories for RSS2 feeds Lost in rebase Thanks namelessjon bf1472c50bcf15147568a054fab58eaa4673525a Jonas Nicklas jonas.nicklas@gmail.com