@@ -106,7 +106,7 @@ module HTTParty # Uses the HTTP Content-Type header to determine the format of the response # It compares the MIME type returned to the types stored in the AllowedFormats hash def format_from_mimetype(mimetype) #:nodoc: - return nil unless mimetype + return nil if mimetype.nil? AllowedFormats.each { |k, v| return k if mimetype.include?(v) } end lib/httparty/request.rb @@ -48,6 +48,20 @@ describe HTTParty::Request do response.stub!(:body).and_return("") @request.perform.should be_nil end + + it "should not fail for missing mime type" do + http = Net::HTTP.new('localhost', 80) + @request.stub!(:http).and_return(http) + + response = Net::HTTPOK.new("1.1", 200, "Content for you") + response.stub!(:[]).with('content-type').and_return(nil) + response.stub!(:body).and_return('Content for you') + + http.stub!(:request).and_return(response) + + @request.options[:format] = :html + @request.perform.should == 'Content for you' + end describe "that respond with redirects" do def setup_redirect spec/httparty/request_spec.rb 80bfce407caba62051bc798d7d1d5d66aa531407 John Nunemaker nunemaker@gmail.com http://github.com/jnunemaker/httparty/commit/282ae78648bbe3673eef4345ebb36e26d39de495 282ae78648bbe3673eef4345ebb36e26d39de495 2008-12-23T10:09:45-08:00 2008-12-23T10:09:45-08:00 Added a spec for the missing mimetype. Honestly don't think it is properly testing it. Someone is free to show me the way. 459613b331d4ab58d78af1e6d3d41bf56e8ed2d9 John Nunemaker nunemaker@gmail.com