@@ -139,6 +139,7 @@ module HTTParty end def parse_response(body) #:nodoc: + return nil if body.nil? or body.empty? case @format when :xml Hash.from_xml(body) lib/httparty.rb @@ -141,5 +141,20 @@ describe HTTParty do Foo.send(:send_request, 'get', '/foo', :basic_auth => 'string') end.should raise_error(ArgumentError) end + + it "should not attempt to parse empty responses" do + http = Net::HTTP.new('localhost', 80) + Foo.stub!(:http).and_return(http) + response = Net::HTTPNoContent.new("1.1", 204, "No content for you") + response.stub!(:body).and_return(nil) + http.stub!(:request).and_return(response) + + Foo.headers.clear # clear out bogus settings from other specs + Foo.format :xml + Foo.send(:send_request, 'get', '/bar').should be_nil + + response.stub!(:body).and_return("") + Foo.send(:send_request, 'get', 'bar').should be_nil + end end end \ No newline at end of file spec/httparty_spec.rb df9957cfa569c4a15230f5b2cda0a5d8f1b3e727 Alex Vollmer alex@evri.com http://github.com/jnunemaker/httparty/commit/31ad4f91c8c234b15b0d415eb2c088f6838846dc 31ad4f91c8c234b15b0d415eb2c088f6838846dc 2008-10-24T21:32:31-07:00 2008-08-27T13:38:19-07:00 Treat nil or empty bodies specially to avoid blowing up during response parsing. 7c214ed9d7df3205196c01124dcb61d6f99f48a3 John Nunemaker nunemaker@gmail.com