jnunemaker / mongomapper

When I add a key in an existing model, the previously created objects are not updated. A demonstration is worth a thousand words:

>> require 'mongo_mapper'
=> true
>> MongoMapper.database = 'itsatest'
=> "itsatest"
>> class Person
>>   include MongoMapper::Document
>>   key :first_key
>> end
=> #<MongoMapper::Key:0x101fe92a8 @name="first_key", @type=nil, @default_value=nil, @options={}>
>> first = Person.new(:first_key => 'first_value')
=> #<Person _id: nil, first_key: "first_value">
>> first.save
=> true
>> class Person
>>   key :second_key
>> end
=> #<MongoMapper::Key:0x101fd50c8 @name="second_key", @type=nil, @default_value=nil, @options={}>
>> Person.new
=> #<Person second_key: nil, _id: nil, first_key: nil>
>> first.second_key = 'second_value'
MongoMapper::KeyNotFound: Could not find key: "second_key"
    from /Library/Ruby/Gems/1.8/gems/mongo_mapper-0.6.8/lib/mongo_mapper/embedded_document.rb:361:in `read_attribute'
    from /Library/Ruby/Gems/1.8/gems/mongo_mapper-0.6.8/lib/mongo_mapper/dirty.rb:78:in `send'
    from /Library/Ruby/Gems/1.8/gems/mongo_mapper-0.6.8/lib/mongo_mapper/dirty.rb:78:in `clone_key_value'
    from /Library/Ruby/Gems/1.8/gems/mongo_mapper-0.6.8/lib/mongo_mapper/dirty.rb:118:in `write_attribute'
    from (eval):10:in `second_key='
    from (irb):13
>> first
=> #<Person _id: 4b3345d833e0ad021d000001, first_key: "first_value">

/Library/Ruby/Gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:440:in `load_missing_constant':NameError: uninitialized constant Mongo::InvalidStringEncoding

Ran across this error while trying to use mongomapper and grip to save mp3 files to gridfs. At first I was getting TypeError: no c encoder for this type yet (14), which I twittered, and someone said to install the ruby mongo driver from source and it would fix that problem. After updating the ruby driver it breaks mongomapper.

for example devise calls

errors.add(:email, :already_confirmed, :default => 'already confirmed')

which raises an argument error (3 for 2)

:order => :foo.desc

$where allows injection of bad things. Better to use case insensitive regex search here.

BlogPost.first(:parent_id => parent_id, :published_at.gte => published_at.utc, :id.ne => id, :order => 'published_at')

Should convert the id to _id but it doesn't.

>> Admin.destroy_all
src/tcmalloc.cc:186] Attempt to free invalid pointer: 0x2069d0
Abort trap

on REE ruby 1.8.6 (2008-08-11 patchlevel 287)

Right now you have to pass utc dates to queries for them to work. This would let mm do the work if you forget.

When saving time fields (including timestamps), date is saved correctly but time parameters are changed to '00:00:00'

Current mongomapper gem is 0.4.2 and depends on mongodb-mongo 0.14.1, which in edition to being out of date, cannot coexist with mongo_ext 0.18.1.

http://gemcutter.org/gems/mongomapper

I'm trying to add this example hash to an embedded document, and on create the mongo driver's ObjectID.from_string is being called on it.

{"action"=>"show", "id"=>"3", "controller"=>"transactions"}

The conflict is with the "id" field. This was working in an older version of MM prior to 0.6.0.

I assumed that there might be an implicit _id but there seems to be a conflict.

$ rake spec:models --trace (in /Users/arie/railsproject) Invoke spec:models (first_time) Invoke db:test:prepare (first_time) Invoke db:abort_if_pending_migrations (first_time) Invoke environment (first_time) Execute environment Execute db:abort_if_pending_migrations rake aborted!
ActiveRecord::ConnectionNotEstablished
/opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/abstract/connection_pool.rb:326:in retrieve_connection' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/abstract/connection_specification.rb:123:inretrieve_connection' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/connection_adapters/abstract/connection_specification.rb:115:in connection' /opt/local/lib/ruby/gems/1.8/gems/activerecord-2.3.5/lib/active_record/migration.rb:435:ininitialize' /opt/local/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/tasks/databases.rake:197:in new' /opt/local/lib/ruby/gems/1.8/gems/rails-2.3.5/lib/tasks/databases.rake:197 /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:incall' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in execute' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:ineach' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in execute' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:597:ininvoke_with_call_chain' /opt/local/lib/ruby/1.8/monitor.rb:242:in synchronize' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:ininvoke_with_call_chain' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:in invoke_prerequisites' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:ineach' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in invoke_prerequisites' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:ininvoke_with_call_chain' /opt/local/lib/ruby/1.8/monitor.rb:242:in synchronize' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:ininvoke_with_call_chain' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:607:in invoke_prerequisites' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:ineach' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:604:in invoke_prerequisites' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:596:ininvoke_with_call_chain' /opt/local/lib/ruby/1.8/monitor.rb:242:in synchronize' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:ininvoke_with_call_chain' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:583:in invoke' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2051:ininvoke_task' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in top_level' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:ineach' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in top_level' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:instandard_exception_handling' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:in top_level' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:inrun' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in standard_exception_handling' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:inrun' /opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31 /opt/local/bin/rake:19:in `load' /opt/local/bin/rake:19

$ cat config/environment.rb = '2.3.5' unless defined? RAILS_GEM_VERSION require File.join(File.dirname(FILE), 'boot')

Rails::Initializer.run do |config|
config.gem 'mongo_mapper' config.gem 'haml' config.frameworks -= [:active_record] config.time_zone = 'UTC' config.i18n.default_locale = :id end

MongoMapper.database = "railsproject-#{Rails.env}"

Wondering where else I could ask this after searching jnunemaker mongomapper mailing list ...

Reload returns a new document which is different than the ActiveRecord behavior of resetting the current object.

Looking at the tests, the convention with MM is to do:

  doc = @document.create(:phrase => 'Foo')
  doc = doc.reload
  doc.changed?.should be_false

I propose we change it to be more ActiveRecord like:

  doc = @document.create(:phrase => 'Foo')
  doc.reload
  doc.changed?.should be_false

I'll be adding support for that in my fork and send out a pull request soon.

hi, if I define initialize method in my data classes that include Document, instances no longer correctly load. (since MongoMapper does not have chance to do its magic)

basically I would like to have something like Person.new('myname') working together with MM

how to achieve that?

When a model belongs_to embedded model (EmbeddedDocument), MongoMapper throws

class Comment
  include MongoMapper::EmbeddedDocument
  { ... }
end

class Video
  include MongoMapper::Document
  { ... }
  key :comment_id

  belongs_to :comment
end

# => video.comment
undefined method `find_by_id' for Comment:Class

The dirty capability is available only in MongoMapper::Document.

I add capability to dirty in MongoMapper::EmbeddedDocument too.

My patch is on http://github.com/shingara/mongomapper/commit/bee324b44259c2f4759337da8fed058f206bc543

Any feedback are welcome.

There are no callback in EmbeddedDocument like report on ticket #73. So we can't use validation. there are no validation insert in EmbeddedDocument failing the save. But we can add this methods.

So we can avoid using this useless method or add callback in EmbeddedDocument.

To conform closer to Rails, please add Document.human_name. This is expected when, among other things, the Mongo Document object is used inside Rails forms (especially Formtastic)

As you have a rails_compatibility/document.rb, I hope this is not too unreasonable of a request :)

Thanks!

Set is not a natively supported type. That is, mongo_mapper does not ship with support for to_mongo and from_mongo for Set.

can save(false) mimic AR and save without calling the validations?

Hello,

Having removed Github as a gem source, I went to install mongomapper and hit some issues with dependencies that were only hosted on Github. For example, http://gemcutter.org/gems/mongodb-mongo

It might be worth looking into to get everything over to Gemcutter for a smoother installation process.

I'm not sure if this is intentional or if it's something I should be calling myself, but ensure_indexes! never seems to get called leaving the db with no indexes.

See http://groups.google.com/group/mongomapper/browse_thread/thread/7890275772de8e4f

When calling "delete_all" on a model, a TCPSocket-object is returned. I would expect the collection of removed objects to be returned, just as "destroy_all" does. Is this on purpose?

Tested with:
- Rails 2.3.4 - MongoDB 1.0.1 (OS X, 32 bit) - MongoMapper 0.4.2

To replicate:

• Create a class like this:

class Foo; include MongoMapper::Document; end

• On the Rails console: command "Foo.delete_all" returns: #<TCPSocket:0x12fad04>

Hey,

this project is really cool, but one thing, is possible merge jnunemaker-validatable in mongomapper?

Then (i think will not be simple) is possible remove activesupport dependencies? This because many of us don't use mongomapper only with rails but also for sinatra or merb and merb for example have their active-support.

Example:

BlogPost.all(:published_at => {:$lte => Time.zone.now})
=> MONGODB db.items.find({:type=>"BlogPost", :published_at=>{:type=>"BlogPost", :$lte=>Mon, 26 Oct 2009 18:24:33 EDT -04:00}})

Note the :_type => 'BlogPost' is being added to the :published_at hash as well. I've fixed this, and pushed it to orderedlist/mongomapper.

Currently, if you do:

@document['not-here']
# you will get
NoMethodError: undefined method `get' for nil:NilClass

A more user friendly error message would help. (This bit me, actually, that's why I fixed it). My suggestion is here:
http://github.com/djsun/mongomapper/commit/dc136dbf5ec380abca8dfd8f5e5f5b0decce0789

http://gist.github.com/216130

Ruby 1.9.1 p243, Rails 2.3.4

for example, you can't define a :key called "attributes"

See title.

All tests doesn't works like show by my integrity instance.

http://integrity.shingara.fr/mongomapper/commits/66424ec633bcc81076c40788828529ef44212192

I fix this test in my branch fix_test (http://github.com/shingara/mongomapper/commits/fix_test)

Per the mongo recommendation, http://www.mongodb.org/display/DOCS/Queries+and+Cursors, finder's first method should use mongodb's findOne method.

class Model 
  include MongoMapper::Document 
  many :widgets, :order => 'widget_size' 
end 

ActiveRecord provides us with attr_accessible to ensure that certain attributes aren't overridden by mass-assignment. As near as I can tell, MongoMapper doesn't currently offer such a feature.

>> class Thing; include MongoMapper::Document; key :do_not_exist_yet_id, String; belongs_to :do_not_exist_yet, :dependent => :destroy; end                                        
=> Thing
>> Thing.create
SystemStackError: stack level too deep
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/dirty.rb:57:in `initialize_without_dirty'
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/dirty.rb:57:in `initialize'
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/document.rb:117:in `new'
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/document.rb:117:in `create'
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/document.rb:116:in `each'
        from /usr/lib/ruby/gems/1.8/gems/mongo_mapper-0.5.4/bin/../lib/mongo_mapper/document.rb:116:in `create'
        from (irb):8

>> class Thing; include MongoMapper::Document; end
=> Thing
>> a = Thing.new
=> #
>> b = Thing.new
=> #
>> a[:foo] = nil
=> nil
>> b.save
=> true
>> b
=> #

ActiveModel (which will provide support for various ORMs) is deprecating the @model.errors.on(:method) convention in favor of @model.errors[:method]

perhaps mm should follow suit?

Documents seem to be reporting .changed? == true even after they are just loaded. This does not seem like the expected behaviour.

This toy script demonstrates the problem (I can't get the tests to run)

require 'rubygems'
require 'mongo_mapper'

MongoMapper.database = 'volatile_test'

class Log
include MongoMapper::Document key :text, String end

Log.create :text => "HELLO"

l = Log.first
puts "are records dirty by default? #{l.changed?}"

I'm using MongoMapper 0.5.2. I have several Time fields in my application that are getting set to Time.now on creation. (Of course, I'm not talking about the auto timestamps)

I wonder if this could be something happening at the MongoMapper or Mongo Ruby Driver levels. I'm not sure, this is just a hunch because I haven't isolated the problem yet.

Under Ruby 1.9 the "include MongoMapper::Finders" on line 7 of mongomapper/lib/mongo_mapper/associations/many_documents_proxy.rb crashes with the following error. To reproduce, go to the console and type "require 'mongo_mapper'".

    /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:105:in `rescue in const_missing': uninitialized constant MongoMapper::Associations::ManyDocumentsProxy::MongoMapper (NameError)
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:94:in `const_missing'
        from /Users/saadiq/dev/mongomapper/lib/mongo_mapper/associations/many_documents_proxy.rb:7:in `<class:ManyDocumentsProxy>'
        from /Users/saadiq/dev/mongomapper/lib/mongo_mapper/associations/many_documents_proxy.rb:3:in `<module:Associations>'
        from /Users/saadiq/dev/mongomapper/lib/mongo_mapper/associations/many_documents_proxy.rb:2:in `<module:MongoMapper>'
        from /Users/saadiq/dev/mongomapper/lib/mongo_mapper/associations/many_documents_proxy.rb:1:in `<top (required)>'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:156:in `require'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:156:in `block in require'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:521:in `new_constants_in'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:156:in `require'
        from /Users/saadiq/dev/mongomapper/lib/mongo_mapper.rb:75:in `<top (required)>'
        from /Users/saadiq/dev/mongomapper/test/test_helper.rb:15:in `require'
        from /Users/saadiq/dev/mongomapper/test/test_helper.rb:15:in `<top (required)>'
        from /Users/saadiq/dev/mongomapper/test/functional/associations/test_belongs_to_polymorphic_proxy.rb:1:in `require'
        from /Users/saadiq/dev/mongomapper/test/functional/associations/test_belongs_to_polymorphic_proxy.rb:1:in `<top (required)>'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `load'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `block in <main>'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `each'
        from /opt/local/lib/ruby1.9/gems/1.9.1/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `<main>'
    rake aborted!

When using Rails' fancy partial rending, Action View doesn't think that a mongo association is an Array.

When I use:

<%= render @list.items %>

I get:

Missing template arrays/_array.erb in view path app/views

Internally, Action View uses the case comparison operator to compare if the argument is an array (Array === arg), which apparently returns false for an association:

>> Array === []
=> true
>> Array === List.first.items
=> false

When building a basic has many like

class User
has_many :memberships end

class Membership
belongs_to :user end

when you query User.first.memberships in ruby 1.9, I get a stack level too deep problem.

I'm using inherited_resources in a rails app with mongo mapper. The update action on a document with a many association dies.

Processing CandidatesController#update (for 127.0.0.1 at 2009-10-04 19:04:44) [PUT]
Parameters: {"commit"=>"Save →", "id"=>"4ac7a91de23cde111f001002", "candidate"=>{"notes"=>"here is some text for a note", "phones"=>{"number"=>"555-555-5555", "type"=>"Mobile"}, "alias"=>"huskies"}}

NoMethodError (undefined method each_pair' for ["number", "555-555-5555"]:Array):<br/> mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:209:inattributes=' mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:186:in initialize' mongomapper (0.4.1) lib/mongomapper/associations/many_embedded_proxy.rb:46:innew' mongomapper (0.4.1) lib/mongomapper/associations/many_embedded_proxy.rb:46:in find_target' mongomapper (0.4.1) lib/mongomapper/associations/many_embedded_proxy.rb:45:inmap' mongomapper (0.4.1) lib/mongomapper/associations/many_embedded_proxy.rb:45:in find_target' mongomapper (0.4.1) lib/mongomapper/associations/proxy.rb:48:inload_target' mongomapper (0.4.1) lib/mongomapper/associations/proxy.rb:38:in method_missing' mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:251:into_mongo' mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:249:in each' mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:249:into_mongo' mongomapper (0.4.1) lib/mongomapper/document.rb:328:in save_to_collection' mongomapper (0.4.1) lib/mongomapper/document.rb:323:inupdate_without_callbacks' mongomapper (0.4.1) lib/mongomapper/callbacks.rb:49:in update' mongomapper (0.4.1) lib/mongomapper/document.rb:307:increate_or_update_without_callbacks' mongomapper (0.4.1) lib/mongomapper/callbacks.rb:25:in create_or_update' mongomapper (0.4.1) lib/mongomapper/document.rb:290:insave_without_validation' mongomapper (0.4.1) lib/mongomapper/save_with_validation.rb:12:in save' mongomapper (0.4.1) lib/mongomapper/embedded_document.rb:305:inupdate_attributes' app/controllers/candidates_controller.rb:63:in update' /Library/Ruby/Gems/1.8/gems/josevalim-inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:101:incall' /Library/Ruby/Gems/1.8/gems/josevalim-inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:101:in retrieve_response_from_mimes' /Library/Ruby/Gems/1.8/gems/josevalim-inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:56:inrespond_to' app/controllers/candidates_controller.rb:62:in `update'

Test revealing the problem here:
http://github.com/djsun/mongomapper/tree/problematic-empty-string-default

This is the current version (0.4.1):
http://github.com/jnunemaker/mongomapper/blob/master/test/functional/associations/test_belongs_to_proxy.rb

Here is my gist that illustrates several lines are false positives:
http://gist.github.com/201533

There seems to be a collision with ActiveRecord when using save on a new instance of a class which includes MongoMapper::Document. "NoMethodError: private method `save' called for #<RequestStatistic:0x1034a1e70>" Calling #update_attributes without any params saves the object. Using create also raises the same error.

Make methods like attribute_name_changed? and attribute_name_was

Hi,

Documents that inherit from another document don't inherit the parent's class associations.

Example :

class Message
  include MongoMapper::Document

  key :body, String
  key :position, Integer
  key :_type, String
  key :room_id, String

  belongs_to :room
end

class Enter < Message; end
class Exit < Message;  end
class Chat < Message;  end

Enter, Exit and Chat should have "belongs_to :room" as association too (like his superclass Message).
I made a patch for this issue :

http://github.com/yeastymobs/mongomapper/commit/31052613fbdaba769294d0e46e1629d31e49528e

This would be useful to keep logic in the most relevant place, especially when the document is embedded in multiple models.

I don't know how hard this would be to implement. I looked into it a bit, but I don't know how to access the parent of the embedded document. Is this something you are interested in?

Document#find([an_id]) should return an array

Given:

config.gem 'jnunemaker-mongomapper', :lib => 'mongomapper'

Rails appears to be unsatisfied unless require 'mongomapper' is somewhere, I assume because of autoloading -- Rails expects that the constant "MongoMapper" will map to a file called mongo_mapper.rb. Solution is to add a file to lib called mongo_mapper.rb with:

require 'mongomapper'

I added a way to extend has_many associations using a block or an :extend option. Extending belongs_to should work as well I believe, although I haven't tested that as I can't really think of a use case for it. Anyway I made a branch for it here, so you can check it out. If you like it, I should probably send you a patch as I stupidly pulled in changes from another fork into master thinking I'd use them before I made the branch, so it might be difficult to merge ;)

Here's the backtrace:

  Status: 500 Internal Server Error
  stack level too deep
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/byte_buffer.rb:65:in `put_array'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/byte_buffer.rb:72:in `put_int'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:422:in `serialize_number_element'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:118:in `serialize_key_value'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:95:in `serialize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:95:in `each'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:95:in `serialize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:430:in `serialize_object_element'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:120:in `serialize_key_value'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:95:in `serialize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/ordered_hash.rb:50:in `each'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/ordered_hash.rb:50:in `each'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/util/bson.rb:95:in `serialize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/message/message.rb:62:in `write_doc'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/message/query_message.rb:67:in `initialize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:218:in `new'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:218:in `send_query_if_needed'
    /usr/lib64/ruby/1.8/mutex_m.rb:67:in `synchronize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/db.rb:534:in `_synchronize'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:217:in `send_query_if_needed'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:195:in `refill_via_get_more'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:179:in `num_remaining'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:50:in `more?'
    /usr/lib64/ruby/gems/1.8/gems/mongodb-mongo-0.11.1/lib/mongo/cursor.rb:116:in `to_a'
    /usr/lib64/ruby/gems/1.8/gems/mongomapper-0.3.3/lib/mongomapper/document.rb:174:in `find_every'
    /usr/lib64/ruby/gems/1.8/gems/mongomapper-0.3.3/lib/mongomapper/document.rb:179:in `find_first'
    /usr/lib64/ruby/gems/1.8/gems/mongomapper-0.3.3/lib/mongomapper/document.rb:52:in `first'
    /data/busk/releases/20090903194259/app/models/url.rb:15:in `generate_code'
    /data/busk/releases/20090903194259/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in `send'
    /data/busk/releases/20090903194259/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in `evaluate_method'

(This is probably due to the underlying Validatable library.)

Here is an example from the project I'm working on:

r = Rating.new
r.errors
=> #<Validatable::Errors:0x102392c10>
r.valid?
=> false
r.errors
=> #<Validatable::Errors:0x102392c10 @errors={:kind=>["is invalid"]}>

Log stuff like collection, query and query time

Page isa MongoMapper::Document

page_opts = { :attribute1 => 'value1', :attribute2 => 'attribute2' } 
p = Page.find(:first)        
page_opts.each do |attribute, value|
p.send attribute, value
end

Code used to work under previous versions of mongomapper but no object.send seems broke.

timestamps! is an unknown method for : MongoMapper::EmbeddedDocument

http://github.com/mongodb/mongo-ruby-driver/commit/ad74f0d9d85fee3f17db168da6f966b1f264f38b

I think now that dynamic finders are in 0.3.3, it would be very natural to have a dynamic finder for many associations as well.

magazine.subscriptions.find_by_isbn(isbn)

would be equivalent to:

Subscription.first(:conditions => { :magazine_id => magazine.id, :isbn_url => isbn) })

_ type is the first that comes to mind. There may be others. This will fix issues with polymorphic models and load order and will also make it easier to address _type assignment when not scoped to association.

You can use longs currently with dynamic keys though since the driver supports them. I have never used them really so I'm not the person to implement the typecasting of Longs to actually make them a native mongomapper type.

Right now if you there is a key in the database you don't have in your model, it throws an error.

http://groups.google.com/group/mongomapper/browse_thread/thread/1868dee9eb24b200?hl=en

This is a bit more consistent with find_by... and find_by...! and such. Find will always return nil if document not found by id and find! will work like find currently does raising a DocumentNotFound exception.

validates_uniqueness should have support for :scope option

When obj.update_attributes fails to save (ie due to validation) the obj is returned instead of false. This causes validation messages not to work on updates in the rails view. For Example:

def update
  @note = Note.find(params[:id])
  if @note.update_attributes(params[:note])
    redirect_to @note
  else
    render 'edit'
  end
end

Just redirects if the validation fails instead of rendering 'edit' because the note object is returned.

irb example:

>> note.update_attributes(:title => '')
=> #<Note _id: bf8601aa4a7dd708000000eb, created_at: 2009-08-08 19:50:32 UTC, updated_at: 2009-08-08 20:25:44 UTC, title: , body: this is note 1, tags: []>

If I have a Message with a body and its child Enter with a key title that it's not in Message, I have an error when I retrieve all messages :

class Message
  include MongoMapper::Document

  key :body, String
end

class Enter < Message
  key :title, String
end

Enter.create(:body => "Body test", :title => "Title test")
Message.all # It breaks because title= is undefined in Message

I have Message, Enter and Exit inherit from it. If I create a Enter document, I have nothing in _type. But if I create it in the association array, it works :

>> Enter.create # It doesn't work
>> r=Room.create
>> r.messages << Enter.create # It works

Hi,

I have a model Message, Enter and Exit derived from it. I create one document for each, then I want all the Enter documents. But the result is wrong and I have all the documents but with the right _type (Enter for one, Exit for the other) :

>> r=Room.create
>> r.messages = [Enter.create, Exit.create]
>> Enter.all
=> [ #< Enter updated_at: Thu Aug 06 14:20:43 UTC 2009, _id: 4df37cd94a7ae6bb00000068, _type: Enter, created_at: Thu Aug 06 14:20:43 UTC 2009>, #< Enter updated_at: Thu Aug 06 14:28:06 UTC 2009, _id: 4df37cd94a7ae87600000068, _type: Exit, created_at: Thu Aug 06 14:28:06 UTC 2009>]

But I just want the Enter documents.

NB : If I do Enter.create without passing it in the association I have nothing in _type, but I'm gonna create another issue for that.

In order to get tests passing on my system, I had to change several tests to "should_eventually" (e.g. marking them as pending so they don't run).

http://github.com/djsun/mongomapper/commit/f15dfa9f18078e9ef6a5f49fd86de05b6bae9168

http://github.com/djsun/mongomapper/commit/cc486bef3365364a3531c3e8b8d0d7975e067a52

Intermittent failures are tricky. I ran test_many_polymorphic_proxy.rb test probably 20+ times to identify the ones above.