<?xml version="1.0" encoding="UTF-8"?>
<commit>
  <added type="array"/>
  <modified type="array">
    <modified>
      <diff>@@ -1,6 +1,6 @@
 #!/usr/bin/env python
 
-#Copyright Joel Schaerer 2008, 2009
+#Copyright Joel Schaerer and Pierre Gueth 2008, 2009
 #This file is part of autojump
 
 #autojump is free software: you can redistribute it and/or modify
@@ -113,14 +113,13 @@ def popup(sender,button,activation):
     else:
         def collapse_home(path):
             return path
-
-
+    
     menu=gtk.Menu()
     if defaults[&quot;invert&quot;]:
-        item=gtk.MenuItem(&quot;quit&quot;)
+        item=gtk.ImageMenuItem(stock_id=gtk.STOCK_QUIT)
         item.connect(&quot;activate&quot;,quit)
         menu.append(item)
-        item=gtk.MenuItem(&quot;settings&quot;)
+        item=gtk.ImageMenuItem(stock_id=gtk.STOCK_PREFERENCES)
         item.connect(&quot;activate&quot;,settings)
         menu.append(item)
 
@@ -154,10 +153,10 @@ def popup(sender,button,activation):
 
         menu.append(gtk.SeparatorMenuItem())
         
-        item=gtk.MenuItem(&quot;settings&quot;)
+        item=gtk.ImageMenuItem(stock_id=gtk.STOCK_PREFERENCES)
         item.connect(&quot;activate&quot;,settings)
         menu.append(item)
-        item=gtk.MenuItem(&quot;quit&quot;)
+        item=gtk.ImageMenuItem(stock_id=gtk.STOCK_QUIT)
         item.connect(&quot;activate&quot;,quit)
         menu.append(item)
 
@@ -165,14 +164,15 @@ def popup(sender,button,activation):
     menu.popup(None,None,gtk.status_icon_position_menu,button,activation,sender)
 
 def settings(sender):
-    window=gtk.Window(gtk.WINDOW_TOPLEVEL)
-    window.set_title(&quot;jump applet settings&quot;)
+    window=gtk.Dialog(&quot;jump applet preferences&quot;,None,gtk.DIALOG_MODAL|gtk.DIALOG_DESTROY_WITH_PARENT,(gtk.STOCK_SAVE,gtk.RESPONSE_OK,gtk.STOCK_CANCEL,gtk.RESPONSE_CANCEL))
     window.set_border_width(3)
     window.set_resizable(False)
+    if os.path.isfile(&quot;icon.png&quot;): window.set_icon_from_file(&quot;icon.png&quot;)
+    elif os.path.isfile(&quot;/usr/share/autojump/icon.png&quot;): window.set_icon_from_file(&quot;/usr/share/autojump/icon.png&quot;)
 
-    vbox=gtk.Table(6,2)
+    vbox=gtk.Table(5,2)
     vbox.set_row_spacings(3)
-    window.add(vbox)
+    window.get_child().add(vbox)
     def add_string_setting(name,label,nsettings):
         label=gtk.Label(label+' ')
         label.set_alignment(1.,.5)
@@ -205,19 +205,19 @@ def settings(sender):
         return (name,entry)
 
     entries=[]
-    entries.append(add_string_setting(&quot;terminal&quot;,&quot;terminal program&quot;,0))
-    entries.append(add_string_setting(&quot;navigator&quot;,&quot;navigator program&quot;,1))
-    entries.append(add_integer_setting(&quot;maxpath&quot;,&quot;number of directories&quot;,2))
-    entries.append(add_bool_setting(&quot;invert&quot;,&quot;list directories in reverse order&quot;,3))
-    entries.append(add_bool_setting(&quot;collapse&quot;,&quot;collapse home directory to ~&quot;,4))
-    button=gtk.Button(&quot;save&quot;)
-    button.connect(&quot;clicked&quot;,save_settings,entries,window)
-    vbox.attach(button,0,2,5,6)
+    entries.append(add_string_setting(&quot;terminal&quot;,&quot;Terminal program&quot;,0))
+    entries.append(add_string_setting(&quot;navigator&quot;,&quot;Navigator program&quot;,1))
+    entries.append(add_integer_setting(&quot;maxpath&quot;,&quot;Number of directories&quot;,2))
+    entries.append(add_bool_setting(&quot;invert&quot;,&quot;List directories in reverse order&quot;,3))
+    entries.append(add_bool_setting(&quot;collapse&quot;,&quot;Collapse home directory to ~&quot;,4))
 
+    window.connect(&quot;response&quot;,save_settings,entries,window)
     window.show_all();
 
-def save_settings(sender,entries,window):
+def save_settings(sender,response,entries,window):
     window.hide_all()
+    if response!=gtk.RESPONSE_OK: return
+
     global defaults
     for name,entry in entries:
         try:</diff>
      <filename>jumpapplet</filename>
    </modified>
  </modified>
  <removed type="array"/>
  <parents type="array">
    <parent>
      <id>337e16391c1edbb587c628693936c0665a95c399</id>
    </parent>
  </parents>
  <author>
    <name>georges.wbushjr@laposte.net</name>
    <email>pierre@elgato.(none)</email>
  </author>
  <url>http://github.com/joelthelion/autojump/commit/be6427ceb8ba2485e38b1114e2878655ce209f0c</url>
  <id>be6427ceb8ba2485e38b1114e2878655ce209f0c</id>
  <committed-date>2009-05-14T12:43:04-07:00</committed-date>
  <authored-date>2009-05-14T12:43:04-07:00</authored-date>
  <message>nice gui ;)</message>
  <tree>3955387d3431061244695b7270cb84b67753f446</tree>
  <committer>
    <name>georges.wbushjr@laposte.net</name>
    <email>pierre@elgato.(none)</email>
  </committer>
</commit>
