Skip to content

Commit

Permalink
made client/user tests pass by updating client and user models
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Hoyt authored and Jonathan Hoyt committed Mar 24, 2009
1 parent 6e74d12 commit 0880041
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 15 deletions.
35 changes: 21 additions & 14 deletions app/models/client.rb
@@ -1,6 +1,6 @@
class Client < ActiveRecord::Base

belongs_to :user
has_one :user

has_attached_file :mugshot,
:styles => { :medium => "400x300>",
Expand All @@ -20,6 +20,14 @@ class Client < ActiveRecord::Base

after_update :save_phones, :save_emails, :save_addresses

validate :validates_has_a_name

def validates_has_a_name
if name.blank? && firstname.blank? && lastname.blank?
errors.add_to_base('Client needs at least a firstname, or a lastname, or a company name')
end
end

def to_json(options={})
super(options.merge(:methods => :lastfirst))
end
Expand Down Expand Up @@ -86,7 +94,7 @@ def save_addresses
address.save(false)
end
end

def company_name
if self.belongs_to != nil
company = Client.find(self.belongs_to)
Expand All @@ -99,19 +107,27 @@ def company_name
def fullname
if self.company == true
return self.name
elsif self.firstname != nil || self.lastname != nil
elsif !self.firstname.blank? && !self.lastname.blank?
return "#{self.firstname} #{self.lastname}"
else
return "#{self.firstname}"
return self.somename
end
end

def lastfirst
if self.company == true
return self.name
elsif self.firstname != nil || self.lastname != nil
elsif !self.firstname.blank? && !self.lastname.blank?
return "#{self.lastname}, #{self.firstname}"
else
return self.somename
end
end

def somename
if self.firstname.blank? && !self.lastname.blank?
return "#{self.lastname}"
elsif !self.firstname.blank? && self.lastname.blank?
return "#{self.firstname}"
end
end
Expand All @@ -137,13 +153,4 @@ def primary_address
def open_tickets
Ticket.find(:all, :conditions => {:archived_on => nil, :client_id => self.id})
end

def active_dialup_user?
if self.radcheck && self.radcheck.value[0..8] != "disabled_"
return true
else
return false
end
end

end
2 changes: 1 addition & 1 deletion app/models/user.rb
Expand Up @@ -17,7 +17,7 @@ class User < ActiveRecord::Base

# Relationships
has_and_belongs_to_many :roles
has_one :client
belongs_to :client
has_many :schedules

has_attached_file :avatar,
Expand Down

0 comments on commit 0880041

Please sign in to comment.