josevalim / inherited_resources

There are some problem areas where exceptions are being silently discarded only to lead to errors further on that are hard to track down.

E.g. class_methods.rb:306 gets the resource class but rescues and returns nil if my model definition has an error, leading to an exception in the IR code later on when it calls find on nil.

There are also "rescue nil" lines in the controller methods that have caused me problems.

Will fork and try to patch in Jan, but if there are any particular reasons for these or no one else experiences this I'd be interested in hearing about it.

Thanks!

I have a resource that has some accessors created within an after_initialize method...

class Project < ActiveRecord::Base
  def after_initialize
    # create method...
  end
  ...

In the controller I have the "new" action automatically created with inherited resources. However, the resource is nil when it hits the "after_initialize". However, if I explicitly add the new method, everyone works fine...

 def new
   @project = end_of_association_chain.new
 end

Shouldn't the resource being automatically created with inherited resources also be using end_of_association_chain.new?

BTW - I do have :new listed as an action in the controller, and inherited resources works splendidly almost everywhere

Best regards,
David Baldwin

I am trying out inherited_resources with DataMapper. I found that mimes_for_respond_to resolves to nil. Based on my debugging, I think this is because inherited_resources assumes developers are using the class inheritable attribute methods from ActiveSupport, while DataMapper provides a subset of those methods with a different implementation using the Extlib gem. This results in data being stored using ActiveSupport's write_inheritable_attribute method, but that data can't be accessed because inherited_resources ends up using Extlib's class_inheritable_reader, resulting in mimes_for_respond_to resolving to nil. Not sure how to do a work-around gracefully without messing up other libs that depend on DataMapper's Extlib and ActiveSupport.

I still get flash notices when updating a model using js. I may have missed it in the docs, but is there a way to turn that off?

When I add actions as follow:
> actions :index, :show, :new, :edit, :create, :update and try to delete it's delete the field in database. So, it's a bug! I don't want to delete anything.

But, when I add actions like:
> actions :all, :except => [ :destroy ] and try to delete it doesn't delete. So, it's correct because I don't want to create destroy action.

Thanks,

It would be nice if in addition to "parent_url", there was "edit_parent_url". Additions/updates to children may often redirect to the edit page of the parent rather than the show. (at least in my apps, but maybe I'm doing it wrong)

Best Regards,
David Baldwin

Hello,

I tried to use inherited resources with acts_as_tree without success. An example:

class Page < ActiveRecord::Base
  acts_as_tree
end

class PagesController < ApplicationController
  inherit_resources
  respond_to :html
  actions :all
  belongs_to :parent, :optional => true
end

map.resources :pages, :has_many => :pages

When I access http://localhost:3000/pages/3/pages the filter doesn't work.

I got the same behaviour of http://localhost:3000/pages/

You can verify that?

I'm using IR for my project and its been fine between has_many relations.
But how does this behave for has_many :through associated models?
There ain't any doc in the README for this.

I have an invitations controller that I would like to use both nested as well as unnested. The controller is set up like this:

class InvitationsController < ApplicationController
inherit_resources
belongs_to :league
end

and I am accessing the controller both from /leagues/{id}/invitations and /invitations

Since inherited_resources always assumes a parent if belongs_to is defined, it throws an error trying to find the parent league when I access the unnested route. Instead, it should check for the presence of the parent_id first and only load the parent if it exists.

Hi,

This thread: http://groups.google.com.au/group/formtastic/browse_thread/thread/9bb5d808d2a9adbf talk about cancel button.

I write a method that I'm using into a initializer file (is a monkey patch in really) but do the proposed feature.

I know that's obstrutive solution using window.history.back() or window.location = url; but the unobstrutive solution aren't greater IMHO (create a inline form reseting all css properties of this form elements using action to proposed url and get method).

This sounds to a bad workaround.

The dev will be advised about obstrutivity and I guess that's not a problem considering dev can make the unobstrutive solution by yourself if really needed.

You will use the cancel_button method:

- form.inputs do
  = form.submit_button
  = form.cancel_button
  = form.cancel_button admin_pages_path
  = form.cancel_button admin_pages_path, { :button_html => { :class => 'pretty_button' } }
  = form.cancel_button admin_pages_path, 'Cancel updates'
  = form.cancel_button admin_pages_path, 'Cancel updates', { :button_html => { :class => 'pretty_button' } }

The default url is :back, this means, window.history.back() and the default button text is I18n.t('formtastic.cancel', :default => 'Cancel').

If you specify a url, this will be "window.location = #{url.to_json}"

I guess this solve 99.9% of cancel button cases.

See the code: http://paste.pocoo.org/show/145765/

Seeing as how Github no longer supports building gems, can you add this gem to gemcutter? I am currently unable to find it there as I migrate all my old github gems to their gemcutter counterparts.

In my app, I'm using Clearance as my Auth purpose. I'm trying to use IHR.
For the model association,

#user.rb
has_many :masterpieces, :dependent => :destroy
#masterpiece.rb
belongs_to :user

Masterpiece controller:

class MasterpiecesController < ApplicationController
  before_filter :authenticate, :except => [:show, :index]
  def index
    @masterpieces = Masterpiece.all
  end
  def new
    @masterpiece = current_user.masterpieces.build
  end
  def create
    @masterpiece = current_user.masterpieces.build(params[:masterpiece])
    respond_to do |format|
      if @masterpiece.save
        flash[:notice] = 'Masterpiece was successfully created.'
        format.html { redirect_to(@masterpiece) }
        format.xml  { render :xml => @masterpiece, :status => :created, :location => @masterpiece }
      else
        format.html { render :action => "new" }
        format.xml  { render :xml => @masterpiece.errors, :status => :unprocessable_entity }
      end
    end

  end
  def show
    @masterpiece = current_user.masterpieces.find(params[:id])
  end
end

Now when I replace this controller with this version using IHR:

class MasterpiecesController < InheritedResources::Base
  before_filter :authenticate, :except => [:show, :index]

  respond_to :html, :js
  belongs_to :user

  protected

  def begin_of_association_chain
    current_user
  end
end

And I go to /masterpieces/new
I get the following error:

 NoMethodError in MasterpiecesController#new

undefined method `users' for #

And allow parent to be created using association_chain.

make_resourceful adds many methods as action_methods, that is public methods available via web.

I forked this project (http://github.com//jo/make_resourceful/) with a commit to hide those methods (http://github.com/jo/make_resourceful/commit/68e3e4a229e9363eba04388540818e68220194db)

Maybe on finds a better solution for that.

Shoot me down if I'm being pedantic, but this is Ruby!

I'm wondering if there's any reason for naming "begin_of_association_chain" as such ... it's not correct English, and I feel it sticks out in an otherwise very solid implementation.

I'd hazard that it should be 'beginning_of_association_chain" or "start_of_association_chain"

What do you think? Is this too anal?

Paul

Hi,

I was trying out inherited_resources today and got it working really well with a test controller in an admin/ namespace ... The controller worked great in Safari, but not so much in Firefox (3.5) ... claiming that the template was not present...

... appending ".html" to the URL makes it work, so I suspect that there's no defaulting to .html in the plugin, perhaps a reliance on the Accept header?

Paul

TypeError ({:with=>#} is not a symbol):
  /Users/jonas/.ruby_versions/ruby-1.9.1-p129/lib/ruby/gems/1.9.1/gems/inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:100:in `block in retrieve_response_from_mimes'
  /Users/jonas/.ruby_versions/ruby-1.9.1-p129/lib/ruby/gems/1.9.1/gems/inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:100:in `each'
  /Users/jonas/.ruby_versions/ruby-1.9.1-p129/lib/ruby/gems/1.9.1/gems/inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:100:in `retrieve_response_from_mimes'
  /Users/jonas/.ruby_versions/ruby-1.9.1-p129/lib/ruby/gems/1.9.1/gems/inherited_resources-0.9.1/lib/inherited_resources/legacy/respond_to.rb:56:in `respond_to'
  ...

Note: I run a slightly modified version of InheritedResources, but only touched rake/tests so far.

$ rake test --trace                                                                                                                                                           (09-04 03:44)
(in /Users/Jonas/Development/examples/inherited_resources)
** Invoke test (first_time)
** Execute test
/opt/local/bin/ruby -I"lib" "/opt/local/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/aliases_test.rb" "test/association_chain_test.rb" "test/base_test.rb" "test/belongs_to_test.rb" "test/class_methods_test.rb" "test/customized_belongs_to_test.rb" "test/defaults_test.rb" "test/flash_test.rb" "test/has_scope_test.rb" "test/nested_belongs_to_test.rb" "test/optional_belongs_to_test.rb" "test/polymorphic_test.rb" "test/redirect_to_test.rb" "test/respond_to_test.rb" "test/singleton_test.rb" "test/url_helpers_test.rb" 
DEPRECATION WARNING: has_scope :key is deprecated, use :as instead. (called from has_scope at /Users/Jonas/Development/examples/inherited_resources/lib/inherited_resources/class_methods.rb:131)
/opt/local/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/dependencies.rb:105:in `const_missing': uninitialized constant Test::Unit::TestResult::TestResultFailureSupport (NameError)
    from /opt/local/lib/ruby/gems/1.8/gems/test-unit-2.0.2/lib/test/unit/testresult.rb:28
    from /opt/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'

While searching for info on this I found:

You can't use Test::Unit 2.0 with old Test::Unit.
Call 'gem "test-unit"' before 'require "test/unit".

The syntax:

def create
  create!{ another_url }
end

Does not work with Rspec controller specs if integrate views is false because that template is executed just if a template is not found. Since rspec hacks all templates to be found on integrate_views equals to true, the code is never executed. The solution is to use success and failure blocks:

def create
  create! do |success, failure| 
    success.html { another_url }
  end
end

When the exception is raised because no polymorphic association is found, the exception text contains #{polymorphic_symbols.inspect}. It throws another error because polymorphic_symbols doesn't exist.

if key.nil?

          raise ScriptError, "Could not find param for polymorphic association.
                              The request params keys are #{params.keys.inspect}
                              and the polymorphic associations are
                              #{polymorphic_symbols.inspect}." unless polymorphic_config[:optional]

          nil

Consider also adding child_url and sibling_url.

I've got a controller like this:

class BrandsController < InheritedResources::Base
  before_filter :authenticate, :ensure_brand_manager

  actions    :new, :create
  belongs_to :sponsor

  protected

  def ensure_brand_manager
    sponsor = Sponsor.find(params[:sponsor_id])
    unless sponsor.brand_managers.include?(current_user)
      flash[:failure] = "Permission denied"
      redirect_to root_path
    end
  end
end

The line I'd like to push off to Inherited Resources is:

sponsor = Sponsor.find(params[:sponsor_id])

On this controller, I'd like there to be protected methods available to me that do:

sponsor = Sponsor.find(params[:sponsor_id])
brand = Brand.find(params[:id])

and/or:

parent = Sponsor.find(params[:sponsor_id])
resource = Brand.find(params[:id])

Making these available in all Inherited Resources controllers would save me a line in about all of my controllers while maintaining readability.

What do you think?