0
@@ -1,5 +1,19 @@
0
 *SVN*
0
 
0
+* Allow overriding of find parameters in scoped has_many :through calls [Rick Olson]
0
+
0
+  In this example, :include => false disables the default eager association from loading.  :select changes the standard
0
+  select clause.  :joins specifies a join that is added to the end of the has_many :through query.
0
+  
0
+    class Post < ActiveRecord::Base
0
+      has_many :tags, :through => :taggings, :include => :tagging do
0
+        def add_joins_and_select
0
+          find :all, :select => 'tags.*, authors.id as author_id', :include => false,
0
+            :joins => 'left outer join posts on taggings.taggable_id = posts.id left outer join authors on posts.author_id = authors.id'
0
+        end
0
+      end
0
+    end
0
+    
0
 * Fixed that schema changes while the database was open would break any connections to a SQLite database (now we reconnect if that error is throw) [DHH]
0
 
0
 * Don't classify the has_one class when eager loading, it is already singular. Add tests. (closes #4117) [jonathan@bluewire.net.nz]

0
@@ -24,10 +24,10 @@ module ActiveRecord
0
           options[:order] = @reflection.options[:order]
0
         end
0
         
0
-        options[:select]    = construct_select
0
-        options[:from]      = construct_from
0
-        options[:joins]     = construct_joins
0
-        options[:include] ||= @reflection.source_reflection.options[:include]
0
+        options[:select]  = construct_select(options[:select])
0
+        options[:from]  ||= construct_from
0
+        options[:joins]   = construct_joins(options[:joins])
0
+        options[:include] = @reflection.source_reflection.options[:include] if options[:include].nil?
0
         
0
         merge_options_from_reflection!(options)
0
 
0
@@ -84,11 +84,11 @@ module ActiveRecord
0
           @reflection.table_name
0
         end
0
         
0
-        def construct_select
0
-          selected = @reflection.options[:select] || "#{@reflection.table_name}.*"          
0
+        def construct_select(custom_select = nil)
0
+          selected = custom_select || @reflection.options[:select] || "#{@reflection.table_name}.*"          
0
         end
0
         
0
-        def construct_joins
0
+        def construct_joins(custom_joins = nil)
0
           if @reflection.through_reflection.options[:as] || @reflection.source_reflection.macro == :belongs_to
0
             reflection_primary_key = @reflection.klass.primary_key
0
             source_primary_key     = @reflection.source_reflection.primary_key_name
0
@@ -96,8 +96,8 @@ module ActiveRecord
0
             reflection_primary_key = @reflection.source_reflection.primary_key_name
0
             source_primary_key     = @reflection.klass.primary_key
0
           end
0
-          
0
-          "INNER JOIN %s ON %s.%s = %s.%s #{@reflection.options[:joins]}" % [
0
+
0
+          "INNER JOIN %s ON %s.%s = %s.%s #{@reflection.options[:joins]} #{custom_joins}" % [
0
             @reflection.through_reflection.table_name,
0
             @reflection.table_name, reflection_primary_key,
0
             @reflection.through_reflection.table_name, source_primary_key

0
@@ -63,6 +63,17 @@ class AssociationsJoinModelTest < Test::Unit::TestCase
0
     end
0
   end
0
 
0
+  def test_polymorphic_has_many_going_through_join_model_with_disabled_include
0
+    assert_equal tags(:general), tag = posts(:welcome).tags.add_joins_and_select.first
0
+    assert_queries 1 do
0
+      tag.tagging
0
+    end
0
+  end
0
+
0
+  def test_polymorphic_has_many_going_through_join_model_with_custom_select_and_joins
0
+    assert_equal tags(:general), tag = posts(:welcome).tags.add_joins_and_select.first
0
+    tag.author_id
0
+  end
0
 
0
   def test_polymorphic_has_many_going_through_join_model_with_custom_foreign_key
0
     assert_equal tags(:misc), taggings(:welcome_general).super_tag

0
@@ -21,7 +21,13 @@ class Post < ActiveRecord::Base
0
   has_and_belongs_to_many :special_categories, :join_table => "categories_posts", :association_foreign_key => 'category_id'
0
 
0
   has_many :taggings, :as => :taggable
0
-  has_many :tags, :through => :taggings, :include => :tagging
0
+  has_many :tags, :through => :taggings, :include => :tagging do
0
+    def add_joins_and_select
0
+      find :all, :select => 'tags.*, authors.id as author_id', :include => false,
0
+        :joins => 'left outer join posts on taggings.taggable_id = posts.id left outer join authors on posts.author_id = authors.id'
0
+    end
0
+  end
0
+  
0
   has_many :funky_tags, :through => :taggings, :class_name => 'Tag'
0
   has_many :super_tags, :through => :taggings
0
   has_one :tagging, :as => :taggable