The rails Network Feed  

I was just merging rick’s attachment_fu differences, it’s minor garbage enhancements but no huge deal, don’t overthink it guys :)

Textile Reference I followed said to do pre and code.
Let’s try just code so you can see the html. I also took out lt and gt.
<code>
form action="/inventory/requests/350903690" class="edit_request" id="edit_request_350903690" method="post">
input id="request_existing_line_item_attributes_51161156_equipment_type_id" name="requestexisting_line_item_attributes[equipment_type_id]" size="30" type="text" value="691081111" /
input id="request_existing_line_item_attributes___existing_equipment_line_item_attributes_860256615_equipment_id" name="request[existing_line_item_attributes[]]existing_equipment_line_item_attributes[equipment_id]" size="30" type="text" value="1029003634" /
/form
</code>

Generation of HTML element id and form field name are inconsistent after 2nd level of nesting.
<pre>
<code>
<% form_for([: inventory, @request]) do |f| >
< line_item = @request.line_items.first >
< f.fields_for "existing_line_item_attributes[]", line_item do |li| >
<= li.text_field :equipment_type_id >
< equipment_li = line_item.equipment_line_items.first >
< li.fields_for "existing_equipment_line_item_attributes[]", equipment_li do |eli| >
<= eli.text_field :equipment_id >
< end >
< end >
< end %>
</code>
</pre>
Generates this:
<pre>
<code>
<form action="/inventory/requests/350903690" class="edit_request" id="edit_request_350903690" method="post">
<input id="request_existing_line_item_attributes_51161156_equipment_type_id" name="requestexisting_line_item_attributes[equipment_type_id]" size="30" type="text" value="691081111" />
<input id="request_existing_line_item_attributes___existing_equipment_line_item_attributes_860256615_equipment_id" name="request[existing_line_item_attributes[]]existing_equipment_line_item_attributes[equipment_id]" size="30" type="text" value="1029003634" />
</form>
</code>
</pre>
You notice that the in the 3rd level that the 2nd level ID is missing and that the "[]" are enclosed within the first field.
I was able to get the the above form to work as expected by removing the brackets and explicitly setting the id.Generation of HTML element id and form field name are inconsistent after 2nd level of nesting.
<pre>
<code>
<% form_for([:inventory, @request]) do |f| >
< line_item = @request.line_items.first >
< f.fields_for "existing_line_item_attributes", line_item, :index => line_item.id do |li| >
<= li.text_field :equipment_type_id >
< equipment_li = line_item.equipment_line_items.first >
< li.fields_for "existing_equipment_line_item_attributes", equipment_li, :index => equipment_li.id do |eli| >
<= eli.text_field :equipment_id >
< end >
< end >
< end %>
</code>
</pre>
I perused the code, but am not familiar enough with things to spot anything.
Thanks for the original patch. Made my code less ugly.

I think this has broken how gems and plugins load. The commit before this does not show the problem. Basically, gems which are loaded by plugins and installed in vendor/gems/ no longer works. It worked prior to this commit.

What about using __query and __bang?

Needs a dot at the end.

Should have read # Replace accented chars with their ASCII equivalents.

oh fair point
<pre><code>
parameterized_string.downcase!
parameterized_string
</code></pre>

The comment has since been removed.

Ah, man, I really wish I had a preview button.

downcase! returns nil if the method doesn’t change the string.
<pre>
<code>
>> a = "hello"
=> "hello"
>> a.downcase
=> "hello"
>> a.downcase!
=> nil
</code>
</pre>
Nonetheless, it does create one less object every time.

you know, if you’re really trying to get it down. downcase! returns the value, too:
>> "A".downcase! => "a"

<pre><code>
GC.disable
def count_string_objects_created
start = ObjectSpace.each_object(String) {}
yield
(ObjectSpace.each_object(String) {} – start).to_s
end
puts ’#downcase: ’ + count_string_objects_created {
a = "hello"
a.downcase
}
puts ’#downcase!: ’ + count_string_objects_created {
a = "hello"
a.downcase!
}
</code></pre>