Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
openssl: disable HEARTBEAT TLS extension
Browse files Browse the repository at this point in the history 
Microsoft's IIS doesn't support it, and is not replying with ServerHello
after receiving ClientHello which contains it.

The good way might be allowing to opt-out this at runtime from
javascript-land, but unfortunately OpenSSL doesn't support it right now.

see #5119
  • Loading branch information
@indutny
indutny committed Mar 27, 2013
1 parent f0b6889 commit 28c6e42
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion deps/openssl/openssl.gyp
View file
Expand Up @@ -16,7 +16,13 @@
# No clue what these are for.

This comment has been minimized.

Sign in to view

Copy link
@nitriques

nitriques Apr 11, 2014

I like this line a lot.
'L_ENDIAN',
'PURIFY',
'_REENTRANT'
'_REENTRANT',

# Heartbeat is a TLS extension, that couldn't be turned off or
# asked to be not advertised. Unfortunately this is unacceptable for
# Microsoft's IIS, which seems to be ignoring whole ClientHello after
# seeing this extension.
'OPENSSL_NO_HEARTBEATS',

This comment has been minimized.

Sign in to view

Copy link
@JacksonGariety

JacksonGariety May 15, 2014

"I will always want you..."
],
'sources': [
'openssl/ssl/bio_ssl.c',
Expand Down

44 comments on commit 28c6e42

@mathiasbynens
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional security features, episode 42.

@mikeal
Copy link

@mikeal mikeal commented on 28c6e42 Apr 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha, best accidental security fix ever :)

@danielchatfield
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@forki
Copy link

@forki forki commented on 28c6e42 Apr 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@joemccann
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random acts of brilliance™

@jefperito
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random acts of brilliance™[2]

@bevacqua
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@Ephemera
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jpillora
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt-out ftw

@bluemir
Copy link

@bluemir bluemir commented on 28c6e42 Apr 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!:+1:

@guileen
Copy link

@guileen guileen commented on 28c6e42 Apr 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@williamdeve
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behind had luck comes good luck.

@nickleefly
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ kudos to node

@be5invis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

毒德大学
Sick! Uber! Classic! Masterpiece!

@diogo-karma
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

hackers gonna hack

@suroorwijdan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

@lkuczera
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leecade
Copy link

@leecade leecade commented on 28c6e42 Apr 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@stash
Copy link

@stash stash commented on 28c6e42 Apr 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@stuartpb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I pointed out in the mailing list, this is mostly dumb luck, but not entirely, since the bug that led to this change was a symptom of the same problem that allowed Heartbleed to happen (heartbeats being an obscure code path not receiving sufficient bug auditing).

@mstksg
Copy link

@mstksg mstksg commented on 28c6e42 Apr 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slow clap

@rafaelrinaldi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤

@stevepotayteo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GauthierD-
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 ❤️

@MarcDiethelm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping for some insight in these comments not for a stream of juvenile and useless low-effort comments. I'm happy, you're happy, we're all happy that Node is not affected. Ok, now do something productive.

@Atinux
Copy link

@Atinux Atinux commented on 28c6e42 Apr 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Fishrock123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it somewhat amusing that Microsoft's software not liking something forced us to turn off a feature that otherwise contains probably the largest software security vulnerability to date.

@Overruler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got lucky with 'OPENSSL_NO_HEARTBEATS', now let's hope you got equally lucky with 'L_ENDIAN', 'PURIFY' and '_REENTRANT'.

@trevormcleod
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. Awesome.

@Arcko
Copy link

@Arcko Arcko commented on 28c6e42 Apr 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Nevraeka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol...
a-team-t-shirt-hannibal-a-plan-comes-together
🍻

@cecilemuller
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slow clap indeed xD

@scien
Copy link

@scien scien commented on 28c6e42 Apr 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smarzola
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@julianduque
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 Epic!

@sureshg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@hemanth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dortzur
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node is awesome even unintentionally 👍

@leeight
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@joshuakfarrar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 nice.

@LeslieZhu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@vittee
Copy link

@vittee vittee commented on 28c6e42 Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jimmiehansson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha awesome

@mykiimike
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha perfect !

Please sign in to comment.