@@ -5,8 +5,7 @@ module Net class HTTPSuccess def body - case self['content-encoding'] - when 'gzip' + if self['content-encoding'] == 'gzip' body = StringIO.new(super) uncompressed_body = Zlib::GzipReader.new(body) uncompressed_body.read lib/extensions/http_success.rb @@ -2,22 +2,29 @@ require File.join(File.dirname(__FILE__), "/spec_helper") describe "HTTPSuccess" do describe ".body" do - it "returns a plain text body if no compression is used in the response" do - uri = URI.parse("http://www.example.com") - FakeWeb.register_uri(:any, uri, :body => "#{File.dirname(__FILE__)}/support/fakeweb/www.example.com") - - request = Net::HTTP::Get.new(uri.request_uri) - response = Net::HTTP.new(uri.host).request(request) + def do_request + request = Net::HTTP::Get.new(@uri.request_uri) + response = Net::HTTP.new(@uri.host).request(request) response.body.should match(/These domain names are reserved for use in documentation/) end - it "returns a plain text body if gzip is used in the response" do - uri = URI.parse("http://www.example.com") - FakeWeb.register_uri(:any, uri, :body => "#{File.dirname(__FILE__)}/support/fakeweb/www.example.com.gz", 'content-encoding' => 'gzip') + before do + @uri = URI.parse("http://www.example.com") + end - request = Net::HTTP::Get.new(uri.request_uri) - response = Net::HTTP.new(uri.host).request(request) - response.body.should match(/These domain names are reserved for use in documentation/) + it "returns a plain text body if no compression is used in the response" do + options = { :body => "#{File.dirname(__FILE__)}/support/fakeweb/www.example.com" } + FakeWeb.register_uri(:any, @uri, options) + do_request + end + + it "returns a plain text body if gzip is used in the response" do + options = { + :body => "#{File.dirname(__FILE__)}/support/fakeweb/www.example.com.gz", + 'Content-Encoding' => :gzip + } + FakeWeb.register_uri(:any, @uri, options) + do_request end end end \ No newline at end of file spec/compression_spec.rb 715c7f19fa572289021a661ddc97db765f1adb32 John Pignata john.pignata@gmail.com http://github.com/jpignata/bossman-gem/commit/d9c70531e085dba6ea229e50260564ab0f866731 d9c70531e085dba6ea229e50260564ab0f866731 2009-11-01T13:40:27-08:00 2009-11-01T13:40:27-08:00 DRY'ing compression spec Minor refactoring of HTTPResponse extension 952c101073f29f1bd1c2c0c7ee0d881e2734b14e John Pignata john.pignata@gmail.com