@@ -62,10 +62,14 @@ module Spec def parse_backtrace(backtrace) backtrace.collect do |trace_line| - split_line = trace_line.split(':') - [split_line[0], Integer(split_line[1])] + # match c:/somepath/file.rb:999:in 'method' + # -or- ./somepath.file.rb:999 + trace_line =~ /(.*)\:(\d*)(\:|$)/ + file, number = $1, $2 + [file, Integer(number)] end end + end end end lib/spec/runner/spec_parser.rb @@ -82,4 +82,13 @@ describe "SpecParser" do parser.spec_name_for(file, 63).should == "e f 11" end + it "should handle paths which contain colons" do + fixture = + { "c:/somepath/somefile.rb:999:in 'method'" => "c:/somepath/somefile.rb", + "./somepath/somefile:999" => "./somepath/somefile" } + fixture.each_pair do |input, expected| + parser.send(:parse_backtrace, input ).should == [[expected, 999]] + end + end + end spec/spec/runner/spec_parser_spec.rb a8bbb6de851579f10bed69123e8257b3d762d31a John-Mason P. Shackelford jpshack@gmail.com http://github.com/jpshackelford/rspec/commit/466b8e27e36bb0e6073a460f01341882ee881d8c 466b8e27e36bb0e6073a460f01341882ee881d8c 2008-08-22T12:34:51-07:00 2008-08-22T12:34:51-07:00 SpecParser now handles backtrace paths which contain colons (common on Windows). Lighthouse Ticket #505 dafb045043f7412e4787db21aafad7443ffd09c3 John-Mason P. Shackelford jpshack@gmail.com