Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Non native menus: dialog size select title should match the label when changed after the dialog markup is added to the DOM #5956

Closed
gabrielschulhof opened this issue May 2, 2013 · 3 comments

Comments

@gabrielschulhof
Copy link

This integration test fails on Chrome 26.0.1410.63.

This integration test causes a return to #default with role set to "dialog" when window.history.back() is called to close the dialog displaying the contents of the large custom select menu.

As a result, #default, which is supposed to be a page, gets data-role="dialog" for subsequent tests.

This test fails on the latest Chrome. Not sure if this behaviour is related to the failure or not.

@gabrielschulhof
Copy link
Author

Strangely, the error goes away when I replace window.history.back() with $.mobile.activePage.find( "a:first" ).click() ...

@gabrielschulhof
Copy link
Author

With window.history.back() in place, however, it seems that a popstate right after having gone to the dialog is causing it to come back from the dialog with role=dialog ... very strange ...

@gabrielschulhof
Copy link
Author

OK. I think I have discovered another goes-back-twice-in-history scenario:

page1 -> page2 -> inject dialog-sized custom select -> open select <- back. At this point it goes back twice.

gabrielschulhof pushed a commit that referenced this issue May 5, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant