This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Bug in pagecontaner.js (v1.4.x) #7177
Labels
Milestone
Comments
OK, this is part of funky-initial-URL-handling ... I'll take a look ... |
Hmmm ... it seems that it is never evaluated in any of our tests, except in a unit test specifically designed to hit that method. |
gabrielschulhof
pushed a commit
that referenced
this issue
Aug 16, 2014
In the process of removing
At this point, the location will display /path1/#page2 instead of /path2/#page2. This is bad, because opening an internal page should only change the hash, not the path. The sequence tests should've caught this but I forgot to include an assertion that checks the location :( @arschmitz do you think this is bad enough to warrant a fix? |
gabrielschulhof
pushed a commit
that referenced
this issue
Aug 19, 2014
gabrielschulhof
pushed a commit
that referenced
this issue
Aug 19, 2014
agcolom
pushed a commit
to agcolom/jquery-mobile
that referenced
this issue
Nov 26, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Pagecontaner widget has _handleDestination private method. The last 'if' statement in this method contains comparison:
However this comparison always evaluates to true because left part refers to full URL and the right part refers to just the hash part (with the # stripped out).
The text was updated successfully, but these errors were encountered: