Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Table: Columntoggle toggles column even if checkbox programmatically stays unchecked #7381

Closed
gabrielschulhof opened this issue May 8, 2014 · 0 comments
Assignees
Milestone

Comments

@gabrielschulhof
Copy link

http://jsbin.com/IFolanOW/425/

To reproduce, click repeatedly on 'Uncheck "Year"'.

At this point, you will notice that, instead of the "Year" column disappearing and then staying hidden in response to subsequent clicks, it toggles.

This is due to https://github.com/jquery/jquery-mobile/blob/39fe09ebf3d40321b7d7c389c1b5676b01093971/js/widgets/table.columntoggle.js#L130-L136 where _unlockCells() in effect reveals the column every other time.

That whole section of code needs to go, because the attribute "locked" is not a valid attribute for a checkbox, the attribute is not data-prefixed, and it's not used anywhere else in the columntoggle code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant