Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Dialog: Remove the instance-storing for the overlay, just create one …
…whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist.
- Loading branch information
1 parent
b9068c1
commit 1e8baf5
Showing
2 changed files
with
7 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e8baf5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't a new unit test supporting this behavior be created?
1e8baf5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, there shouldn't be tests needed for this change since it's just removing a workaround for a memory leak that we can't detect in JS. However, there are no tests for the
modal
option, so we should add tests covering the normal functionality, but I don't think there's anything specific to this ticket that needs to be added.1e8baf5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I just randomly threw that out there. Whenever I see a commit with no test, I'm alarmed, but a commit that only removes tests, well that's downright unacceptable :-)
1e8baf5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, the test that was removed was for a bug in the workaround for the memory leak. That bug can't possibly occur if the workaround is removed :-)