Dialog: Pass through icons and showText (as 'text') options to button…

…. Fixes #6830 - Allow Icons to be specified for Dialog buttons.
jquery · Nov 26, 2012 · 9996173 · 9996173
1 parent d8b98ec
commit 9996173
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/tests/unit/dialog/dialog_options.js b/tests/unit/dialog/dialog_options.js
@@ -81,7 +81,7 @@ test("buttons", function() {
 });
 
 test("buttons - advanced", function() {
-	expect(5);
+	expect( 7 );
 
 	var buttons,
 		el = $("<div></div>").dialog({
@@ -92,7 +92,11 @@ test("buttons - advanced", function() {
 					id: "my-button-id",
 					click: function() {
 						equal(this, el[0], "correct context");
-					}
+					},
+					icons: {
+						primary: "ui-icon-cancel"
+					},
+					showText: false
 				}
 			]
 		});
@@ -102,6 +106,8 @@ test("buttons - advanced", function() {
 	equal(buttons.attr("id"), "my-button-id", "correct id");
 	equal(buttons.text(), "a button", "correct label");
 	ok(buttons.hasClass("additional-class"), "additional classes added");
+	deepEqual( buttons.button("option", "icons"), { primary: "ui-icon-cancel", secondary: null } );
+	equal( buttons.button( "option", "text" ), false );
 	buttons.click();
 
 	el.remove();

diff --git a/tests/visual/dialog/complex-dialogs.html b/tests/visual/dialog/complex-dialogs.html
@@ -28,10 +28,21 @@
 				width: 500,
 				buttons: [
 					{
+						click: $.noop,
+						icons: {
+							primary: "ui-icon-check"
+						},
 						text: "Ok"
 					},
 					{
-						text: "Cancel"
+						click: function() {
+							$( this ).dialog( "close" );
+						},
+						icons: {
+							primary: "ui-icon-cancel"
+						},
+						text: "Cancel",
+						showText: false
 					}
 				]
 			}),

diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -383,8 +383,10 @@ $.widget("ui.dialog", {
 					click.apply( that.element[0], arguments );
 				};
 				$( "<button></button>", props )
-					// TODO allow passing through button options
-					.button()
+					.button({
+						icons: props.icons,
+						text: props.showText
+					})
 					.appendTo( that.uiButtonSet );
 			});
 			this.uiDialog.addClass( "ui-dialog-buttons" );