Skip to content

Commit

Permalink
Autocomplete: Don't prevent keypress for multiline. Fixed #8911 - Aut…
Browse files Browse the repository at this point in the history
…ocomplete: Unable to use up/down arrow keys in a textarea (Firefox).

(cherry picked from commit f5f0879)
  • Loading branch information
Jason Moon authored and scottgonzalez committed Apr 25, 2013
1 parent 329974b commit c1f7f52
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 1 deletion.
41 changes: 41 additions & 0 deletions tests/unit/autocomplete/autocomplete_core.js
Expand Up @@ -89,6 +89,30 @@ test( "allow form submit on enter when menu is not active", function() {
test( "down arrow moves focus - contenteditable", function() {
arrowsMoveFocus( "#autocomplete-contenteditable", false );
});

test( "up arrow moves cursor - input", function() {
arrowsNavigateElement( "#autocomplete", true, false );
});

test( "down arrow moves cursor - input", function() {
arrowsNavigateElement( "#autocomplete", false, false );
});

test( "up arrow moves cursor - textarea", function() {
arrowsNavigateElement( "#autocomplete-textarea", true, true );
});

test( "down arrow moves cursor - textarea", function() {
arrowsNavigateElement( "#autocomplete-textarea", false, true );
});

test( "up arrow moves cursor - contenteditable", function() {
arrowsNavigateElement( "#autocomplete-contenteditable", true, true );
});

test( "down arrow moves cursor - contenteditable", function() {
arrowsNavigateElement( "#autocomplete-contenteditable", false, true );
});

function arrowsInvokeSearch( id, isKeyUp, shouldMove ) {
expect( 1 );
Expand Down Expand Up @@ -120,6 +144,23 @@ test( "allow form submit on enter when menu is not active", function() {
element.autocomplete( "search" );
element.simulate( "keydown", { keyCode: ( isKeyUp ? $.ui.keyCode.UP : $.ui.keyCode.DOWN ) } );
}

function arrowsNavigateElement( id, isKeyUp, shouldMove ) {
expect( 1 );

var didMove = false,
element = $( id ).autocomplete({
source: [ "a" ],
delay: 0,
minLength: 0
});
element.on( "keypress", function( e ) {
didMove = !e.isDefaultPrevented();
});
element.simulate( "keydown", { keyCode: ( isKeyUp ? $.ui.keyCode.UP : $.ui.keyCode.DOWN ) } );
element.simulate( "keypress" );
equal( didMove, shouldMove, "respond to arrow" );
}
})();

asyncTest( "handle race condition", function() {
Expand Down
4 changes: 3 additions & 1 deletion ui/jquery.ui.autocomplete.js
Expand Up @@ -142,7 +142,9 @@ $.widget( "ui.autocomplete", {
keypress: function( event ) {
if ( suppressKeyPress ) {
suppressKeyPress = false;
event.preventDefault();
if ( !this.isMultiLine || this.menu.element.is( ":visible" ) ) {
event.preventDefault();
}
return;
}
if ( suppressKeyPressRepeat ) {
Expand Down

0 comments on commit c1f7f52

Please sign in to comment.