Skip to content

Commit

Permalink
Autocomplete: Removed styling for .ui-autocomplete-loading from the t…
Browse files Browse the repository at this point in the history 
…heme - added to individual demos. Fixes #5385 - Autocomplete: Inconsistent default styling while loading results.

We will need to undo this change when ThemeRoller supports generating loading images.
  • Loading branch information
@scottgonzalez
scottgonzalez committed Jul 19, 2010
1 parent 612838a commit fe71d5d
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 1 deletion.
3 changes: 3 additions & 0 deletions demos/autocomplete/multiple-remote.html
View file
Expand Up @@ -10,6 +10,9 @@
<script type="text/javascript" src="../../ui/jquery.ui.position.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.autocomplete.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<style type="text/css">
.ui-autocomplete-loading { background: white url('../../themes/base/images/ui-anim_basic_16x16.gif') right center no-repeat; }
</style>
<script type="text/javascript">
$(function() {
function split(val) {
Expand Down
3 changes: 3 additions & 0 deletions demos/autocomplete/remote-jsonp.html
View file
Expand Up @@ -10,6 +10,9 @@
<script type="text/javascript" src="../../ui/jquery.ui.position.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.autocomplete.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<style type="text/css">
.ui-autocomplete-loading { background: white url('../../themes/base/images/ui-anim_basic_16x16.gif') right center no-repeat; }
</style>
<script type="text/javascript">
$(function() {
function log(message) {
Expand Down
3 changes: 3 additions & 0 deletions demos/autocomplete/remote-with-cache.html
View file
Expand Up @@ -10,6 +10,9 @@
<script type="text/javascript" src="../../ui/jquery.ui.position.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.autocomplete.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<style type="text/css">
.ui-autocomplete-loading { background: white url('../../themes/base/images/ui-anim_basic_16x16.gif') right center no-repeat; }
</style>
<script type="text/javascript">
$(function() {
var cache = {};
Expand Down
3 changes: 3 additions & 0 deletions demos/autocomplete/remote.html
View file
Expand Up @@ -10,6 +10,9 @@
<script type="text/javascript" src="../../ui/jquery.ui.position.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.autocomplete.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<style type="text/css">
.ui-autocomplete-loading { background: white url('../../themes/base/images/ui-anim_basic_16x16.gif') right center no-repeat; }
</style>
<script type="text/javascript">
$(function() {
function log(message) {
Expand Down
3 changes: 3 additions & 0 deletions demos/autocomplete/xml.html
View file
Expand Up @@ -10,6 +10,9 @@
<script type="text/javascript" src="../../ui/jquery.ui.position.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.autocomplete.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<style type="text/css">
.ui-autocomplete-loading { background: white url('../../themes/base/images/ui-anim_basic_16x16.gif') right center no-repeat; }
</style>
<script type="text/javascript">
$(function() {
function log(message) {
Expand Down
1 change: 0 additions & 1 deletion themes/base/jquery.ui.autocomplete.css
View file
Expand Up @@ -8,7 +8,6 @@
* http://docs.jquery.com/UI/Autocomplete#theming
*/
.ui-autocomplete { position: absolute; cursor: default; }
.ui-autocomplete-loading { background: white url('images/ui-anim_basic_16x16.gif') right center no-repeat; }

/* workarounds */
* html .ui-autocomplete { width:1px; } /* without this, the menu expands to 100% in IE6 */
Expand Down

2 comments on commit fe71d5d

@samuelsethhildebrand
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We will need to undo this change when ThemeRoller supports generating loading images." Is it time.. ?

I admit I don't understand the entire problem and solution there but I found that I had to manually update the theme (Blitzer) which I downloaded so that the spinner would appear inside the autocomplete box. Its very confusing to the user when the spinner does not appear.

@scottgonzalez
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the earliest we would consider support for this is 1.9.

Please sign in to comment.