Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: autoFill option implemented #7

Closed
wants to merge 1 commit into from
Closed

Autocomplete: autoFill option implemented #7

wants to merge 1 commit into from

Conversation

iced
Copy link

@iced iced commented Sep 8, 2010

Simple change, will not affect existing code by any means. Nice-to-have feature.

…oses completion if there is exactly one suggestion
@scottgonzalez
Copy link
Member

We don't want this in the core of the plugin.

@iced
Copy link
Author

iced commented Sep 8, 2010

And I don't see any nice way to do this from user side. Also, why? Give me just one reason.

@scottgonzalez
Copy link
Member

Because it's not necessary and adds some complexity. If we implement everything anybody wants, we end up with 30 options that way.

Also, this is very easy to do from the user side. Listen for the open event and check the number of items.

@gamafranco
Copy link

...you should look at how many hacks are listed on StackOverflow since this option was removed...

@scottgonzalez
Copy link
Member

This option wasn't removed; it never existed in the first place.

@gamafranco
Copy link

Sorry. I thought this plugin was an evolution of: http://docs.jquery.com/Plugins/Autocomplete/autocomplete#toptions

But to make it clear that this is not just an nice to have, please check the following links:

http://forum.jquery.com/topic/autocomplete-autofill-disappeared
http://forum.jquery.com/topic/adding-an-autofill-option-and-anchored-filters-to-the-autocomplete-plugin
http://stackoverflow.com/questions/3539760/jquery-ui-autocomplete-with-chrome-like-autofill
http://stackoverflow.com/questions/10384628/jquery-autocomplete-autofill-enabled
http://stackoverflow.com/questions/14062765/jquery-autocomplete-auto-fill-field-with-1st-value-and-highligh-added-part
http://stackoverflow.com/questions/4987802/how-to-implement-jquery-ui-autocomplete-autofill-and-or-selectfirst-features

These were all on the first page of a google search about the autoFill option on the jQueryUI autocomplete plugin.

Would be a + to have this feature incorporated and even enabled by default. I've seen usability issues because the input doesn't auto fill.

Thanks.

@scottgonzalez
Copy link
Member

Sorry. I thought this plugin was an evolution of: http://docs.jquery.com/Plugins/Autocomplete/autocomplete#toptions

No, it's a new plugin from scratch. We used that autocomplete only as a reference to functionality that should be easy to accomplish.

But to make it clear that this is not just an nice to have,

No matter how many links you point to, I assure you this is a nice to have. We would have several tickets filed for this and everyone would be clamoring for this to be added. This is definitely not the case.

These were all on the first page of a google search about the autoFill option on the jQueryUI autocomplete plugin.

And you'll get similar results for many other features as well, should we just triple the size of the API? Please read http://blog.jqueryui.com/2011/03/api-redesigns-the-past-present-and-future/

Would be a + to have this feature incorporated and even enabled by default. I've seen usability issues because the input doesn't auto fill.

Feel free to file an issue and clearly explain how this is bad usability. You'll need some really convincing data.

@gamafranco
Copy link

Ok, I see you're working to simplify the API. Didn't knew that.

Thanks for the quick reply.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants