Skip to content

Commit

Permalink
Adding in .unwrap() support, thanks to Ben Alman! Fixes #5191.
Browse files Browse the repository at this point in the history
  • Loading branch information
jeresig committed Sep 25, 2009
1 parent 70b9aed commit 69e6e53
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/manipulation.js
Expand Up @@ -90,6 +90,14 @@ jQuery.fn.extend({
});
},

unwrap: function() {
return this.parent().each(function(){
if ( !jQuery.nodeName( this, "body" ) ) {
jQuery( this ).replaceWith( this.childNodes );
}
}).end();
},

append: function() {
return this.domManip(arguments, true, function(elem){
if ( this.nodeType === 1 ) {
Expand Down
31 changes: 31 additions & 0 deletions test/unit/manipulation.js
Expand Up @@ -116,6 +116,37 @@ test("wrapInner(String|Element)", function() {
// testWrapInner(functionReturningObj)
// })

var testUnwrap = function() {
expect(9);

jQuery("body").append(' <div id="unwrap" style="display: none;"> <div id="unwrap1"> <span class="unwrap">a</span> <span class="unwrap">b</span> </div> <div id="unwrap2"> <span class="unwrap">c</span> <span class="unwrap">d</span> </div> <div id="unwrap3"> <b><span class="unwrap unwrap3">e</span></b> <b><span class="unwrap unwrap3">f</span></b> </div> </div>');

var abcd = jQuery('#unwrap1 > span, #unwrap2 > span').get(),
abcdef = jQuery('#unwrap span').get();

equals( jQuery('#unwrap1 span, #unwrap2 span:first').unwrap().length, 3, 'make #unwrap1 and #unwrap2 go away' );
same( jQuery('#unwrap > span').get(), abcd, 'all four spans should still exist' );

same( jQuery('#unwrap3 span').unwrap().get(), jQuery('#unwrap3 > span').get(), 'make all b in #unwrap3 go away' );

same( jQuery('#unwrap3 span').unwrap().get(), jQuery('#unwrap > span.unwrap3').get(), 'make #unwrap3 go away' );

same( jQuery('#unwrap').children().get(), abcdef, '#unwrap only contains 6 child spans' );

same( jQuery('#unwrap > span').unwrap().get(), jQuery('body > span.unwrap').get(), 'make the 6 spans become children of body' );

same( jQuery('body > span.unwrap').unwrap().get(), jQuery('body > span.unwrap').get(), 'can\'t unwrap children of body' );
same( jQuery('body > span.unwrap').unwrap().get(), abcdef, 'can\'t unwrap children of body' );

same( jQuery('body > span.unwrap').get(), abcdef, 'body contains 6 .unwrap child spans' );

jQuery('body > span.unwrap').remove();
}

test("unwrap()", function() {
testUnwrap();
});

var testAppend = function(valueObj) {
expect(21);
var defaultText = 'Try them out:'
Expand Down

0 comments on commit 69e6e53

Please sign in to comment.