@@ -196,30 +196,33 @@ commentCount = data.comments.count; if (countWatcher) countWatcher.unwatch(); countWatcher = BindingUtils.bindSetter(function(new_count:int):void { - // If we have more than max, then display link - allCommentsContainer.visible = (new_count > MaxComments); + callLater(updatedCommentCount, [new_count]); + }, data, ["comments", "count"]); + } - // If we didn't really change our number, then screw it - // If we're doing shit RIGHT NOW, then nevermind, also - if (commentCount == new_count || fetchingComments) return; - commentCount = new_count; + private function updatedCommentCount(new_count:int):void { + // If we have more than max, then display link + allCommentsContainer.visible = (new_count > MaxComments); - // If count is 0, then screw it - if (new_count <= 0) return; + // If we didn't really change our number, then screw it + // If we're doing shit RIGHT NOW, then nevermind, also + if (commentCount == new_count || fetchingComments) return; + commentCount = new_count; - // If <= 3, then we already own it - if (new_count <= 3) populateComments(data.comments.comment_list); - else { - // Perhaps they were already fetched on another filter tab - if (CommentCache.hasFreshComments(data.post_id, new_count)) - commentsFetched(new FBEvent(CommentCache.COMMENTS_FETCHED, - CommentCache.commentCache[data.post_id])); - // Fetch more! - else - fetchComments(); - } + // If count is 0, then screw it + if (new_count <= 0) return; - }, data, ["comments", "count"]); + // If <= 3, then we already own it + if (new_count <= 3) populateComments(data.comments.comment_list); + else { + // Perhaps they were already fetched on another filter tab + if (CommentCache.hasFreshComments(data.post_id, new_count)) + commentsFetched(new FBEvent(CommentCache.COMMENTS_FETCHED, + CommentCache.commentCache[data.post_id])); + // Fetch more! + else + fetchComments(); + } } // Called when a comment has been deleted by the user inside ourselves fbair/nile/renderers/CommentsRenderer.mxml @@ -60,7 +60,7 @@ .commentRenderer { horizontalGap: 5; - paddingBottom: 6; + paddingBottom: 4; } .commentText { @@ -220,11 +220,6 @@ CommentBox { horizontalGap: 5; } -CommentRenderer { - borderSkin: ClassReference('fbair.gui.skins.FBAIRSkin'); - bottomBorderColor: #ffffff; -} - LikesRenderer { borderSkin: ClassReference('fbair.gui.skins.FBAIRSkin'); bottomBorderColor: #ffffff; fbair/styles/renderers.css b68cbeab7959d0bceedbfc5a2ffc1b816661ee0b Lee Byron leebyron@mobile003.mycingular.net http://github.com/jubishop/Facebook-for-Adobe-AIR/commit/626b5bc09aae85b290fe37e5a705c45df6e6c0d1 626b5bc09aae85b290fe37e5a705c45df6e6c0d1 2009-05-28T20:45:30-07:00 2009-05-28T20:45:30-07:00 count was often updated before comments, leading to rendering N-1 comments a52e19e16386d18c0b4d919217f7c2f154a79945 Lee Byron leebyron@mobile003.mycingular.net