14fd100532374db342a274f52a8f875e24213804 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/c352f2df2a515f00951f9ecc2ec2a88a1c611072 c352f2df2a515f00951f9ecc2ec2a88a1c611072 2008-09-25T16:13:08-07:00 2008-09-25T16:10:56-07:00 Added the new likeback dialog from Valerio Pilo. Valerio (valerio@kmess.org) sent me these changes. The dialog is now a lot simpler and more compact. 9193ecbfcbab7bc894b5b044ffbc716ea308f73f Kelvie Wong kelvie@ieee.org a440f24fd752c9da39327024e7cc071b86e1cd4e Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/14fd100532374db342a274f52a8f875e24213804 14fd100532374db342a274f52a8f875e24213804 2008-09-24T02:24:20-07:00 2008-09-24T02:24:20-07:00 LikeBack: fix the label so that it wordwraps. This makes it so that the dialog doesn't stretch so wide. 3dd232f3ebfe95b1c5ac4e3fe6ec122359f0f32f Kelvie Wong kelvie@ieee.org f8dff4f6a9b0c3d1b73bc39b3fc448f0e27f8476 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/a440f24fd752c9da39327024e7cc071b86e1cd4e a440f24fd752c9da39327024e7cc071b86e1cd4e 2008-09-24T01:18:41-07:00 2008-09-23T22:56:29-07:00 Fix exporting and importing of Basket Archives. Resolves issue 0000039. This resolves several issues with exporting and importing basket archives. Bug 0000039 was caused by code in archive.cpp that mixed stream operations with the file.write() function. Because QTextStream buffers data, this was causing the file header (with version information, etc) to not be written to the file in the appropriate place. By flushing the stream before using file.write() in two places, I was able to resolve this bug. Unfortunately, another problem -- an infinite loop in FormatImporter -- made importing impractical. What happens is that if the importer tries to read an icon that wasn't saved in the archive, it loops forever waiting for that file to "finish copying". Of course, this is impossible and the program freezes. I am not sure under what circumstances that corner case can appear, but checking for the existence of the file before trying to copy it seems to make importing work. I was able to export and import baskets. 586e643649bd8df57f23c286d9be9ceca653ff03 Kelvie Wong kelvie@ieee.org 551572091a625f40ee87a939affb02918e1a3d4d Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/f8dff4f6a9b0c3d1b73bc39b3fc448f0e27f8476 f8dff4f6a9b0c3d1b73bc39b3fc448f0e27f8476 2008-09-24T01:18:40-07:00 2008-09-23T20:54:42-07:00 Fixed more warnings. More warnings about && and || as well as some comparisons between signed and unsigned integers. 5556477c2ba163b5d7e38e98677e732d2a246878 Kelvie Wong kelvie@ieee.org ec018a810009ec70df39ee9973297d8c2ae68d76 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/551572091a625f40ee87a939affb02918e1a3d4d 551572091a625f40ee87a939affb02918e1a3d4d 2008-09-24T01:18:40-07:00 2008-09-23T19:27:52-07:00 Cleaned up warnings in note.cpp Fixed some warnings about ambiguous if/else clauses and use && within || conditions. Some of the changes to the latter kind of error might actually fix some glitches in the logic of the program. There were two cases where the default order of operations didn't make sense and adding parentheses will definitely change the program logic. So I -might- have fixed a bug. d7708ff50192aa08150ac7cce802386a3f076e91 Kelvie Wong kelvie@ieee.org c27902e189fc8468499e6e2de9c95380186b88c1 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/ec018a810009ec70df39ee9973297d8c2ae68d76 ec018a810009ec70df39ee9973297d8c2ae68d76 2008-09-24T01:18:40-07:00 2008-08-28T16:42:15-07:00 Fix a warning about logical AND in if-statement condition. dd04f6c3eb20b559e4d123a6087499fdb73312d5 Kelvie Wong kelvie@ieee.org 77428c6b9f35af3faca2d41fd410f6a5a074757b Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/c27902e189fc8468499e6e2de9c95380186b88c1 c27902e189fc8468499e6e2de9c95380186b88c1 2008-09-24T01:18:40-07:00 2008-08-23T23:09:27-07:00 Fixed another setRange call in KIntNumInput. Again, separated out the setSliderEnabled call. One more warning bites the dust. b971679569d92c0c67b73e473c62796fcda3816a Kelvie Wong kelvie@ieee.org 580702061f42782064f6e954468f55487b0c63b9 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/77428c6b9f35af3faca2d41fd410f6a5a074757b 77428c6b9f35af3faca2d41fd410f6a5a074757b 2008-09-24T01:18:40-07:00 2008-08-23T23:02:17-07:00 Fix bug uncovered by previous commit. Fixing the curly braces causes showMainWindow to be called. But this is bad for two reasons: 1. showMainWindow tries to call toggleActive on the system tray icon, which hasn't been created yet. 2. Even if you move the "new" for the system tray up to fix this problem, calling showMainWindow toggles the system tray state so that the window "flickers" and minimizes to the tray. I think simply deleting the "showMainWindow" call fixes this without any negative side-effects. I'm not 100% sure, though. 32b27a7494ac37b93e92530872afb78abb793420 Kelvie Wong kelvie@ieee.org ed1a7e1434c712acc36790d70a93141806e7e6c3 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/580702061f42782064f6e954468f55487b0c63b9 580702061f42782064f6e954468f55487b0c63b9 2008-09-24T01:18:40-07:00 2008-08-23T22:27:44-07:00 Fixed more curly brace problems. To eliminate a warning. fea4eacc036fdf8b21078db1dbafe5ce8f9b86b9 Kelvie Wong kelvie@ieee.org 63cfe0efcea839cecc5c8c44c54df99545a770b1 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/ed1a7e1434c712acc36790d70a93141806e7e6c3 ed1a7e1434c712acc36790d70a93141806e7e6c3 2008-09-24T01:18:40-07:00 2008-08-23T22:19:09-07:00 Removed deprecated setRange call. setRange no longer takes a boolean flag indicating whether the slider should be enabled or not. Instead, the appropriate technique is to use the setSliderEnabled function for the slider. 0341d6deda4dda61e1895ca314cfbd2cf93ac365 Kelvie Wong kelvie@ieee.org ffc642d75e21919e6e6adc6a59b77ef3193c7c26 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/63cfe0efcea839cecc5c8c44c54df99545a770b1 63cfe0efcea839cecc5c8c44c54df99545a770b1 2008-09-24T01:18:40-07:00 2008-08-23T22:06:49-07:00 Fixed warnings due to misplaced curly braces. The changes to bnpview may also fix a latent bug in session handling regarding hiding of the main window when pulling using the system tray and not using the "start-hidden" feature. 2df6375a793ab50f94ee10d885893bb751b27af6 Kelvie Wong kelvie@ieee.org baab66876799acac6073080964997b14b414629e Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/ffc642d75e21919e6e6adc6a59b77ef3193c7c26 ffc642d75e21919e6e6adc6a59b77ef3193c7c26 2008-09-24T01:18:40-07:00 2008-08-16T18:41:01-07:00 Changed Q3HGroupBox in linklabel.cpp to QGroupBox. 12f8df512919fdf78cf417f00a967705bd2ce6ce Kelvie Wong kelvie@ieee.org d54d27fd633aaf022200444bfac454d88055a46c Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/baab66876799acac6073080964997b14b414629e baab66876799acac6073080964997b14b414629e 2008-09-24T01:18:40-07:00 2008-08-16T18:37:51-07:00 Changed Q3GroupBox to QGroupBox in basketproperties.cpp 5917e557729d49a6aa30baeee20f752e7a1973e7 Kelvie Wong kelvie@ieee.org 8eb972acfd1bde818a047c84001fe9867e4b3445 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/d54d27fd633aaf022200444bfac454d88055a46c d54d27fd633aaf022200444bfac454d88055a46c 2008-09-24T01:18:40-07:00 2008-08-16T18:29:22-07:00 Removed Q3GroupBox from backup.cpp d2958cd8625ddee65f1bab4651fbf369c235879c Kelvie Wong kelvie@ieee.org 483790141d2bd5a8313632f1d789993c8bcc0642 d0fe29721cb4c7c03d6ab11054c0086c4725727e Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/8eb972acfd1bde818a047c84001fe9867e4b3445 8eb972acfd1bde818a047c84001fe9867e4b3445 2008-09-16T13:41:50-07:00 2008-09-16T13:41:50-07:00 Merge commit 'github/filter-rework' * commit 'github/filter-rework': User-visible changes for the new filter bar change. Restore the auto-hide functionality in the FilterBar. Have FilterBar::hasEditFocus check the tag box as well. Filter: Remove signals/slots related to the Escape/Return key handling Removed the odd hack inside BNPView::toggleFilterAllBaskets b0d9953e98549f134f12f7f2885e5e2509665221 Kelvie Wong kelvie@ieee.org 88049be79735b880912131b7374f5348eee9d67c d2db2d6df6e5d9c8c0ab8d19a659717e6c8cf75c Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/483790141d2bd5a8313632f1d789993c8bcc0642 483790141d2bd5a8313632f1d789993c8bcc0642 2008-09-02T17:07:49-07:00 2008-09-02T17:07:49-07:00 Merge branch 'master' of git://github.com/Voker57/basket a6f9f05c6a95737977a9d9e13d69dc4893c1d4fb Kelvie Wong kelvie@ieee.org 11aeb5e483d1142c9968bbfb81e69fe1c2b4b7e1 Voker57 voker57@gmail.com http://github.com/kelvie/basket/commit/d2db2d6df6e5d9c8c0ab8d19a659717e6c8cf75c d2db2d6df6e5d9c8c0ab8d19a659717e6c8cf75c 2008-09-01T12:06:33-07:00 2008-09-01T12:06:33-07:00 Small compilation fix ad2462df1129b378b70c95efac64be6596c13461 Voker57 voker57@gmail.com 4ef3cf4b625d6e58229f01034204ba90d57aed1a Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/88049be79735b880912131b7374f5348eee9d67c 88049be79735b880912131b7374f5348eee9d67c 2008-08-31T18:53:21-07:00 2008-08-31T18:53:05-07:00 Fix capitalization. 5de8c809c5bdaead8569eacf83c2f3264c58de90 Kelvie Wong kelvie@ieee.org 8be795bb791dccd7998c85f305587f2c69fe61de Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/d0fe29721cb4c7c03d6ab11054c0086c4725727e d0fe29721cb4c7c03d6ab11054c0086c4725727e 2008-08-31T18:52:39-07:00 2008-08-31T18:52:39-07:00 User-visible changes for the new filter bar change. * The "Filter" and "Search All" (previously "Filter all baskets") buttons are now added to the toolbar as it is now less obvious that filtering and searching are possible (the filter bar was _always_ visible before). * The reset button now no longer needs to be disabled; it got transformed into a "close" button, that is commonplace in search toolbars. * The line edit now has its ClearButton shown, in place of the reset button. * The filter bar now defaults to be shown on the bottom, as with the search toolbar in most web browsers and other programs 6c601cafbdaaa91816772d7a675b99f41f849faf Kelvie Wong kelvie@ieee.org 4661684d3137e9e14b97504595c32a8ab07722aa Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/8be795bb791dccd7998c85f305587f2c69fe61de 8be795bb791dccd7998c85f305587f2c69fe61de 2008-08-31T18:41:55-07:00 2008-08-31T18:41:55-07:00 Restore the auto-hide functionality in the FilterBar. Now the FilterBar behaves a lot better -- I think this is what Sébastien had in mind for the filter bar originally (it is apparent in some of the code that is commented out and the comments themselves). It now checks the editor focus before hiding; FilterBar:;reset() now closes the filter bar. With this new change, the "Filter all Baskets" action now automatically shows the filter bar initially. 36ba55e8759fc17f3bdf255c8486bdc8f6af5f12 Kelvie Wong kelvie@ieee.org 0b551b9719b5b30bdc90e01c8df2c4aec8a17017 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/4661684d3137e9e14b97504595c32a8ab07722aa 4661684d3137e9e14b97504595c32a8ab07722aa 2008-08-31T18:34:39-07:00 2008-08-31T18:34:39-07:00 Have FilterBar::hasEditFocus check the tag box as well. This makes sure the focus does not leave the filter bar when it is open and the user is selecting a tag to filter by. 2cd76ffaea47f71b9ea25787dfaf3545ad73c88c Kelvie Wong kelvie@ieee.org d6ee87d455b64793aac4903bb6973b6670d01bbc Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/0b551b9719b5b30bdc90e01c8df2c4aec8a17017 0b551b9719b5b30bdc90e01c8df2c4aec8a17017 2008-08-31T18:27:33-07:00 2008-08-31T18:27:33-07:00 Filter: Remove signals/slots related to the Escape/Return key handling This avoids two code paths; it is a much better idea to be more diligent about emitting FilterData with the necessary information to classes that need so rather than to propagate signals and slots; this makes for neater code overall and makes it easier to follow. The casualties are: FilterBar::escapePressed FilterBar::returnPressed Basket::cancelFilter Basket::validateFilter f593cc2bfddb1d28267ea1267b9e1065098fa45a Kelvie Wong kelvie@ieee.org af626e9ccbcc9146e28ff9c0b1f7bba9a691a820 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/4ef3cf4b625d6e58229f01034204ba90d57aed1a 4ef3cf4b625d6e58229f01034204ba90d57aed1a 2008-08-31T18:13:48-07:00 2008-08-31T18:13:26-07:00 Remove deprecated QWidget::setShown call. d6286118567c81b4013ba76d11db47b02a3f49cd Kelvie Wong kelvie@ieee.org af626e9ccbcc9146e28ff9c0b1f7bba9a691a820 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/d6ee87d455b64793aac4903bb6973b6670d01bbc d6ee87d455b64793aac4903bb6973b6670d01bbc 2008-08-31T17:46:26-07:00 2008-08-31T17:46:26-07:00 Removed the odd hack inside BNPView::toggleFilterAllBaskets It does not seem like it is necessary. 9d006c0c9c49ff227fdef476955ad3b04379851c Kelvie Wong kelvie@ieee.org f5004e29c0afe38d4b4edf55c6f8f294a235ea08 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/af626e9ccbcc9146e28ff9c0b1f7bba9a691a820 af626e9ccbcc9146e28ff9c0b1f7bba9a691a820 2008-08-31T17:31:35-07:00 2008-08-31T17:30:50-07:00 Fix the About data. This was not merged correctly (by me) earlier. 2c6e557715a7d520e82b215540d3b4c5527068e7 Kelvie Wong kelvie@ieee.org 26b2f4c2bf4b122045abfa452fb7cf4248cedd16 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/f5004e29c0afe38d4b4edf55c6f8f294a235ea08 f5004e29c0afe38d4b4edf55c6f8f294a235ea08 2008-08-30T17:07:15-07:00 2008-08-30T17:06:49-07:00 Fix another icon name in Filter. This actually changes the icon; while it should be the RTL locationbar erase icon, this uses the dialog-close button instead -- this more closely matches the filter(or rather, search) bar found in other places, such as Konsole. c5d6276cb70bd02a7da6664a4f411ab8d6e7657a Kelvie Wong kelvie@ieee.org ed87ae63f92b619f4056975cc17722dc3db69134 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/26b2f4c2bf4b122045abfa452fb7cf4248cedd16 26b2f4c2bf4b122045abfa452fb7cf4248cedd16 2008-08-30T17:03:57-07:00 2008-08-30T17:03:57-07:00 Fix the CMakeLists file to use the KDE4 phonon library FindQt4 on my system fails to resolve the QT_PHONON_LIBRARY variable, and it will fail with a cmake error. 05c275fe0d9bf1cfbede120444a507011738a6d8 Kelvie Wong kelvie@ieee.org 11aeb5e483d1142c9968bbfb81e69fe1c2b4b7e1 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/ed87ae63f92b619f4056975cc17722dc3db69134 ed87ae63f92b619f4056975cc17722dc3db69134 2008-08-30T17:03:07-07:00 2008-08-30T17:03:07-07:00 Fix deprecated header in FilterBar b5c78f2965ce6c20e22a5aee9d746eba6735c3f4 Kelvie Wong kelvie@ieee.org 01887b6c8f887b1284fdc5376690c0a933c04e0c 642d5043a96e927beef37ceeba64aacb31ae4981 Kelvie Wong kelvie@ieee.org http://github.com/kelvie/basket/commit/11aeb5e483d1142c9968bbfb81e69fe1c2b4b7e1 11aeb5e483d1142c9968bbfb81e69fe1c2b4b7e1 2008-08-17T19:26:21-07:00 2008-08-17T19:26:21-07:00 Merge Patrice's phonon changes * commit 'peri/for-kelvie': manage sound with phonon Conflicts: src/CMakeLists.txt 7713e5bd020848fe904dd7fe10536cff0f1ff178 Kelvie Wong kelvie@ieee.org ada9f6c2a81ac2bd9c36494116c2357c3948dc84 Dr. Robert Marmorstein robert@narnia.homeunix.com http://github.com/kelvie/basket/commit/01887b6c8f887b1284fdc5376690c0a933c04e0c 01887b6c8f887b1284fdc5376690c0a933c04e0c 2008-08-17T19:25:03-07:00 2008-08-13T08:26:03-07:00 Changed QV3Button group to use QGroupBox. This fixed a bug with slots/signals. Unfortunately, it seems only global shortcuts work. I can't seem to get local shortcuts to work at all. Not sure why. Fixed connection between the shortcut signal and the basket's slot. Local shortcuts still don't seem to work, though. 5caf884d7902c3355e00daf80bee70253e630c5b Kelvie Wong kelvie@ieee.org