refinement: only allow site admins to sort by login name

kete · Jan 12, 2009 · 860d90b · 860d90b
1 parent e07cc9d
commit 860d90b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/controllers/members_controller.rb b/app/controllers/members_controller.rb
@@ -40,7 +40,9 @@ def list
     end
 
     @default_sorting = {:order => 'roles_users.created_at', :direction => 'desc'}
-    paginate_order = current_sorting_options(@default_sorting[:order], @default_sorting[:direction], ['users.resolved_name', 'users.login', 'roles_users.created_at', 'users.email'])
+    acceptable_sort_types = ['users.resolved_name', 'roles_users.created_at', 'users.email']
+    acceptable_sort_types << ['users.login'] if @site_admin
+    paginate_order = current_sorting_options(@default_sorting[:order], @default_sorting[:direction], acceptable_sort_types)
 
     # this sets up all instance variables
     # as well as preparing @members