From 860d90b288025bec66e73feef87dab02f884e9a3 Mon Sep 17 00:00:00 2001 From: Kieran Pilkington Date: Mon, 12 Jan 2009 17:34:13 +1300 Subject: [PATCH] refinement: only allow site admins to sort by login name --- app/controllers/members_controller.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/members_controller.rb b/app/controllers/members_controller.rb index 432102223..b2d6f2351 100644 --- a/app/controllers/members_controller.rb +++ b/app/controllers/members_controller.rb @@ -40,7 +40,9 @@ def list end @default_sorting = {:order => 'roles_users.created_at', :direction => 'desc'} - paginate_order = current_sorting_options(@default_sorting[:order], @default_sorting[:direction], ['users.resolved_name', 'users.login', 'roles_users.created_at', 'users.email']) + acceptable_sort_types = ['users.resolved_name', 'roles_users.created_at', 'users.email'] + acceptable_sort_types << ['users.login'] if @site_admin + paginate_order = current_sorting_options(@default_sorting[:order], @default_sorting[:direction], acceptable_sort_types) # this sets up all instance variables # as well as preparing @members