@@ -1,7 +1,9 @@ module Dust class ArgumentDuster < LocalVariableCounter def dust! + @silence_warnings = false super + return if @silence_warnings @lvars.each do |name, details| next if details[:calls] > 0 @@ -10,5 +12,10 @@ module Dust warn Warnings::UnusedArgument.new(name) end end + + def process_zsuper(exp) + @silence_warnings = true + s(:zsuper) + end end end lib/dust/argument_duster.rb @@ -23,6 +23,18 @@ describe Dust::ArgumentDuster do duster.warnings.should == [] end + it "should not create warnings when calling super with no explicit arguments" do + duster = Dust::ArgumentDuster.new(LocalVariableBadness, :super_with_implicit_args) + duster.dust! + duster.warnings.should == [] + end + + it "should create warnings when calling super with explicit arguments but without referencing the passed arguments" do + duster = Dust::ArgumentDuster.new(LocalVariableBadness, :super_with_explicit_args) + duster.dust! + duster.warnings.should == [Dust::Warnings::UnusedArgument.new(:arg)] + end + it "should not create warnings for args used with splats" do duster = Dust::ArgumentDuster.new(LocalVariableBadness, :args_used_with_splats) duster.dust! spec/argument_duster_spec.rb @@ -17,4 +17,4 @@ describe Dust::Duster do @duster.scan_for warnings, :with => branches end -end \ No newline at end of file +end spec/duster_spec.rb @@ -93,6 +93,14 @@ module Fixtures respond(&block) end + def super_with_implicit_args(arg) + super + end + + def super_with_explicit_args(arg) + super() + end + def rescue_to_variable begin rescue => e spec/fixtures/local_variable_badness.rb ef77b8a9a358e1f1f2fde57ca86172f101e55d90 Brian Donovan brian.donovan@gmail.com http://github.com/kevinclark/dust/commit/069b939deb8761899ae6e68f0a95b8ff535a72ce 069b939deb8761899ae6e68f0a95b8ff535a72ce 2009-03-16T12:09:20-07:00 2009-03-16T12:04:22-07:00 Don't warn about unused arguments if they're passed implicitly via super. Signed-off-by: Kevin Clark <kevin.clark@gmail.com> d8ec1d6ff470890c54e69fbabaeee155fc622ff4 Kevin Clark kevin.clark@gmail.com