lib/nitpick/supression.rb spec/fixtures/suppressions.yaml spec/suppression_file_spec.rb @@ -1,3 +1,6 @@ +== HEAD / DATE + * Suppression file support [NEW] + == 1.0.1 / 3-19-09 * Typo in runner [FIXED] Changelog @@ -13,24 +13,28 @@ opts = Trollop.options do banner <<-BANNER Nitpick is a lint-like static code analyzer for Ruby. -Usage: `nitpick [(--only str | --except str)*|-h] file1.rb file2.rb` +Usage: `nitpick [(--only str | --except str | --supp file)*|-h] file1.rb file2.rb` By default, nitpick will analyze *all* loaded code. To reduce the noise: BANNER - opt :only, "Nitpick only classes/modules that match this string.", :type => :string, :multi => true - opt :except, "Don't nitpick classes/modules that match this string.", :type => :string, :multi => true + opt :only, "Nitpick only classes/modules that match this string.", :type => :string, :multi => true + opt :except, "Don't nitpick classes/modules that match this string.", :type => :string, :multi => true + opt :supp, "Suppress warnings based on a suppression file", :type => :io, :multi => true end # TODO(kevinclark) 2009-03-19: Figure out how to make this print -h Trollop.die "I need something to nitpick. Gimmie a filename or two. Or ten" if ARGV.size == 0 -NitpickOptions = { :only => opts[:only] || [], :except => opts[:except] || []} +NitpickOptions = { :only => opts[:only] || [], :except => opts[:except] || [], :supp => opts[:supp] || [] } + Nitpickers = [ Nitpick::ArgumentNitpicker, Nitpick::BlockNitpicker, Nitpick::BranchNitpicker, Nitpick::LocalVariableNitpicker, Nitpick::MethodNitpicker, Nitpick::RescueNitpicker ] +SuppressionRules = NitpickOptions[:supp].map {|supp| Nitpick::Suppression.new(supp.read) } + class Module # So we don't set off -w alias_method :original_method_added, :method_added @@ -43,6 +47,8 @@ class Module # Only means it must match one return unless NitpickOptions[:only].find {|namespace| /#{namespace}/ =~ self.to_s } or NitpickOptions[:only].empty? + # skip if any of our rules say so + return if SuppressionRules.any? {|rule| rule.suppress?(self.to_s) } warnings = Nitpickers.map do |nitpicker_class| nitpicker = nitpicker_class.new(self, name) bin/nitpick @@ -4,6 +4,8 @@ require 'rubygems' require 'parse_tree' require 'ruby2ruby' +require 'nitpick/supression' + require 'nitpick/warnings/simple_warning' require 'nitpick/warnings/unused_variable' require 'nitpick/warnings/unprotected_block' lib/nitpick.rb db88f801b4e0d76766d10e4f93e386e7589d37c3 Kevin Clark kevin.clark@gmail.com http://github.com/kevinclark/nitpick/commit/71710620da084a227c71143ed92d5fcb442866c3 71710620da084a227c71143ed92d5fcb442866c3 2009-03-20T01:07:11-07:00 2009-03-20T00:32:11-07:00 Add basic suppression support based on matching constants 963f0408341a4fc0e2c53cf633307ee6ab9273c6 Kevin Clark kevin.clark@gmail.com