From 9f9f7668bdc16f4217cf14c76ad7afb6f693b31a Mon Sep 17 00:00:00 2001 From: Jan Schatteman Date: Fri, 13 Mar 2015 14:07:43 +0100 Subject: [PATCH] BZ-1195300: Added tooltips for a number of icon buttons. --- .../list/DeploymentUnitsListViewImpl.java | 1 + .../document/list/DocumentListViewImpl.java | 1 + .../jbpm/console/ng/gc/client/i18n/Constants.java | 6 ++++++ .../ng/gc/client/list/base/AbstractListView.java | 2 ++ .../console/ng/gc/client/util/CalendarPicker.java | 15 +++++++++------ .../ng/gc/client/util/LiCalendarPicker.java | 15 +++++++++------ .../ng/gc/client/i18n/Constants.properties | 5 ++++- .../editors/quicknewtask/QuickNewTaskPopup.java | 2 ++ .../TaskDetailsMultiViewImpl.java | 2 ++ .../taskslist/grid/TasksListGridViewImpl.java | 3 ++- .../jbpm/console/ng/ht/client/i18n/Constants.java | 2 +- .../ng/ht/client/i18n/Constants.properties | 1 + .../multi/ProcessDefDetailsMultiViewImpl.java | 2 ++ .../ProcessInstanceDetailsMultiViewImpl.java | 2 ++ .../jbpm/console/ng/pr/client/i18n/Constants.java | 2 ++ .../ng/pr/client/i18n/Constants.properties | 3 ++- 16 files changed, 48 insertions(+), 16 deletions(-) diff --git a/jbpm-console-ng-business-domain/jbpm-console-ng-business-domain-client/src/main/java/org/jbpm/console/ng/bd/client/editors/deployment/list/DeploymentUnitsListViewImpl.java b/jbpm-console-ng-business-domain/jbpm-console-ng-business-domain-client/src/main/java/org/jbpm/console/ng/bd/client/editors/deployment/list/DeploymentUnitsListViewImpl.java index acb0f31d2f..4631511d3e 100644 --- a/jbpm-console-ng-business-domain/jbpm-console-ng-business-domain-client/src/main/java/org/jbpm/console/ng/bd/client/editors/deployment/list/DeploymentUnitsListViewImpl.java +++ b/jbpm-console-ng-business-domain/jbpm-console-ng-business-domain-client/src/main/java/org/jbpm/console/ng/bd/client/editors/deployment/list/DeploymentUnitsListViewImpl.java @@ -137,6 +137,7 @@ public DefaultSelectionEventManager.SelectAction translateSelectionEvent(CellPre Button newUnitButton = new Button(); newUnitButton.setIcon(IconType.PLUS); + newUnitButton.setTitle( Constants.INSTANCE.Deploy_A_New_Unit() ); newUnitButton.addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { diff --git a/jbpm-console-ng-documents/jbpm-console-ng-documents-client/src/main/java/org/jbpm/console/ng/dm/client/document/list/DocumentListViewImpl.java b/jbpm-console-ng-documents/jbpm-console-ng-documents-client/src/main/java/org/jbpm/console/ng/dm/client/document/list/DocumentListViewImpl.java index 4377a091c3..37d34d9660 100644 --- a/jbpm-console-ng-documents/jbpm-console-ng-documents-client/src/main/java/org/jbpm/console/ng/dm/client/document/list/DocumentListViewImpl.java +++ b/jbpm-console-ng-documents/jbpm-console-ng-documents-client/src/main/java/org/jbpm/console/ng/dm/client/document/list/DocumentListViewImpl.java @@ -178,6 +178,7 @@ public DefaultSelectionEventManager.SelectAction translateSelectionEvent( Button configRepoButton = new Button(); configRepoButton.setIcon(IconType.COG); + configRepoButton.setTitle( Constants.INSTANCE.ConfigurationPanel() ); configRepoButton.addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { diff --git a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/i18n/Constants.java b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/i18n/Constants.java index ecf20a8379..c4fcf9b30c 100644 --- a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/i18n/Constants.java +++ b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/i18n/Constants.java @@ -41,6 +41,8 @@ public interface Constants extends Messages { String New_Item(); + String Select_Date(); + String Day(); String Week(); @@ -48,4 +50,8 @@ public interface Constants extends Messages { String Month(); String Today(); + + String Previous(); + + String Next(); } \ No newline at end of file diff --git a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/list/base/AbstractListView.java b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/list/base/AbstractListView.java index 89b2279351..59dc7f4cad 100644 --- a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/list/base/AbstractListView.java +++ b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/list/base/AbstractListView.java @@ -34,6 +34,7 @@ import org.jboss.errai.security.shared.api.identity.User; import org.jbpm.console.ng.ga.model.GenericSummary; import org.jbpm.console.ng.gc.client.experimental.grid.base.ExtendedPagedTable; +import org.jbpm.console.ng.gc.client.i18n.Constants; import org.uberfire.ext.widgets.common.client.common.BusyPopup; import org.uberfire.ext.services.shared.preferences.GridGlobalPreferences; import org.uberfire.ext.services.shared.preferences.GridPreferencesStore; @@ -144,6 +145,7 @@ public void displayNotification( String text ) { public void initGenericToolBar() { Button refreshButton = new Button(); refreshButton.setIcon( IconType.REFRESH ); + refreshButton.setTitle( Constants.INSTANCE.Refresh() ); refreshButton.addClickHandler( new ClickHandler() { @Override public void onClick( ClickEvent event ) { diff --git a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/CalendarPicker.java b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/CalendarPicker.java index 22a61b6ca1..c068e0ec12 100644 --- a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/CalendarPicker.java +++ b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/CalendarPicker.java @@ -210,6 +210,7 @@ public HandlerRegistration addValueChangeHandler(final ValueChangeHandler private void initCalendarIcon() { calendarIcon.setIcon(IconType.CALENDAR); + calendarIcon.setTitle( Constants.INSTANCE.Select_Date() ); calendarIcon.setIconSize(IconSize.LARGE); calendarIcon.addClickHandler(new ClickHandler() { @Override @@ -236,14 +237,16 @@ public void onValueChange(ValueChangeEvent event) { private void initPrevNextTodayButtons() { previousButton.setIcon(IconType.CARET_LEFT); - previousButton.setIconSize(IconSize.LARGE); - previousButton.addClickHandler(new ClickHandler() { + previousButton.setTitle( Constants.INSTANCE.Previous() ); + previousButton.setIconSize( IconSize.LARGE ); + previousButton.addClickHandler( new ClickHandler() { @Override - public void onClick(ClickEvent event) { - adjustDate(true); + public void onClick( ClickEvent event ) { + adjustDate( true ); } - }); - nextButton.setIcon(IconType.CARET_RIGHT); + } ); + nextButton.setIcon( IconType.CARET_RIGHT ); + nextButton.setTitle( Constants.INSTANCE.Next() ); nextButton.setIconSize(IconSize.LARGE); nextButton.addClickHandler(new ClickHandler() { @Override diff --git a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/LiCalendarPicker.java b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/LiCalendarPicker.java index adc4bbde51..756b3a06a4 100644 --- a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/LiCalendarPicker.java +++ b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/java/org/jbpm/console/ng/gc/client/util/LiCalendarPicker.java @@ -174,15 +174,17 @@ public void setListContainer(CalendarListContainer listContainer) { private void initPrevNextTodayButtons() { previousButton.setIcon(IconType.CARET_LEFT); - previousButton.setIconSize(IconSize.SMALL); - previousButton.addClickHandler(new ClickHandler() { + previousButton.setTitle( Constants.INSTANCE.Previous() ); + previousButton.setIconSize( IconSize.SMALL ); + previousButton.addClickHandler( new ClickHandler() { @Override - public void onClick(ClickEvent event) { - adjustDate(true); + public void onClick( ClickEvent event ) { + adjustDate( true ); updateTodayButtonEnabled(); } - }); - nextButton.setIcon(IconType.CARET_RIGHT); + } ); + nextButton.setIcon( IconType.CARET_RIGHT ); + nextButton.setTitle( Constants.INSTANCE.Next() ); nextButton.setIconSize(IconSize.SMALL); nextButton.addClickHandler(new ClickHandler() { @Override @@ -349,6 +351,7 @@ public HandlerRegistration addValueChangeHandler(final ValueChangeHandler private void initCalendarIcon() { calendarIcon.setIcon(IconType.CALENDAR); + calendarIcon.setTitle( Constants.INSTANCE.Select_Date() ); calendarIcon.setIconSize(IconSize.SMALL); calendarIcon.addClickHandler(new ClickHandler() { @Override diff --git a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/resources/org/jbpm/console/ng/gc/client/i18n/Constants.properties b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/resources/org/jbpm/console/ng/gc/client/i18n/Constants.properties index eec8aaf985..82e836d04d 100644 --- a/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/resources/org/jbpm/console/ng/gc/client/i18n/Constants.properties +++ b/jbpm-console-ng-generic/jbpm-console-ng-generic-client/src/main/resources/org/jbpm/console/ng/gc/client/i18n/Constants.properties @@ -2,7 +2,10 @@ Actions=Actions Refresh=Refresh No_Items_Found=No items found New_Item=New Item +Select_Date=Select Date Day=Day Week=Week Month=Month -Today=Today \ No newline at end of file +Today=Today +Previous=Previous +Next=Next \ No newline at end of file diff --git a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/quicknewtask/QuickNewTaskPopup.java b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/quicknewtask/QuickNewTaskPopup.java index 9a694228e2..40c7f9735e 100644 --- a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/quicknewtask/QuickNewTaskPopup.java +++ b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/quicknewtask/QuickNewTaskPopup.java @@ -287,6 +287,7 @@ private void addUserControl( Boolean addCurrentUser ) { Button removeUserButton = new Button(); removeUserButton.setIcon( IconType.MINUS_SIGN ); + removeUserButton.setTitle( Constants.INSTANCE.Remove_User() ); removeUserButton.addClickHandler( new ClickHandler() { @Override @@ -315,6 +316,7 @@ private void addGroupControl() { Button removeGroupButton = new Button(); removeGroupButton.setIcon( IconType.MINUS_SIGN ); + removeGroupButton.setTitle( Constants.INSTANCE.Remove_Group() ); removeGroupButton.addClickHandler( new ClickHandler() { @Override diff --git a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskdetailsmulti/TaskDetailsMultiViewImpl.java b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskdetailsmulti/TaskDetailsMultiViewImpl.java index 4612f29b35..2045e71af9 100644 --- a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskdetailsmulti/TaskDetailsMultiViewImpl.java +++ b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskdetailsmulti/TaskDetailsMultiViewImpl.java @@ -142,6 +142,7 @@ public Button getCloseButton() { return new Button() { { setIcon( IconType.REMOVE ); + setTitle( Constants.INSTANCE.Close() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override @@ -173,6 +174,7 @@ public IsWidget getRefreshButton() { return new Button() { { setIcon( IconType.REFRESH ); + setTitle( Constants.INSTANCE.Refresh() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override diff --git a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskslist/grid/TasksListGridViewImpl.java b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskslist/grid/TasksListGridViewImpl.java index 775739c2f4..ea22d61d60 100644 --- a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskslist/grid/TasksListGridViewImpl.java +++ b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/editors/taskslist/grid/TasksListGridViewImpl.java @@ -299,7 +299,8 @@ public void onClick(ClickEvent event) { private void initExtraButtons() { Button newTaskButton = new Button(); newTaskButton.setTitle(constants.New_Task()); - newTaskButton.setIcon(IconType.PLUS_SIGN); + newTaskButton.setIcon( IconType.PLUS_SIGN ); + newTaskButton.setTitle( Constants.INSTANCE.New_Task() ); newTaskButton.addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { diff --git a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/i18n/Constants.java b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/i18n/Constants.java index b5c6ee3fd6..7ce462e1e3 100644 --- a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/i18n/Constants.java +++ b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/java/org/jbpm/console/ng/ht/client/i18n/Constants.java @@ -197,5 +197,5 @@ public interface Constants extends Messages { String Low(); - + String Close(); } diff --git a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/resources/org/jbpm/console/ng/ht/client/i18n/Constants.properties b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/resources/org/jbpm/console/ng/ht/client/i18n/Constants.properties index 7245092e88..403f3855da 100644 --- a/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/resources/org/jbpm/console/ng/ht/client/i18n/Constants.properties +++ b/jbpm-console-ng-human-tasks/jbpm-console-ng-human-tasks-client/src/main/resources/org/jbpm/console/ng/ht/client/i18n/Constants.properties @@ -81,3 +81,4 @@ TaskCreatedWithId=Task Created and Started (id = {0}) High=High Medium=Medium Low=Low +Close=Close diff --git a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/definition/details/multi/ProcessDefDetailsMultiViewImpl.java b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/definition/details/multi/ProcessDefDetailsMultiViewImpl.java index c742150457..ecb25a4b29 100644 --- a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/definition/details/multi/ProcessDefDetailsMultiViewImpl.java +++ b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/definition/details/multi/ProcessDefDetailsMultiViewImpl.java @@ -71,6 +71,7 @@ public Button getCloseButton() { return new Button() { { setIcon( IconType.REMOVE ); + setTitle( Constants.INSTANCE.Close() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override @@ -87,6 +88,7 @@ public IsWidget getRefreshButton() { return new Button() { { setIcon( IconType.REFRESH ); + setTitle( Constants.INSTANCE.Refresh() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override diff --git a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/instance/details/multi/ProcessInstanceDetailsMultiViewImpl.java b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/instance/details/multi/ProcessInstanceDetailsMultiViewImpl.java index c97de89b62..9b5b4c607e 100644 --- a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/instance/details/multi/ProcessInstanceDetailsMultiViewImpl.java +++ b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/editors/instance/details/multi/ProcessInstanceDetailsMultiViewImpl.java @@ -171,6 +171,7 @@ public IsWidget getRefreshButton() { return new Button() { { setIcon( IconType.REFRESH ); + setTitle( Constants.INSTANCE.Refresh() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override @@ -187,6 +188,7 @@ public IsWidget getCloseButton() { return new Button() { { setIcon( IconType.REMOVE ); + setTitle( Constants.INSTANCE.Close() ); setSize( MINI ); addClickHandler( new ClickHandler() { @Override diff --git a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/i18n/Constants.java b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/i18n/Constants.java index 2c02166eb5..35dbf77a31 100644 --- a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/i18n/Constants.java +++ b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/java/org/jbpm/console/ng/pr/client/i18n/Constants.java @@ -236,4 +236,6 @@ public interface Constants extends Messages { String VariableValueUpdated(String variableName); String Ok(); + + String Close(); } diff --git a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/resources/org/jbpm/console/ng/pr/client/i18n/Constants.properties b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/resources/org/jbpm/console/ng/pr/client/i18n/Constants.properties index 24c8d74b30..f40c81a0bc 100644 --- a/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/resources/org/jbpm/console/ng/pr/client/i18n/Constants.properties +++ b/jbpm-console-ng-process-runtime/jbpm-console-ng-process-runtime-client/src/main/resources/org/jbpm/console/ng/pr/client/i18n/Constants.properties @@ -100,4 +100,5 @@ Owner=owner Project=Project Loading=Loading... VariableValueUpdated=Variable {0} updated -Ok=Ok \ No newline at end of file +Ok=Ok +Close=Close \ No newline at end of file