@@ -71,7 +71,7 @@ describe("Keyboard Interaction", { 'after each': function(){ input.value = ''; - input.fireEvent('keyup', {key: ' '}); + input.fireEvent('keydown', {key: ' '}); input.fireEvent('blur'); }, @@ -84,49 +84,49 @@ describe("Keyboard Interaction", { 'should filter the list when characters are typed in': function(){ input.fireEvent('focus'); input.value = "kamr"; - input.fireEvent('keyup', {key: 'r'}); + input.fireEvent('keydown', {key: 'r'}); value_of(dropdown.getElements('li')).should_have_at_most(1, "items"); }, 'should move down the list when the down arrow is pressed': function(){ input.fireEvent('focus'); - input.fireEvent('keyup', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[0]); - input.fireEvent('keyup', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[1]); }, 'should not go past the last item when the down arrow is pressed': function(){ input.fireEvent('focus'); value_of(dropdown.getElements('li')).should_have_at_most(6, "items"); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li').getLast()); }, 'should move up the list when the down arrow is pressed': function(){ input.fireEvent('focus'); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[2]); - input.fireEvent('keyup', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[1]); - input.fireEvent('keyup', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[0]); }, 'should not go past the first item when the up arrow is pressed': function(){ input.fireEvent('focus'); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); - input.fireEvent('keyup', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); + input.fireEvent('keydown', {key: 'down'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[2]); - input.fireEvent('keyup', {key: 'up'}); - input.fireEvent('keyup', {key: 'up'}); - input.fireEvent('keyup', {key: 'up'}); - input.fireEvent('keyup', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[0]); }, @@ -136,7 +136,7 @@ describe("Keyboard Interaction", { }, 'should move the keyboard from where the mouse is hovering': function(){ dropdown.getElements('li')[2].fireEvent('mouseover'); - input.fireEvent('keyup', {key: 'up'}); + input.fireEvent('keydown', {key: 'up'}); value_of(Instance.highlightedChoice).should_be(dropdown.getElements('li')[1]); } }); \ No newline at end of file spec/specs.js @@ -62,7 +62,7 @@ var SelectAutocompleter = new Class({ this.dropDown.setStyle('display', 'none'); this.element.addEvent('focus', this.onFocus.bind(this)); this.element.addEvent('blur', function(){ this.onBlur.delay(100, this); }.bind(this)); - this.element.addEvent('keyup', this.keyListener.bind(this)); + this.element.addEvent('keydown', this.keyListener.bind(this)); // Hide the select tag @@ -147,6 +147,7 @@ var SelectAutocompleter = new Class({ // Select an item through the keyboard }else if (event.key == "return" || event.key == "enter"){ + event.stop(); // to prevent the form from being submitted this.termChosen = this.highlightedChoice.getAttribute('rawText'); this.element.blur(); src/select_autocompleter.js 88605f63f5553464274a54d496cc8fa62b179a62 Toby Sterrett toby@120db.com http://github.com/kneath/select-autocompleter/commit/89fc37b439e3fcd72993b5d84fee8b4fb3bffd4c 89fc37b439e3fcd72993b5d84fee8b4fb3bffd4c 2009-01-22T21:39:55-08:00 2009-01-17T21:16:35-08:00 changed keylistener to keydown instead of keyup and stopped event when enter/return so choosing an item with the keyboard wouldn't submit the form Signed-off-by: Kyle Neath <kneath@gmail.com> b29026348ad777effaad3ba310bf7786871af97e Kyle Neath kneath@gmail.com