@@ -10,6 +10,7 @@ @implementation NSImage (QuickLook) + + (NSImage *)imageWithPreviewOfFileAtPath:(NSString *)path ofSize:(NSSize)size asIcon:(BOOL)icon { NSURL *fileURL = [NSURL fileURLWithPath:path]; @@ -25,6 +26,9 @@ (CFDictionaryRef)dict); if (ref != NULL) { + // Take advantage of NSBitmapImageRep's -initWithCGImage: initializer, new in Leopard, + // which is a lot more efficient than copying pixel data into a brand new NSImage. + // Thanks to Troy Stephens @ Apple for pointing this new method out to me. NSBitmapImageRep *bitmapImageRep = [[NSBitmapImageRep alloc] initWithCGImage:ref]; NSImage *newImage = nil; if (bitmapImageRep) { @@ -49,4 +53,5 @@ return nil; } + @end NSImage+QuickLook.m @@ -2,8 +2,9 @@ // main.m // quickiee // -// Created by Dieter Komendera on 11/14/07. -// +// Created by Dieter Komendera on 11/14/07. http://komendera.com +// Licence: DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE +// http://sam.zoy.org/wtfpl/COPYING #import <Cocoa/Cocoa.h> #import <QuickLook/QuickLook.h> @@ -32,7 +33,7 @@ if(argc >= 5) { format = [NSString stringWithUTF8String:argv[4]]; } else { - format = @"jpg"; + format = @"png"; } NSImage *image = [NSImage imageWithPreviewOfFileAtPath:srcfile @@ -42,7 +43,7 @@ NSBitmapImageRep *rep = [[image representations] objectAtIndex: 0]; NSData *data; - if([format caseInsensitiveCompare:@"jpg"] == 0) { + if([format caseInsensitiveCompare:@"png"] == 0) { data = [rep representationUsingType: NSJPEGFileType properties: nil]; } else if([format caseInsensitiveCompare:@"tiff"] == 0) { data = [rep representationUsingType: NSTIFFFileType properties: nil]; @@ -50,8 +51,13 @@ data = [rep representationUsingType: NSBMPFileType properties: nil]; } else if([format caseInsensitiveCompare:@"gif"] == 0) { data = [rep representationUsingType: NSGIFFileType properties: nil]; - } else { + } else if([format caseInsensitiveCompare:@"jpg"] == 0){ data = [rep representationUsingType: NSPNGFileType properties: nil]; + } else { + printf("unknown format: "); + printf([format UTF8String]); + printf("\n"); + return -1; } [data writeToFile: dstfile atomically: NO]; main.m 7e79724fc88fccb42bb1d2ed385bf346e76503b8 Dieter Komendera dieter@komendera.com http://github.com/kommen/quikiee/commit/09e745ebe18be855fad0eeb2900f6d434882aa01 09e745ebe18be855fad0eeb2900f6d434882aa01 2008-06-03T00:19:51-07:00 2008-06-03T00:19:51-07:00 Clean up, add code comments. 11f4163d73e0a8711aa88d784a84075ad28fc6d6 Dieter Komendera dieter@komendera.com