Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount namespace propagation #432

Closed
saad-ali opened this issue Sep 18, 2017 · 19 comments
Closed

Mount namespace propagation #432

saad-ali opened this issue Sep 18, 2017 · 19 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@saad-ali
Copy link
Member

saad-ali commented Sep 18, 2017

Feature Description

  • One-line feature description (can be used as a release note): Enable a container to mount a volume rshared so that any mounts from inside the container are reflected in the host's mount namespace (this will enable, for example, containerization of volume plugins).
  • Primary contact (assignee): @jsafrane
  • Responsible SIGs: /sig-storage
  • Design proposal link (community repo): Redesign mount propagation community#659
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.8
    • Beta release target (x.y): 1.10
    • Stable release target (x.y): 1.12?
@saad-ali saad-ali added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 18, 2017
@saad-ali saad-ali added this to the 1.8 milestone Sep 18, 2017
@saad-ali
Copy link
Member Author

Split this out from #278

@saad-ali
Copy link
Member Author

Design doc: kubernetes/community#659 by @jsafrane

Implemented in PR kubernetes/kubernetes#46444 for 1.8 by @jsafrane

@saad-ali
Copy link
Member Author

Need user docs @jsafrane

@jsafrane
Copy link
Member

Docs: kubernetes/website#5544

@jbw976
Copy link

jbw976 commented Oct 31, 2017

What are the plans for getting this mount propagation feature to beta status in 1.9? Will it be available without a feature gate in 1.9? The Rook team would love to start using this feature by default as soon as possible.

I don't see it tracked in the SIG Storage 1.9 planning sheet, should it be tracked there? https://docs.google.com/spreadsheets/d/1t4z5DYKjX2ZDlkTpCnp18icRAQqOE85C1T1r2gqJVck/edit?usp=sharing

@jsafrane
Copy link
Member

jsafrane commented Jan 4, 2018

It's planned for 1.10, volunteers needed. We need more tests:

  • Together with CSI.
  • Check various recent and "long-term support" distros.
  • Add Kubernetes e2e tests for existing in-tree volume plugins (Gluster, Ceph, ...) using containerized mount utilities - this will stress test it quite a lot.

@jsafrane jsafrane modified the milestones: v1.8, v1.10 Jan 19, 2018
@jsafrane jsafrane added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 19, 2018
@idvoretskyi
Copy link
Member

/assign @jsafrane

@idvoretskyi idvoretskyi added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 29, 2018
@Bradamant3
Copy link
Contributor

@jsafrane Docs update, please! Also please update the feature tracking spreadsheet. We need the docs asap. PR merges are due this Friday (March 9). Thanks!

@jsafrane
Copy link
Member

jsafrane commented Mar 6, 2018

Docs: kubernetes/website#7655

@justaugustus
Copy link
Member

@jsafrane
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@jsafrane
Copy link
Member

@saad-ali, shall we bake it as Beta for one more release and have it stable in 1.12?

@justaugustus justaugustus modified the milestones: v1.10, next-milestone Apr 20, 2018
@justaugustus
Copy link
Member

@jsafrane I'll tentatively set this to next-milestone, but if you feel differently, just let us know.

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 2, 2018
@justaugustus justaugustus removed this from the next-milestone milestone Jul 2, 2018
@saad-ali saad-ali added this to the v1.12 milestone Jul 27, 2018
@saad-ali saad-ali added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 27, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 29, 2018
@zparnold
Copy link
Member

Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@jsafrane
Copy link
Member

Filled kubernetes/website#10090.

@zparnold
Copy link
Member

zparnold commented Aug 27, 2018 via email

@kacole2
Copy link
Contributor

kacole2 commented Sep 28, 2018

@saad-ali @jsafrane It looks like this feature made it to GA and has docs in place. Are we good to close?

@jsafrane
Copy link
Member

jsafrane commented Oct 1, 2018

Yes, this is GA now and could be closed (not sure what's the policy here).

@kacole2
Copy link
Contributor

kacole2 commented Oct 1, 2018

/close

@k8s-ci-robot
Copy link
Contributor

@kacole2: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2 kacole2 removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

9 participants