Topology aware dynamic provisioning #561

lichuqiang · 2018-04-17T01:18:09Z

Feature Description

One-line feature description (can be used as a release note): Topology aware dynamic provisioning
Primary contact (assignee): @msau42 @lichuqiang
Responsible SIGs: sig-storage
Design proposal link (community repo): Topology aware dynamic provisioning design community#1857
Link to e2e and/or unit tests:
Reviewer(s): @msau42 @jsafrane
Approver (likely from SIG/area to which feature belongs): @jsafrane @saad-ali
Feature target (which target equals to which milestone):
- Alpha release target (x.y) 1.11
- Beta release target (x.y) 1.12
- Stable release target (x.y) 1.13

lichuqiang · 2018-04-17T01:18:17Z

/assign

msau42 · 2018-04-17T01:29:59Z

/assign

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Volume topology aware dynamic provisioning: basic plumbing **What this PR does / why we need it**: Split PR #63193 for better review part 1: basic scheduler and controller plumbing Next: #63233 **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @saad-ali @bsalamat **Release note**: ```release-note Basic plumbing for volume topology aware dynamic provisioning ```

justaugustus · 2018-06-04T00:59:46Z

@msau42 @lichuqiang -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

msau42 · 2018-06-04T16:07:47Z

We've only partially completed the feature for 1.11, so we will defer to 1.12.

justaugustus · 2018-06-04T20:55:16Z

Thanks for the update, @msau42!

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API change for volume topology aware dynamic provisioning **What this PR does / why we need it**: Split PR kubernetes#63193 for better review part 2: API change Previous: kubernetes#63232 Next: kubernetes#63193 **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @thockin **Release note**: ```release-note API change for volume topology aware dynamic provisioning ```

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API change for volume topology aware dynamic provisioning **What this PR does / why we need it**: Split PR kubernetes/kubernetes#63193 for better review part 2: API change Previous: kubernetes/kubernetes#63232 Next: kubernetes/kubernetes#63193 **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @thockin **Release note**: ```release-note API change for volume topology aware dynamic provisioning ``` Kubernetes-commit: 77d996b27883bed9d8b9015b608f9a0f0c60fd23

@msau42

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Volume topology aware dynamic provisioning: work based on new API **What this PR does / why we need it**: The PR has been split to 3 parts: Part1: kubernetes#63232 for basic scheduler and PV controller plumbing Part2: kubernetes#63233 for API change and the PR itself includes work based on the API change: - Dynamic provisioning allowed topologies scheduler work - Update provisioning interface to be aware of selected node and topology **Which issue(s) this PR fixes** Feature: kubernetes/enhancements#561 Design: kubernetes/community#2168 **Special notes for your reviewer**: /sig storage /sig scheduling /assign @msau42 @jsafrane @saad-ali @bsalamat @kubernetes/sig-storage-pr-reviews @kubernetes/sig-scheduling-pr-reviews **Release note**: ```release-note Volume topology aware dynamic provisioning ```

justaugustus · 2018-07-18T02:25:36Z

@msau42 @lichuqiang @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

One-line feature description (can be used as a release note):
Primary contact (assignee):
Responsible SIGs:
Design proposal link (community repo):
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
Approver (likely from SIG/area to which feature belongs):
Feature target (which target equals to which milestone):
- Alpha release target (x.y)
- Beta release target (x.y)
- Stable release target (x.y)

Set the following:

Description
Assignee(s)
Labels:
- stage/{alpha,beta,stable}
- sig/*
- kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

Docs deadline (open placeholder PRs): 8/21
Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

lichuqiang · 2018-07-18T11:01:03Z

@justaugustus Thanks for your reminding!

One thing I'm not sure is the feature target. In 1.11, because of the fact that we were lack of some downside implementation, we didn't officially claim it alpha.
But it's indeed there. And we might wanna aim to Beta in 1.12.

Would like to wait for @msau42 for confirmation.

msau42 · 2018-07-18T18:22:27Z

Correct, goal is 1.12 beta once we have a plugin implementation with e2e tests.

msau42 · 2018-07-18T18:23:09Z

Plugin implementations are being tracked in:
#567
#558

justaugustus · 2018-07-18T21:07:41Z

Thanks for the update, @lichuqiang @msau42!
/remove-stage alpha
/stage beta

msau42 · 2018-08-20T20:56:44Z

Doc placeholder: kubernetes/website#9939

justaugustus · 2018-09-05T19:37:51Z

@msau42 @lichuqiang --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

msau42 · 2018-09-05T20:27:24Z

Yes this feature will be beta in 1.12. According to the 1.12 release schedule, docs PRs are not due until the 7th: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.12

justaugustus · 2018-09-05T21:35:35Z

Got it. Thanks for the update!

zparnold · 2018-09-10T12:54:52Z

@msau42 I didn't see a PR in k/website for this, but I could be mistaken. Could you please link it here for me?

msau42 · 2018-09-10T14:15:40Z

It's the placeholder PR mentioned above that you have also reviewed. kubernetes/website#9939

zparnold · 2018-09-10T14:18:10Z

Must've lost the link in the sheet somewhere. Thanks!

…

On Mon, Sep 10, 2018 at 9:15 AM Michelle Au ***@***.***> wrote: It's the placeholder PR mentioned above that you have also reviewed. kubernetes/website#9939 <kubernetes/website#9939> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#561 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE81SCs672Wxe0_NL3Tw_2_i6RryEXcPks5uZnQXgaJpZM4TXfJh> .

ameukam · 2018-10-05T15:06:17Z

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

msau42 · 2018-10-05T17:10:11Z

Yes, we plan to move this to GA in 1.13.

AishSundar · 2018-10-17T06:06:56Z

@msau42 is there a list of pending PRs or issues you are tracking for this feature to go to GA? Is this dependent on #611 is any way for GA?

msau42 · 2018-10-17T17:53:40Z

This feature is a subset of #490, but doesn't have any separate tasks that aren't already covered. Would it be easier to close this and just track #490?

kacole2 · 2018-10-17T23:59:02Z

@msau42 i like this idea. @AishSundar do you have any concerns about following #490 ?

AishSundar · 2018-10-18T03:12:48Z

+1 on closing this issue if there are no more specific tasks. Thanks @msau42

lichuqiang · 2018-10-18T03:33:25Z

Let's track with #490. Closing this.

k8s-ci-robot assigned lichuqiang Apr 17, 2018

k8s-ci-robot assigned msau42 Apr 17, 2018

justaugustus added this to the v1.11 milestone Apr 17, 2018

justaugustus added sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2018

msau42 mentioned this issue Apr 17, 2018

Topology Aware Volume Scheduling #490

Closed

justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018

gnufied mentioned this issue May 29, 2018

When launching a Pod referencing existing EBS the pod does not get launched on the node where the EBS gets attached kubernetes/kubernetes#64373

Closed

saad-ali modified the milestones: v1.11, v1.12 Jun 4, 2018

justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 4, 2018

k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 18, 2018

k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jul 18, 2018

justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018

msau42 mentioned this issue Aug 20, 2018

Update docs with topology aware dynamic provisioning kubernetes/website#9939

Merged

msau42 mentioned this issue Aug 23, 2018

GCE PD topology support #558

Closed

This was referenced Aug 24, 2018

Consider IP Address Availability on a given Node when considering a Node for Pod scheduling #611

Closed

Topology aware service routing kubernetes/kubernetes#58732

Closed

saad-ali modified the milestones: v1.12, v1.13 Oct 5, 2018

lichuqiang closed this as completed Oct 18, 2018

kacole2 removed this from the v1.13 milestone Oct 18, 2018

kacole2 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topology aware dynamic provisioning #561

Topology aware dynamic provisioning #561

lichuqiang commented Apr 17, 2018 •

edited by justaugustus

lichuqiang commented Apr 17, 2018

msau42 commented Apr 17, 2018

justaugustus commented Jun 4, 2018

msau42 commented Jun 4, 2018

justaugustus commented Jun 4, 2018

justaugustus commented Jul 18, 2018

lichuqiang commented Jul 18, 2018

msau42 commented Jul 18, 2018

msau42 commented Jul 18, 2018

justaugustus commented Jul 18, 2018

msau42 commented Aug 20, 2018

justaugustus commented Sep 5, 2018

msau42 commented Sep 5, 2018

justaugustus commented Sep 5, 2018

zparnold commented Sep 10, 2018

msau42 commented Sep 10, 2018

zparnold commented Sep 10, 2018 via email

ameukam commented Oct 5, 2018

msau42 commented Oct 5, 2018

AishSundar commented Oct 17, 2018

msau42 commented Oct 17, 2018

kacole2 commented Oct 17, 2018

AishSundar commented Oct 18, 2018

lichuqiang commented Oct 18, 2018

Topology aware dynamic provisioning #561

Topology aware dynamic provisioning #561

Comments

lichuqiang commented Apr 17, 2018 • edited by justaugustus

Feature Description

lichuqiang commented Apr 17, 2018

msau42 commented Apr 17, 2018

justaugustus commented Jun 4, 2018

msau42 commented Jun 4, 2018

justaugustus commented Jun 4, 2018

justaugustus commented Jul 18, 2018

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

lichuqiang commented Jul 18, 2018

msau42 commented Jul 18, 2018

msau42 commented Jul 18, 2018

justaugustus commented Jul 18, 2018

msau42 commented Aug 20, 2018

justaugustus commented Sep 5, 2018

msau42 commented Sep 5, 2018

justaugustus commented Sep 5, 2018

zparnold commented Sep 10, 2018

msau42 commented Sep 10, 2018

zparnold commented Sep 10, 2018 via email

ameukam commented Oct 5, 2018

msau42 commented Oct 5, 2018

AishSundar commented Oct 17, 2018

msau42 commented Oct 17, 2018

kacole2 commented Oct 17, 2018

AishSundar commented Oct 18, 2018

lichuqiang commented Oct 18, 2018

lichuqiang commented Apr 17, 2018 •

edited by justaugustus