Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language labels for k/website repo #9835

Merged
merged 2 commits into from Oct 24, 2018

Conversation

gochist
Copy link
Member

@gochist gochist commented Oct 17, 2018

Allow anyone to add l10n labels for the issues or PRs in the k/website repo using label prow.

/cc @zacharysarah @tengqm @cstoku

@k8s-ci-robot
Copy link
Contributor

Welcome @gochist! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component labels Oct 17, 2018
@cblecker
Copy link
Member

Adding it here will ensure the labels are created in the repo.. what it won't do is allow them to be added via the label plugin.

That would need to be changed here:

labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
removeLabelRegex = regexp.MustCompile(`(?m)^/remove-(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)

@zacharysarah is it the intention to allow contributors to modify the language labels? I'm not against it, but would like to understand the intent before we modify things :)

@zacharysarah
Copy link

@cblecker 👋 I think the intent is to assign language labels via prow, for example:

/language en

The goal is to let contributors assign language labels to issues and PRs without also requiring them to have repo write permissions. It’s a quality of life enhancement specific to k/website, but boy howdy would it make a signicant improvement.

So yes, looks it would require the changes you mention. ☝️

@cblecker
Copy link
Member

Yeah, then I'm personally fine with modifying those regexes.

@spiffxp @stevekuznetsov @fejta any thoughts/objections?

@gochist
Copy link
Member Author

gochist commented Oct 24, 2018

Thank you, @cblecker and @zacharysarah . I added a commit to change the regexes.

@cblecker
Copy link
Member

/lgtm
/assign @fejta

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: acfbaba2f8d4020b9b042d46e14851aabb824439

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/lgtm

Feel free to /hold cancel if you don't want to split apart the PR

@@ -31,8 +31,8 @@ import (
const pluginName = "label"

var (
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
removeLabelRegex = regexp.MustCompile(`(?m)^/remove-(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`)
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|language|priority|sig|triage|wg)\s*(.*)$`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to put this in its own PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fejta, gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
@cblecker
Copy link
Member

/hold cancel
I'm okay with this being the same PR. It's two separate commits, so it can be pulled apart that way if needed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

@gochist: Updated the label-config configmap using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Allow anyone to add l10n labels for the issues or PRs in the k/website repo using label prow.

/cc @zacharysarah @tengqm @cstoku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 761277f into kubernetes:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants