New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language labels for k/website repo #9835
Conversation
Welcome @gochist! It looks like this is your first PR to kubernetes/test-infra 🎉🎉 |
Adding it here will ensure the labels are created in the repo.. what it won't do is allow them to be added via the label plugin. That would need to be changed here: test-infra/prow/plugins/label/label.go Lines 34 to 35 in 1c14345
@zacharysarah is it the intention to allow contributors to modify the language labels? I'm not against it, but would like to understand the intent before we modify things :) |
@cblecker 👋 I think the intent is to assign language labels via prow, for example:
The goal is to let contributors assign language labels to issues and PRs without also requiring them to have repo write permissions. It’s a quality of life enhancement specific to k/website, but boy howdy would it make a signicant improvement. So yes, looks it would require the changes you mention. ☝️ |
Yeah, then I'm personally fine with modifying those regexes. @spiffxp @stevekuznetsov @fejta any thoughts/objections? |
Thank you, @cblecker and @zacharysarah . I added a commit to change the regexes. |
/lgtm |
LGTM label has been added. Git tree hash: acfbaba2f8d4020b9b042d46e14851aabb824439
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/lgtm
Feel free to /hold cancel
if you don't want to split apart the PR
@@ -31,8 +31,8 @@ import ( | |||
const pluginName = "label" | |||
|
|||
var ( | |||
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`) | |||
removeLabelRegex = regexp.MustCompile(`(?m)^/remove-(area|committee|kind|priority|sig|triage|wg)\s*(.*)$`) | |||
labelRegex = regexp.MustCompile(`(?m)^/(area|committee|kind|language|priority|sig|triage|wg)\s*(.*)$`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to put this in its own PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, fejta, gochist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@gochist: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allow anyone to add l10n labels for the issues or PRs in the k/website repo using
label
prow./cc @zacharysarah @tengqm @cstoku