79d705faec6b7de2bd644e77e5e4c88e8974f207 Thomas Bellman bellman@nsc.liu.se http://github.com/lak/puppet/commit/79a4339e1f614647d8b3e074752d8bf0e583aef2 79a4339e1f614647d8b3e074752d8bf0e583aef2 2009-08-07T16:42:39-07:00 2009-08-04T05:47:12-07:00 Add shellquote() function. This adds a new function shellquote() which can be used for quoting arguments in shell commands used in the exec type. This only supports Unixoid operating systems. Other systems would likely require some other quoting. Signed-off-by: Thomas Bellman <bellman@nsc.liu.se> 7c3e8687e13392f2cfdcf8a33cd5f8d86c8fc5ce James Turnbull james@lovedthanlost.net b611c34de2ff9fe35633ca2154bc64c6c793af7d Nigel Kersten nigelk@google.com http://github.com/lak/puppet/commit/79d705faec6b7de2bd644e77e5e4c88e8974f207 79d705faec6b7de2bd644e77e5e4c88e8974f207 2009-08-07T16:37:31-07:00 2009-08-04T16:38:06-07:00 Fixes #2499. Allows execs to specify an array for the returns parameter 3c329afd0ede889777eb6553ee445971771d25c0 James Turnbull james@lovedthanlost.net f3850729c691fc04482663a115b1b61938db4697 James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/b611c34de2ff9fe35633ca2154bc64c6c793af7d b611c34de2ff9fe35633ca2154bc64c6c793af7d 2009-08-04T16:48:40-07:00 2009-08-04T16:48:40-07:00 Updated fix for #2481 2c8f8112bc2a59d1f4e03c0db9229fc9fdc4662c James Turnbull james@lovedthanlost.net cc379b6d72c8d968fc9fa2f6b07db4e88869b159 James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/f3850729c691fc04482663a115b1b61938db4697 f3850729c691fc04482663a115b1b61938db4697 2009-08-04T16:34:51-07:00 2009-08-04T16:34:51-07:00 Revert "Fxied #2481 - Added status and restart overrides for Red Hat service provider." This reverts commit 967eb9f52938d8849b99686bf2c0b9da9a183399. 91da30e65735e231bd773e8b54c8aba53ab2088f James Turnbull james@lovedthanlost.net 85a36334b487f2f3fce3c4bc5c8496eaede58b46 James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/cc379b6d72c8d968fc9fa2f6b07db4e88869b159 cc379b6d72c8d968fc9fa2f6b07db4e88869b159 2009-08-04T15:21:14-07:00 2009-08-04T15:21:14-07:00 Fixed #2498 - logcheck update 77563b667ee4f160fce76acfdc318ba876bd635d James Turnbull james@lovedthanlost.net bf94de9939b31dbdbbce787696d331eb8e5f1e83 root root@absinthe.lovedthanlost.net http://github.com/lak/puppet/commit/85a36334b487f2f3fce3c4bc5c8496eaede58b46 85a36334b487f2f3fce3c4bc5c8496eaede58b46 2009-08-03T22:30:50-07:00 2009-08-03T22:30:50-07:00 Removed extraneous debugging 204674e05cbc111587303138c5ded0ca3a89406f root root@absinthe.lovedthanlost.net 5b87dba681cc0aa3144dca59216223bb16d10a4a James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/bf94de9939b31dbdbbce787696d331eb8e5f1e83 bf94de9939b31dbdbbce787696d331eb8e5f1e83 2009-08-03T18:40:59-07:00 2009-08-03T18:40:59-07:00 Updated two more tests 398aec4a55539916c5227083b78044cd6d97fc79 James Turnbull james@lovedthanlost.net 1410bed5a40fe945f68b805474b7c022403c3d47 Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/5b87dba681cc0aa3144dca59216223bb16d10a4a 5b87dba681cc0aa3144dca59216223bb16d10a4a 2009-08-03T16:14:26-07:00 2009-08-03T16:14:26-07:00 Logs now assume resource params have metadata We were previously not assuming they had it, because I figured there were just a couple that didn't. On closer inspection, none of them did. The previous commit fixed that, so this commit fixes the assumption. Signed-off-by: Luke Kanies <luke@madstop.com> 6845dbdc8fbbcbb0dfb9249e44d52e3757103079 Luke Kanies luke@madstop.com 3ab3a5c7ab9f01b78e0e6d27fce6377de0cfaeec Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/1410bed5a40fe945f68b805474b7c022403c3d47 1410bed5a40fe945f68b805474b7c022403c3d47 2009-08-03T16:07:30-07:00 2009-08-03T16:07:30-07:00 Adding metadata delegation from param to resource This is for file, line, version, and tags, with the parameter name added to the tags. This is mostly so logs generated by the parameters work better. Signed-off-by: Luke Kanies <luke@madstop.com> 8064cd32c3cf91e3546e1c841145bf3dea43457f Luke Kanies luke@madstop.com 488e368efcb0ad6d896743edb76088242c58fb05 Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/3ab3a5c7ab9f01b78e0e6d27fce6377de0cfaeec 3ab3a5c7ab9f01b78e0e6d27fce6377de0cfaeec 2009-08-03T15:50:44-07:00 2009-08-03T15:50:44-07:00 Removing unnecessary debug output Signed-off-by: Luke Kanies <luke@madstop.com> d960eb9b48bda09827e29d431d1fdeaa2f7ddd7c Luke Kanies luke@madstop.com f1406bfbedc593033f0c46241ec34fdc3bfdfbd2 Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/488e368efcb0ad6d896743edb76088242c58fb05 488e368efcb0ad6d896743edb76088242c58fb05 2009-08-03T15:02:56-07:00 2009-08-02T17:50:54-07:00 Adding integration tests for #2371 (backup refactor) Also removed old conflicting file tests. Signed-off-by: Luke Kanies <luke@madstop.com> 151f3cc4f145fea9f774f9eb83504da042322c32 Luke Kanies luke@madstop.com 8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/f1406bfbedc593033f0c46241ec34fdc3bfdfbd2 f1406bfbedc593033f0c46241ec34fdc3bfdfbd2 2009-08-03T15:02:56-07:00 2009-08-02T17:51:53-07:00 Adding many tests for #2371, and slightly refactoring This mostly focuses on adding all of the detailed tests for this new code, but it also cleans the code up just a little bit. Signed-off-by: Luke Kanies <luke@madstop.com> 69da07531df306d9bd6e2fcab3427d78264c5786 Luke Kanies luke@madstop.com cd224c6c9f5dedd27bb59822e240b5bae6202ab0 Steven Jenkins steven@endpoint.com http://github.com/lak/puppet/commit/8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb 8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb 2009-08-03T15:02:56-07:00 2009-07-24T09:31:36-07:00 Fixes for Redmine 2371. This changes the condition checking of handlebucket, as well as moves it (and remove_backup) into a separate module. It additionally refactors common code out of handlebucket into separate private methods. Some new RSpec tests which use mock and stubs are added as well, including removing the old test/ral/type/filebucket.rb tests since they are already covered by RSpec tests. 3085661bf0c71dea350adf8a666784b350c2ad66 Luke Kanies luke@madstop.com 401a9ec546adab01afa1a62477010797bf6fb221 Nigel Kersten nigelk@google.com http://github.com/lak/puppet/commit/cd224c6c9f5dedd27bb59822e240b5bae6202ab0 cd224c6c9f5dedd27bb59822e240b5bae6202ab0 2009-08-03T14:53:29-07:00 2009-07-31T17:36:50-07:00 Fixes #2464, #2457. Deprecate reportserver for report_server. Add report_port setting. Add tests. f3ca083c26fbbecbbdc089037ba68416dbf4ea2a James Turnbull james@lovedthanlost.net f6cc59803b32dd1d62cbc5e8ae16ac675ffb296d Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/401a9ec546adab01afa1a62477010797bf6fb221 401a9ec546adab01afa1a62477010797bf6fb221 2009-08-03T14:47:11-07:00 2009-08-03T14:34:20-07:00 Fixing #2484 - "format missing" messages are better Signed-off-by: Luke Kanies <luke@madstop.com> 643aa211ed93c43c6e81d6ff4211d2e25f75750d James Turnbull james@lovedthanlost.net 7c4c00f9e0a8120f6ee273c81cf1aff4379b83c2 Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/f6cc59803b32dd1d62cbc5e8ae16ac675ffb296d f6cc59803b32dd1d62cbc5e8ae16ac675ffb296d 2009-08-03T14:26:59-07:00 2009-08-03T11:53:58-07:00 Fixes #2483 - Log only copies metadata from RAL objects We were previously trying to figure out what data was available based on what methods existed, but that caught a different method profile from modules. This fixes it so we only look for this data from Puppet::Type or Puppet::Parameter instances. I had to add the ability to skip data that's not available, since File's 'ensure' parameter doesn't have 'file' data, I assume because of the metaprogramming we do around the 'file' value for 'ensure'. It's a workaround for now, and there's a test in there to verify it, anyway. Signed-off-by: Luke Kanies <luke@madstop.com> 4a924f8b18c502188f07284f621ac15c90a4aeed James Turnbull james@lovedthanlost.net ea34ee6ce64436b41ddb5a9bf71ef311fdf8b92b James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/7c4c00f9e0a8120f6ee273c81cf1aff4379b83c2 7c4c00f9e0a8120f6ee273c81cf1aff4379b83c2 2009-08-03T14:24:46-07:00 2009-08-03T14:24:46-07:00 Fixed #2486 - Missing require 'monitor' in parser_support.rb 9f3ad106a5e3660df043e54179bf9a2d119cd1df James Turnbull james@lovedthanlost.net 36d3f588b7807a9dab26c27c3118c3ced62d75c2 James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/ea34ee6ce64436b41ddb5a9bf71ef311fdf8b92b ea34ee6ce64436b41ddb5a9bf71ef311fdf8b92b 2009-08-03T06:12:13-07:00 2009-08-03T06:12:13-07:00 Added R.I.Pienaar's extlookup.rb to the ext directory e6478766e79cded4f19e4e7730640e23d00d17ae James Turnbull james@lovedthanlost.net 967eb9f52938d8849b99686bf2c0b9da9a183399 James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/36d3f588b7807a9dab26c27c3118c3ced62d75c2 36d3f588b7807a9dab26c27c3118c3ced62d75c2 2009-08-03T04:36:03-07:00 2009-08-03T04:36:03-07:00 Added example conf/puppet-queue.conf 7529aafba872025caba188d06f6470190fc1a7af James Turnbull james@lovedthanlost.net c702f76b271515e9c42dcb923d379fbfac4c83cd James Turnbull james@lovedthanlost.net http://github.com/lak/puppet/commit/967eb9f52938d8849b99686bf2c0b9da9a183399 967eb9f52938d8849b99686bf2c0b9da9a183399 2009-08-02T18:34:56-07:00 2009-08-02T18:34:56-07:00 Fxied #2481 - Added status and restart overrides for Red Hat service provider. 348fe4bce4f9f8788c391a7e2e19b2eb10ca7881 James Turnbull james@lovedthanlost.net ca17b3c4dec9a095b7e1bf24a55edbaaa6561a00 Christian Hofstaedtler hofstaedtler@inqnet.at http://github.com/lak/puppet/commit/c702f76b271515e9c42dcb923d379fbfac4c83cd c702f76b271515e9c42dcb923d379fbfac4c83cd 2009-08-02T17:00:17-07:00 2009-08-02T01:26:04-07:00 rack: SSL Env vars can be in Request.env or ENV Fix #2386, by checking either Request.env or ENV for the SSL environment variables. This is necessary as Passenger 2.2.3 changed the location of these vars, even though the Rack spec says nothing about ENV or these variables. 21c56e651645ca69ceeb3bc44937a17de4290008 James Turnbull james@lovedthanlost.net a002e58fe91a679ef75b32f09ffbdebd0ad61b81 Christian Hofstaedtler ch+git@zeha.at http://github.com/lak/puppet/commit/ca17b3c4dec9a095b7e1bf24a55edbaaa6561a00 ca17b3c4dec9a095b7e1bf24a55edbaaa6561a00 2009-08-02T17:00:17-07:00 2009-07-17T04:31:56-07:00 rack: don't directly use the forbidden HTTP_CONTENT_TYPE env var (fixes rack specification conformance) c200e2ecf01759e83acfe2f29b00083635353586 James Turnbull james@lovedthanlost.net d8de446995358b9ee06f943a6de90138c078756d Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/a002e58fe91a679ef75b32f09ffbdebd0ad61b81 a002e58fe91a679ef75b32f09ffbdebd0ad61b81 2009-08-02T14:42:54-07:00 2009-08-02T08:51:43-07:00 Removing old filebucket test Signed-off-by: Luke Kanies <luke@madstop.com> 4bd7847977dc5b0b8b00e425375297de337350f3 James Turnbull james@lovedthanlost.net 266aafa6efa9dff5fb0b49ffdafc9372edcafdfe Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/d8de446995358b9ee06f943a6de90138c078756d d8de446995358b9ee06f943a6de90138c078756d 2009-08-02T14:42:54-07:00 2009-08-02T08:49:07-07:00 Cleaning up tests for #2469 This is a small refactor of the filebucket type, and a larger refactor of the tests. Signed-off-by: Luke Kanies <luke@madstop.com> 1edbcfb7607598b6b44dec71be2ee50cc2cd4333 James Turnbull james@lovedthanlost.net 1f8ef6086cc1bb27035cc2534fac781a0349bfb5 Till Maas opensource@till.name http://github.com/lak/puppet/commit/266aafa6efa9dff5fb0b49ffdafc9372edcafdfe 266aafa6efa9dff5fb0b49ffdafc9372edcafdfe 2009-08-02T14:42:54-07:00 2009-08-02T02:20:30-07:00 default server in remote filebuckets With the path parameter set to false, the server defaults to Puppet[:server]. This allows to use a remote filebucket without syncing the servername there with the one used on the config file. To use the default server, this manifest can be used: filebucket { main: path => false } A related bug report is: http://projects.reductivelabs.com/issues/2456 fef3c920a0275cb040d13f778e543ff0e4994f7e James Turnbull james@lovedthanlost.net 11c0fb77230ea5ba28bfe86a1c2a1469095b6c70 Markus Roberts Markus@reality.com http://github.com/lak/puppet/commit/1f8ef6086cc1bb27035cc2534fac781a0349bfb5 1f8ef6086cc1bb27035cc2534fac781a0349bfb5 2009-08-02T14:40:55-07:00 2009-08-02T11:13:07-07:00 Fixes #2444 - Various JSON test failures 3bc98e8c3c72d26c3a881dc52332ad2f79df3c44 James Turnbull james@lovedthanlost.net 7e5b56212eef22be381a480dcaf38b33620674dd Markus Roberts Markus@reality.com http://github.com/lak/puppet/commit/11c0fb77230ea5ba28bfe86a1c2a1469095b6c70 11c0fb77230ea5ba28bfe86a1c2a1469095b6c70 2009-08-02T14:36:43-07:00 2009-07-29T20:55:24-07:00 Fixed #2294 - Classes sometimes cannot be found This patch should fix the race condition causing ticket 2294; it extends the loading logic so that: * initial load attempts are processed (as before), * recursive load attempts return immediately (as before), * but subsequent concurrent load attempts from different threads wait on a semaphore (condition variable) and then retry (e.g. use the now-valid results of the first thread). This is a slight modification of the solution I'd originally proposed, to prevent a deadlock that could have arisen if three or more threads simultaneously attempted to load the same item. Though it solves the bug as reported, it has room for improvement: * Failures aren't cached, so repeated attempts will be made to import invalid items each time they are encountered * It doesn't address any of the underlying referential ambiguity (module vs. filename) * The threading logic should probably be refactored into a separate class (as a start I encapsulated it in an ad hoc singleton class, so at least it isn't cluttering up the load method) Signed-off-by: Markus Roberts <Markus@reality.com> e1d3f7766bad21a2fdf04a1d88080a1a58a43636 James Turnbull james@lovedthanlost.net 97274ad976e3584ae850ad91cc886fae1dcdbbc6 Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/7e5b56212eef22be381a480dcaf38b33620674dd 7e5b56212eef22be381a480dcaf38b33620674dd 2009-08-02T00:37:27-07:00 2009-08-01T12:45:55-07:00 Adding #2477 - puppet can apply provided catalogs This provides the other half of #2440 - you can compile catalogs into json with puppetmasterd, and now you can take those json catalogs and apply them. This allows you to use whatever mechanism you want to ship the catalogs around. Signed-off-by: Luke Kanies <luke@madstop.com> 1315c26a67e3d84f87830dacab726ea30ce818af James Turnbull james@lovedthanlost.net 6fb8bf625fcfa12b085101838813ab7bc4635dae Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/97274ad976e3584ae850ad91cc886fae1dcdbbc6 97274ad976e3584ae850ad91cc886fae1dcdbbc6 2009-08-02T00:32:15-07:00 2009-08-02T00:27:16-07:00 Fixing problems my Feature refactor caused The problems were that I wasn't propagating return values sufficiently, such that false values didn't travel enough, and the 'name' attribute was necessary in the private method but wasn't actually passed in. Signed-off-by: Luke Kanies <luke@madstop.com> 8d47ec0ffad1284dd7d9916b56323a98cabdc4a8 James Turnbull james@lovedthanlost.net b3545fc528104c9b2431d8ffddd480c30207b38e Luke Kanies luke@madstop.com http://github.com/lak/puppet/commit/6fb8bf625fcfa12b085101838813ab7bc4635dae 6fb8bf625fcfa12b085101838813ab7bc4635dae 2009-08-02T00:03:48-07:00 2009-08-01T23:58:47-07:00 Fixing ruby warning in definition test Signed-off-by: Luke Kanies <luke@madstop.com> 1125e2b828c4b1f3fadb3604bb5bd70966b7b40a James Turnbull james@lovedthanlost.net