@@ -12,10 +12,12 @@ module ValidationReflection public - class <<self - alias_method_chain :validates_presence_of, :reflection - alias_method_chain :validates_acceptance_of, :reflection - alias_method_chain :validates_inclusion_of, :reflection + unless self.respond_to? :validates_presence_of_without_reflection + class <<self + alias_method_chain :validates_presence_of, :reflection + alias_method_chain :validates_acceptance_of, :reflection + alias_method_chain :validates_inclusion_of, :reflection + end end end end lib/validation_reflection.rb @@ -2,7 +2,7 @@ require File.join(File.dirname(__FILE__), '..', 'helper') require File.join(File.dirname(__FILE__), '..', '..', 'lib', 'validation_reflection') ActiveRecord::Base.connection.execute 'DROP TABLE test_users' rescue nil -ActiveRecord::Base.connection.execute 'CREATE TABLE test_users (id int(4), first_name varchar(255), last_name varchar(255))' +ActiveRecord::Base.connection.execute 'CREATE TABLE test_users (id int(4), first_name varchar(255), last_name varchar(255), type varchar(255))' class TestUser < ActiveRecord::Base validates_presence_of :name @@ -14,6 +14,10 @@ class TestUser < ActiveRecord::Base validates_inclusion_of :optional_status_2, :in => ['new', 'old'], :allow_nil => true end +class TestPremiumUser < TestUser + validates_presence_of :name +end + describe TestUser, 'required_field' do it "should require a field with validates_presence_of" do @@ -43,5 +47,9 @@ describe TestUser, 'required_field' do it "should not require a field with an :on option not set to :create" do TestUser.should_not be_required_field(:on_update_field) end + + it "should work with single table inheritance" do + TestPremiumUser.should be_required_field(:name) + end end spec/models/validation_reflection_spec.rb 148beee065627a92cab7c1aa1c1e38f20c2f35ea Alexander Lang alex@skywalker.local http://github.com/langalex/forms-fu/commit/8469f585cf3aa63ece237d805b13ac2a680135ef 8469f585cf3aa63ece237d805b13ac2a680135ef 2008-07-15T09:33:29-07:00 2008-07-15T09:33:29-07:00 fixed a bug where defining a validation in a subclass using STI resulted in a stack overflow error 3610a89930b2cd22e7a91eedae3986b334dafc05 Alexander Lang alex@skywalker.local