[6.x] Redis Broadcaster: Broadcast to multiple channels at once #31108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share some performance comparisons? |
|
I do not think it has any performance impact on the Laravel application itself. However, it reduces the data transfer to the Redis server and CPU usage on the Redis server. The following screenshots are from my AWS Redis Cluster with this patch deployed on 11/01.
In my application each broadcast event is sent to 5 channels. So theoretically, this reduces the data transferred to 1/5. |
timoschwarzer
added a commit
to timoschwarzer/laravel-framework
that referenced
this pull request
Jan 28, 2020
This fixes a regression from laravel#31108
taylorotwell
pushed a commit
that referenced
this pull request
Jan 28, 2020
* Fix channel names when broadcasting via redis This fixes a regression from #31108 * Style fixes * Update Broadcaster.php * Override formatChannels instead of changing its signature Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Lua script to the
RedisBroadcasterwhich allows to broadcast to multiple channels at once.Why?
It is pretty common in Laravel to send events to multiple channels at once. Currently, this results in multiple
publishcommands, all sending the same payload to the Redis server. This causes unnecessary data transfer (costs), especially if the payload is rather big.