Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 4 #16

Merged
merged 1 commit into from Aug 28, 2019
Merged

Allow Symfony 4 #16

merged 1 commit into from Aug 28, 2019

Conversation

lolautruche
Copy link
Owner

Update dependencies to allow Symfony 4.

@lolautruche
Copy link
Owner Author

@gbtux can you please test it?

Just add dev-feat/symfony4 as version in your composer.json and run composer update.

Thanks

@lolautruche lolautruche mentioned this pull request Sep 21, 2018
@Kynno
Copy link

Kynno commented Aug 27, 2019

Hi !

I just added dev-feat/symfony4 to my composer.json as the version for lolautruche/payline-bundle but it gives me the following error:

image

@stof
Copy link

stof commented Aug 27, 2019

To be compatible with a Flex project (which is likely to be the case for Symfony 4), you need to require the necessary Symfony components rather than the fullstack package. Flex is not compatible with installing symfony/symfony (that's the source of the power of auto-enabling components that get installed).
So this PR is incomplete.

Fortunately, requiring dedicated components directly also works for older Symfony versions (and that's the best practice for shared bundles since at least SF 2.7, maybe even before).

@lolautruche lolautruche merged commit 60c40b3 into master Aug 28, 2019
@lolautruche lolautruche deleted the feat/symfony4 branch August 28, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants