0
@@ -67,6 +67,13 @@ module ActionController
0
     #   record = Comment.new
0
     #   polymorphic_url(record)  #->  comments_url()
0
     #
0
+    #   # it supports extra flexibility for STI by walking the inheritance chain if the route is missing
0
+    #   # (note this only works for the last (leaf) argument in nested routes)
0
+    #   #
0
+    #   # an Editorial record, where Editorial is a subclass of Article and routes exist for article_* but not editorial_*
0
+    #   polymorphic_url(editorial_record) #=> article_url(editorial_record)
0
+    #   polymorphic_url(editorial_record, comment_record) #=> editorial_comment_url(editorial_record, comment_record) #not yet smart enough to find the article_comment_url
0
+    #
0
     def polymorphic_url(record_or_hash_or_array, options = {})
0
       if record_or_hash_or_array.kind_of?(Array)
0
         record_or_hash_or_array = record_or_hash_or_array.dup
0
@@ -138,9 +145,20 @@ module ActionController
0
             string << "#{RecordIdentifier.send!("singular_class_name", parent)}_"
0
           end
0
         end
0
-
0
-        route << "#{RecordIdentifier.send!("#{inflection}_class_name", record)}_"
0
-
0
+        
0
+        candidate_class = record.class
0
+        initial_candidate = candidate_route = build_candidate_named_route_call(route, namespace, inflection, candidate_class, options)
0
+        while (!respond_to?(candidate_route)) #walk up the inheritance chain to find an existing route, supports routing flexibility with STI
0
+          candidate_class = candidate_class.superclass
0
+          return initial_candidate if candidate_class == Object
0
+          candidate_route = build_candidate_named_route_call(route, namespace, inflection, candidate_class, options)
0
+        end
0
+        candidate_route || initial_candidate
0
+      end
0
+      
0
+      def build_candidate_named_route_call(route_base, namespace, inflection, candidate_class, options = {})
0
+        route = route_base.dup
0
+        route << "#{RecordIdentifier.send!("#{inflection}_class_name", candidate_class)}_"
0
         action_prefix(options) + namespace + route + routing_type(options).to_s
0
       end
0
 

0
@@ -14,6 +14,9 @@ class Response < Article
0
   def post_id; 1 end
0
 end
0
 
0
+class Editorial < Article
0
+end
0
+
0
 class Tag < Article
0
   def response_id; 1 end
0
 end
0
@@ -29,6 +32,7 @@ uses_mocha 'polymorphic URL helpers' do
0
     def setup
0
       @article = Article.new
0
       @response = Response.new
0
+      @editorial = Editorial.new
0
     end
0
   
0
     def test_with_record
0
@@ -37,11 +41,35 @@ uses_mocha 'polymorphic URL helpers' do
0
       polymorphic_url(@article)
0
     end
0
 
0
+    def test_with_fallthrough_to_route_for_base_class
0
+      @editorial.save
0
+      stubs(:respond_to?).with('editorial_url').returns(false)
0
+      stubs(:respond_to?).with('article_url').returns(true)
0
+      expects(:article_url).with(@editorial)
0
+      polymorphic_url(@editorial)
0
+    end
0
+    
0
+    def test_with_no_matching_routes
0
+      @editorial.save
0
+      stubs(:respond_to?).with('article_url').returns(false)
0
+      stubs(:respond_to?).with('editorial_url').returns(false)
0
+      expects(:editorial_url).with(@editorial)
0
+      polymorphic_url(@editorial)
0
+    end
0
+    
0
     def test_with_new_record
0
       expects(:articles_url).with()
0
       @article.expects(:new_record?).returns(true)
0
       polymorphic_url(@article)
0
     end
0
+    
0
+    def test_fallthrough_with_new_record
0
+      @editorial.stubs(:new_record?).returns(true)
0
+      stubs(:respond_to?).with('editorials_url').returns(false)
0
+      stubs(:respond_to?).with('articles_url').returns(true)
0
+      expects(:articles_url).with()
0
+      polymorphic_url(@editorial)
0
+    end
0
 
0
     def test_with_record_and_action
0
       expects(:new_article_url).with()
0
@@ -49,54 +77,137 @@ uses_mocha 'polymorphic URL helpers' do
0
       polymorphic_url(@article, :action => 'new')
0
     end
0
 
0
+    def test_fallthrough_with_record_and_action
0
+      stubs(:respond_to?).with('new_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('new_article_url').returns(true)
0
+      expects(:new_article_url).with()
0
+      @editorial.expects(:new_record?).never
0
+      polymorphic_url(@editorial, :action => 'new')
0
+    end
0
+
0
     def test_url_helper_prefixed_with_new
0
       expects(:new_article_url).with()
0
       new_polymorphic_url(@article)
0
     end
0
 
0
+    def test_fallthrough_with_url_helper_prefixed_with_new
0
+      stubs(:respond_to?).with('new_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('new_article_url').returns(true)
0
+      expects(:new_article_url).with()
0
+      new_polymorphic_url(@editorial)
0
+    end
0
+
0
     def test_url_helper_prefixed_with_edit
0
       @article.save
0
       expects(:edit_article_url).with(@article)
0
       edit_polymorphic_url(@article)
0
     end
0
 
0
+    def test_fallthrough_with_url_helper_prefixed_with_edit
0
+      @editorial.save
0
+      stubs(:respond_to?).with('edit_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('edit_article_url').returns(true)
0
+      expects(:edit_article_url).with(@editorial)
0
+      edit_polymorphic_url(@editorial)
0
+    end
0
+
0
     def test_formatted_url_helper
0
       expects(:formatted_article_url).with(@article, :pdf)
0
       formatted_polymorphic_url([@article, :pdf])
0
     end
0
 
0
+    def test_fallthrough_with_formatted_url_helper
0
+      stubs(:respond_to?).with('formatted_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('formatted_article_url').returns(true)
0
+      expects(:formatted_article_url).with(@editorial, :pdf)
0
+      formatted_polymorphic_url([@editorial, :pdf])
0
+    end
0
+
0
     def test_format_option
0
       @article.save
0
       expects(:article_url).with(@article, :pdf)
0
       polymorphic_url(@article, :format => :pdf)
0
     end
0
 
0
+    def test_fallthrough_with_format_option
0
+      @editorial.save
0
+      stubs(:respond_to?).with('editorial_url').returns(false)
0
+      stubs(:respond_to?).with('article_url').returns(true)
0
+      expects(:article_url).with(@editorial, :pdf)
0
+      polymorphic_url(@editorial, :format => :pdf)
0
+    end
0
+
0
     def test_id_and_format_option
0
       @article.save
0
       expects(:article_url).with(:id => @article, :format => :pdf)
0
       polymorphic_url(:id => @article, :format => :pdf)
0
     end
0
 
0
+    def test_fallthrough_with_id_and_format_option
0
+      @editorial.save
0
+      stubs(:respond_to?).with('editorial_url').returns(false)
0
+      stubs(:respond_to?).with('article_url').returns(true)
0
+      expects(:article_url).with(:id => @editorial, :format => :pdf)
0
+      polymorphic_url(:id => @editorial, :format => :pdf)
0
+    end
0
+
0
     def test_with_nested
0
       @response.save
0
       expects(:article_response_url).with(@article, @response)
0
       polymorphic_url([@article, @response])
0
     end
0
+    
0
+    def test_fallthrough_for_child_with_nested
0
+      @editorial.save
0
+      stubs(:respond_to?).with('response_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('response_article_url').returns(true)
0
+      expects(:response_article_url).with(@response, @editorial)
0
+      polymorphic_url([@response, @editorial])
0
+    end
0
+
0
+    def test_fallthrough_for_parent_with_nested #fallthrough only currently works for the targeted resource, not for parents it is nested inside
0
+      @response.save
0
+      stubs(:respond_to?).with('editorial_article_url').returns(false)
0
+      stubs(:respond_to?).with('editorial_response_url').returns(false)
0
+      expects(:editorial_response_url).with(@editorial, @response) #TODO: this should be expects(:article_response_url).with(@editorial, @response)
0
+      polymorphic_url([@editorial, @response])
0
+    end
0
 
0
     def test_with_nested_unsaved
0
       expects(:article_responses_url).with(@article)
0
       polymorphic_url([@article, @response])
0
     end
0
+    
0
+    def test_fallthrough_for_child_with_nested_unsaved
0
+      stubs(:respond_to?).with('response_editorials_url').returns(false)
0
+      stubs(:respond_to?).with('response_articles_url').returns(true)
0
+      expects(:response_articles_url).with(@response)
0
+      polymorphic_url([@response, @editorial])
0
+    end
0
 
0
     def test_new_with_array_and_namespace
0
       expects(:new_admin_article_url).with()
0
       polymorphic_url([:admin, @article], :action => 'new')
0
     end
0
 
0
+    def test_fallthrough_for_new_with_array_and_namespace
0
+      stubs(:respond_to?).with('new_admin_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('new_admin_article_url').returns(true)
0
+      expects(:new_admin_article_url).with()
0
+      polymorphic_url([:admin, @editorial], :action => 'new')
0
+    end
0
+
0
     def test_unsaved_with_array_and_namespace
0
       expects(:admin_articles_url).with()
0
       polymorphic_url([:admin, @article])
0
     end
0
+    
0
+    def test_fallthrough_for_unsaved_with_array_and_namespace
0
+      stubs(:respond_to?).with('admin_editorials_url').returns(false)
0
+      stubs(:respond_to?).with('admin_articles_url').returns(true)
0
+      expects(:admin_articles_url).with()
0
+      polymorphic_url([:admin, @editorial])
0
+    end
0
 
0
     def test_nested_unsaved_with_array_and_namespace
0
       @article.save
0
@@ -106,6 +217,21 @@ uses_mocha 'polymorphic URL helpers' do
0
       polymorphic_url([:admin, @article, @response])
0
     end
0
 
0
+    def test_fallthrough_for_nested_unsaved_with_array_and_namespace
0
+      @editorial.save
0
+      stubs(:respond_to?).with('admin_editorial_url').returns(false)
0
+      stubs(:respond_to?).with('admin_article_url').returns(true)
0
+      expects(:admin_article_url).with(@editorial)
0
+      polymorphic_url([:admin, @editorial])
0
+      
0
+      #fallthrough only currently works for the targeted resource, not for parents it is nested inside
0
+      stubs(:respond_to?).with('admin_editorial_responses_url').returns(false)
0
+      stubs(:respond_to?).with('admin_editorial_articles_url').returns(false)
0
+      stubs(:respond_to?).with('admin_article_responses_url').returns(true)
0
+      expects(:admin_editorial_responses_url).with(@editorial) #TODO: this should be expects(:admin_article_responses_url).with(@editorial)
0
+      polymorphic_url([:admin, @editorial, @response])
0
+    end
0
+
0
     def test_nested_with_array_and_namespace
0
       @response.save
0
       expects(:admin_article_response_url).with(@article, @response)
0
@@ -117,6 +243,24 @@ uses_mocha 'polymorphic URL helpers' do
0
       expects(:site_admin_article_response_tag_url).with(@article, @response, @tag)
0
       polymorphic_url([:site, :admin, @article, @response, @tag])
0
     end
0
+    
0
+    def test_fallthrough_for_nested_with_array_and_namespace
0
+      @response.save
0
+      stubs(:respond_to?).with('admin_editorial_response_url').returns(false)
0
+      stubs(:respond_to?).with('admin_editorial_article_url').returns(false)
0
+      stubs(:respond_to?).with('admin_article_response_url').returns(true)
0
+      expects(:admin_editorial_response_url).with(@editorial, @response) #TODO: this should be expects(:admin_article_response_url).with(@editorial, @response)
0
+      polymorphic_url([:admin, @editorial, @response])
0
+
0
+      # a ridiculously long named route tests correct ordering of namespaces and nesting:
0
+      @tag = Tag.new
0
+      @tag.save
0
+      stubs(:respond_to?).with('site_admin_editorial_response_tag_url').returns(false)
0
+      stubs(:respond_to?).with('site_admin_editorial_response_article_url').returns(false)
0
+      stubs(:respond_to?).with('site_admin_article_response_tag_url').returns(true)
0
+      expects(:site_admin_editorial_response_tag_url).with(@editorial, @response, @tag) #TODO: this should be expects(:site_admin_article_response_tag_url).with(@editorial, @response, @tag)
0
+      polymorphic_url([:site, :admin, @editorial, @response, @tag])
0
+    end
0
 
0
     # TODO: Needs to be updated to correctly know about whether the object is in a hash or not
0
     def xtest_with_hash
0
@@ -129,6 +273,13 @@ uses_mocha 'polymorphic URL helpers' do
0
       expects(:new_article_path).with()
0
       polymorphic_path(@article, :action => :new)
0
     end
0
+    
0
+    def test_fallthrough_with_polymorphic_path_accepts_options
0
+      stubs(:respond_to?).with('new_editorial_path').returns(false)
0
+      stubs(:respond_to?).with('new_article_path').returns(true)
0
+      expects(:new_article_path).with()
0
+      polymorphic_path(@editorial, :action => :new)
0
+    end
0
 
0
     def test_polymorphic_path_does_not_modify_arguments
0
       expects(:admin_article_responses_url).with(@article)