@@ -9,10 +9,11 @@ module HoptoadNotifier 'CGI::Session::CookieStore::TamperedWithCookie'] # Some of these don't exist for Rails 1.2.*, so we have to consider that. - IGNORE_DEFAULT.map!{|e| Object.const_get(e) rescue nil } + IGNORE_DEFAULT.map!{|e| eval(e) rescue nil }.compact! + IGNORE_DEFAULT.freeze class << self - attr_accessor :host, :port, :secure, :api_key, :filter_params, :ignore + attr_accessor :host, :port, :secure, :api_key, :filter_params attr_reader :backtrace_filters # Takes a block and adds it to the list of backtrace filters. When the filters lib/hoptoad_notifier.rb @@ -126,6 +126,10 @@ class HoptoadNotifierTest < Test::Unit::TestCase assert_equal( {:abc => "<filtered>", :def => "<filtered>", :ghi => "789"}, @controller.send(:clean_hoptoad_params, :abc => "123", :def => "456", :ghi => "789" ) ) end + + should "have at default ignored exceptions" do + assert HoptoadNotifier::IGNORE_DEFAULT.any? + end end context "The hoptoad test controller" do test/hoptoad_notifier_test.rb f4dcf5ed5ad63a4372921342c451d843a8070044 Luke Redpath contact@lukeredpath.co.uk http://github.com/lukeredpath/hoptoad_notifier/commit/d8281e422a418315fa2c33f5426bfe0cc9f9f373 d8281e422a418315fa2c33f5426bfe0cc9f9f373 2008-08-14T06:31:03-07:00 2008-08-14T06:31:03-07:00 Object.const_get won't work with classes inside modules unless you walk through each module in turn; this was the cause of two failing tests; changing this to eval works even though I'm uneasy about it. Added a test to verify there are some default exceptions and froze the array so it can't be modified dc4cef30be32880e8b2072f4daff855bd56019d1 Luke Redpath contact@lukeredpath.co.uk