0
@@ -1,5 +1,7 @@
0
 == 0.6.2 Rambo release
0
- * thin restart now sends HUP signals rather then stopping & starting.
0
+ * Fix uploading hanging bug when body is moved to a tempfile,
0
+   also delete the tempfile properly upon completion, fixes #25
0
+ * 'thin restart' now sends HUP signals rather then stopping & starting, closes #17
0
  * HUP signal now launches a new process with the same options.
0
  * Add PID and more info from the last request to the Stats adapter
0
    mostly taken from Rack::ShowException.

0
@@ -92,16 +92,17 @@
0
     
0
     # Close any resource used by the response
0
     def close
0
-      @body.close if @body === Tempfile
0
+      @body.delete if @body.class == Tempfile
0
     end    
0
     
0
     private
0
       def move_body_to_tempfile
0
         current_body = @body
0
+        current_body.rewind
0
         @body = Tempfile.new(BODY_TMPFILE)
0
         @body.binmode
0
-        @body << current_body unless current_body.size.zero?
0
-        @env[RACK_INPUT] = @body
0
+        @body << current_body.read
0
+        @env[RACK_INPUT] = @body        
0
       end
0
   end  
0
 end

0
@@ -190,18 +190,28 @@
0
   end
0
   
0
   it "should move body to tempfile when too big" do
0
+    request = Request.new
0
+    request.parse("POST /postit HTTP/1.1\r\nContent-Length: #{Request::MAX_BODY*2}\r\n\r\n#{'X' * Request::MAX_BODY}")
0
+    request.parse('X' * Request::MAX_BODY)
0
+    
0
+    request.body.size.should == Request::MAX_BODY * 2
0
+    request.should be_finished
0
+    request.body.class.should == Tempfile
0
+  end
0
+  
0
+  it "should delete body tempfile when closing" do
0
     body = 'X' * (Request::MAX_BODY + 1)
0
     
0
     request = R(<<-EOS.chomp, true)
0
 POST /postit HTTP/1.1
0
-Host: localhost:3000
0
-Content-Type: text/html
0
 Content-Length: #{body.size}
0
 
0
 #{body}
0
 EOS
0
     
0
-    request.body.class.should == Tempfile
0
+    request.body.path.should_not be_nil
0
+    request.close
0
+    request.body.path.should be_nil
0
   end
0
   
0
   it "should raise error when header is too big" do