Comments for madrobby's scriptaculous  

Just encountered some strange timing issues.
Bitwise XOR makes no sence here. Use x*x instead of x^2!

Hi, thanks for your work.

But I’ve got a problem with $$(‘head script[src]’), because my scripts tags are not at the top, but at the bottom of the page, as asked by YSlow. So scriptaculous files never get loaded.

i concur and i’ve reverted the change and did some cleanups.

@jdalton: add a couple of images to the page (site logo, content images, background css images) and their size becomes >> js size, making the difference in 10kB negligible.

@jdalton I’m always amazed at how you manage to memorize all those numbers (gzipped, minified, gzipped/minified, etc.) : )

Things like: if (something()) top = 3 // ; <-- needs a semi colon... bottom = 4;

Because when its flattened if (something()) top=3 bottom=4; //<- boom syntax error.

This ate the formatting…

These semi colons don’t effect code minifiers so they really aren’t needed. Plus this breaks with the style of Prototype which doesn’t include them in those situations.

These semi colons don’t effect code minifiers so they really aren’t needed. Plus this breaks with the style of Prototype which doesn’t include them in those situations.

Things like: if (something()) top = 3 // ; <-- needs a semi colon... bottom = 4;

Because when its flattened if (something()) top=3 bottom=4; //<- boom syntax error.

Rant below: And before someone says “Well, they can just gzip the files.” Minification + gzip can save 18kb+ with Prototype+Scripty over gzipping alone. This number is only going to increase with the next release. To give you an idea of how much that is, you can fit the entire jQuery framework gzipped in under 15kb. Prototype min+gzipped is 20.7kb , add effects (min+gzipped) to that and the total rises 27.1kb which is still smaller than regular Prototype gzipped (28.2kb)

I suggest someone starts a “Save The Semicolon” online petition, then we’ll know for sure. :-P

So without semicolons, this scriptaculous code wasn’t comlete? :-/

It’s not required, but it’s no bad… To me it seems more complete :)

From ECMAScript spec:

7.9.1 Rules of Automatic Semicolon Insertion When, as the program is parsed from left to right, a token (called the offending token) is encountered that is not allowed by any production of the grammar, then a semicolon is automatically inserted before the offending token if one or more of the following conditions is true: 1. The offending token is separated from the previous token by at least one LineTerminator. 2. The offending token is }.

Semicolons aren’t required here. In similar context where the function is just one line Prototype doesn’t add semicolons.