madrobby / scripty2

Description:	scripty2: for a more delicious web edit
Homepage:	http://scripty2.com/ edit
Public Clone URL:	git://github.com/madrobby/scripty2.git Give this clone URL to anyone. `git clone git://github.com/madrobby/scripty2.git`
Your Clone URL:	git@github.com:madrobby/scripty2.git Use this clone URL yourself. `git clone git@github.com:madrobby/scripty2.git`

Click here to lend your support to: scripty2 and make a donation at www.pledgie.com !

Comments for madrobby's scripty2

savetheclocktower commented on madrobby/scripty2 Sun Nov 15 12:28:39 -0800 2009

Comment in d27963f:

OK, so it was my mistake to change this. But why a debug directory? Don't get the purpose this serves.

madrobby commented on madrobby/scripty2 Mon Oct 19 05:05:11 -0700 2009

Comment in fed0d0b:

Kangax: it's alpha, you know... :D and open source! please submit a patch.... :)
Andrew: yeah, Element#store would be a better choice for this.

savetheclocktower commented on madrobby/scripty2 Sun Oct 18 14:31:21 -0700 2009

Comment on src/extensions/element.js L177 in fed0d0b:

:( Can we use Element#store here instead?

kangax commented on madrobby/scripty2 Thu Oct 15 13:25:01 -0700 2009

Comment on src/extensions/element.js L171 in fed0d0b:

That's a very weak inference. If clients is Gecko, does it mean it supports "MozTransform"? Most likely not. Testing for presence of certain style is trivial and is more robust.

Same with IE sniff further down. Need to test presence of filter, not user agent.

alloy commented on madrobby/scripty2 Fri Sep 04 09:59:01 -0700 2009

Comment in 1d91121:

Very nicely done!

kangax commented on madrobby/scripty2 Fri Jun 12 13:21:40 -0700 2009

Comment on src/extensions/element.js L63 in 10c8c42:

You might want to replace native cloneNode with Element#clone which takes care of expando removal - http://github.com/sstephenson/prototype/blob/ad89bfb73820d40f3ddaafc7e02d0c3158a62295/src/dom/dom.js#L1995

kangax commented on madrobby/scripty2 Fri Jun 12 13:18:08 -0700 2009

Comment on src/extensions/element.js L39 in 10c8c42:

It's a good idea to use "extended" syntax for perf. reasons (specially in IE) - Element.show(element).setOpacity(0); Also, shouldn't that element be extended before attempting to call its effect, show, etc?