From 88100989aa5a739a45cb19d1094c8fc28d4eb700 Mon Sep 17 00:00:00 2001 From: arrai Date: Fri, 20 Nov 2009 16:03:54 +0100 Subject: [PATCH] [8848] Fixed bidding on auctions below starting bid This was possible by using cheating tools only; the client denies such actions without sending CMSG_AUCTION_PLACE_BID. Thanks to leak for reporting this vulnerability. --- src/game/AuctionHouseHandler.cpp | 2 +- src/shared/revision_nr.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/game/AuctionHouseHandler.cpp b/src/game/AuctionHouseHandler.cpp index 565ba130f81..067d65a2915 100644 --- a/src/game/AuctionHouseHandler.cpp +++ b/src/game/AuctionHouseHandler.cpp @@ -323,7 +323,7 @@ void WorldSession::HandleAuctionPlaceBid( WorldPacket & recv_data ) } // cheating - if(price <= auction->bid) + if(price <= auction->bid || price < auction->startbid) return; // price too low for next bid if not buyout diff --git a/src/shared/revision_nr.h b/src/shared/revision_nr.h index 7baed7acbd7..4004404c4ca 100644 --- a/src/shared/revision_nr.h +++ b/src/shared/revision_nr.h @@ -1,4 +1,4 @@ #ifndef __REVISION_NR_H__ #define __REVISION_NR_H__ - #define REVISION_NR "8847" + #define REVISION_NR "8848" #endif // __REVISION_NR_H__