Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[9661] Implement dual talent specializations in talent switch part.
* Implement talent specs switch functionality. * Only gossip part still not implemented. * At update server to this commit or later character talents will be reset with some spam in logs about wrong places talents in character_spell. It can be ignored as part of conversion to new table support. Thanks to all getmangos.com community members who take part in creating and updating original dual spec patch. Signed-off-by: VladimirMangos <vladimir@getmangos.com>
- Loading branch information
Laise
authored and
VladimirMangos
committed
Apr 2, 2010
1 parent
dd1332b
commit 6b825a1
Showing
8 changed files
with
322 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
ALTER TABLE character_db_version CHANGE COLUMN required_9646_01_characters_characters required_9661_01_characters_character_talent bit; | ||
|
||
DROP TABLE IF EXISTS `character_talent`; | ||
CREATE TABLE `character_talent` ( | ||
`guid` int(11) unsigned NOT NULL, | ||
`talent_id` int(11) unsigned NOT NULL, | ||
`current_rank` tinyint(3) unsigned NOT NULL DEFAULT '0', | ||
`spec` tinyint(3) unsigned NOT NULL DEFAULT '0', | ||
PRIMARY KEY (`guid`,`talent_id`,`spec`), | ||
KEY guid_key (`guid`), | ||
KEY talent_key (`talent_id`), | ||
KEY spec_key (`spec`) | ||
) ENGINE=InnoDB DEFAULT CHARSET=utf8; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pff i gotta be dreaming. Somebody bitch slap me silly.
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/me slap cyrex :D
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! very nice work!
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good Job!! Thanks!!
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bi thanks for this :) we all are really happy that now this is fully supported by Core.
Now is missing Vehicles support and MaNGOS will rulez =D
Congrats for all your work
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, good work!
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, devs!
/cheer
/thanks
/bow
;)
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. More often to such commits instead of cutting away never stopped anyone from fields in the database ...
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only ppl not understanding code development think that some feature adding commits can exist without many preparation commits and without const code cleanup and improving code without any visible for users changes.. if devs has been think as you then mangos project long time ago die in hacks.
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing something new and good, never to abandon backwards compatibility. What relation to the hacks are unused core code field of the database? It prevented further develop the core? However, removal of this field is buried a lot of well-done work for web portals, addons and other useful things.
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think removing of DATA BLOB, it was pain in the ass for a long time. Storing data in such way is not well designed, inefficient and also makes harder to get certain data for web portals what you mentioned, you have to also update code of web portal with every client update. I think removing of DATA BLOB was the very very good step forward.
About backward compatibility, this is needed for comercial products where people pays a lot of money to keep the backward compatibility. For open source it only means to create not flexible skeleton ...
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should start thinking about things like backward compatibility when we reach 1.0, but not before...
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact removing 'data' make more future compatibility for tools, becaus will not need update all strange indexes at client switch.
6b825a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give any estimate for the "gossip part" of the dual specialization?
There are few patches out there that do the trick, like Insider's p129 and in Tasssadar's repo,
but closing this chapter in official repo would be deeply appreciated as well xD