Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix #11981: Factor in view status when showing user monitor list
When a user attempts to send a reminder to users about an issue they're
presented with a list of users from which they can select from. This
list of users is generated by determining the minimum access level
required to view the issue. However the view state of the issue was not
taken into consideration and thus if an issue had a private view state,
users without permission to view private issues would still be shown in
the user list.

Thanks to Sergio Del Franco for reporting this issue and providing a
patch.
  • Loading branch information
davidhicks committed Jun 23, 2010
1 parent 0b6540c commit 11fb95d
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions bug_reminder_page.php
Expand Up @@ -92,6 +92,12 @@
<?php
$t_project_id = bug_get_field( $f_bug_id, 'project_id' );
$t_access_level = config_get( 'reminder_receive_threshold' );
if ( $t_bug->view_state === VS_PRIVATE ) {
$t_private_bug_threshold = config_get( 'private_bug_threshold' );
if ( $t_private_bug_threshold > $t_access_level ) {
$t_access_level = $t_private_bug_threshold;
}
}
$t_selected_user_id = 0;
print_user_option_list( $t_selected_user_id, $t_project_id, $t_access_level );
?>
Expand Down

0 comments on commit 11fb95d

Please sign in to comment.