Fix PHP NOTICE in RSS

Fixes #25213
mantisbt · Jan 19, 2019 · 25df65e · 25df65e
1 parent cbab6c4
commit 25df65e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/library/README.md b/library/README.md
@@ -9,7 +9,7 @@ The version and status of each is summarized below:
 
 directory       | project         | version   | status
 ----------------|-----------------|-----------|---------------
-rssbuilder      | RSSBuilder      | 2.2.1     | patched [1]
+rssbuilder      | RSSBuilder      | 2.2.1     | patched [1][2]
 
 
 ## Javascript/CSS libraries
@@ -31,7 +31,7 @@ list.js                           | 1.4.1     | unpatched
 **Notes**
 
 1. removed `__autoload` function
-
+2. fixed SYSTEM NOTICE 'Only variables should be passed by reference'
 
 Upstream projects
 -----------------

diff --git a/library/rssbuilder/class.RSSBuilder.inc.php b/library/rssbuilder/class.RSSBuilder.inc.php
@@ -49,9 +49,9 @@ public function addRSSItem($about = '',
 							   $author = '',
 							   $comments = '',
 							   $image = '') {
-		$this->rss_itemlist->addRSSItem(new RSSItem($about, $title, $link,
-										$description, $subject, $date, $author,
-										$comments, $image));
+		$newItem = new RSSItem($about, $title, $link, $description, $subject,
+			$date, $author, $comments, $image);
+		$this->rss_itemlist->addRSSItem($newItem);
 	} // end function
 
 	public function addDCdata($publisher = '',