From 7928448fac32991cb2c277cc771284a8e7244e5d Mon Sep 17 00:00:00 2001
From: Paul Richards <paul@mantisforge.org>
Date: Sun, 21 Dec 2008 19:44:40 +0000
Subject: [PATCH] HTML validation

---
 bug_graph_page.php | 24 ++++++++++++------------
 core/print_api.php | 14 +++++++-------
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/bug_graph_page.php b/bug_graph_page.php
index 87f1574c95..0d519c3fed 100644
--- a/bug_graph_page.php
+++ b/bug_graph_page.php
@@ -88,26 +88,26 @@
         $f_end = $t_period->get_end_formatted();
         if ( ($t_body == 1 ) || ($t_body == 3) ) {
             if ( $f_show_as_table ) {
-                echo '<br /><iframe src="bug_graph_bystatus.php?width='.$t_width.'&interval=' . $f_interval . 
-                    '&start_date=' . $f_start . '&end_date=' . $f_end .
-                    '&summary=' . $t_summary . '&show_table=1" width="100%" height="80%" frameborder="0"' .
+                echo '<br /><iframe src="bug_graph_bystatus.php?width='.$t_width.'&amp;interval=' . $f_interval . 
+                    '&amp;start_date=' . $f_start . '&amp;end_date=' . $f_end .
+                    '&amp;summary=' . $t_summary . '&amp;show_table=1" width="100%" height="80%" frameborder="0"' .
                     ' marginwidth="0" marginheight="0"></iframe>';
             } else {
-                echo '<br /><img src="bug_graph_bystatus.php?width=600&interval=' . $f_interval . 
-                    '&start_date=' . $f_start . '&end_date=' . $f_end .
-                    '&summary=' . $t_summary . '&show_table=0" alt="Bug Graph"';
+                echo '<br /><img src="bug_graph_bystatus.php?width=600&amp;interval=' . $f_interval . 
+                    '&amp;start_date=' . $f_start . '&amp;end_date=' . $f_end .
+                    '&amp;summary=' . $t_summary . '&amp;show_table=0" alt="Bug Graph">';
             }
         }       
         if ( ($t_body == 2 ) || ($t_body == 3) ) {
             if ( $f_show_as_table ) {
-                echo '<br /><iframe src="bug_graph_bycategory.php?width='.$t_width.'&interval=' . $f_interval . 
-                    '&start_date=' . $f_start . '&end_date=' . $f_end .
-                    '&summary=' . $t_summary . '&show_table=1" width="100%" height="80%" frameborder="0"' .
+                echo '<br /><iframe src="bug_graph_bycategory.php?width='.$t_width.'&amp;interval=' . $f_interval . 
+                    '&amp;start_date=' . $f_start . '&amp;end_date=' . $f_end .
+                    '&amp;summary=' . $t_summary . '&amp;show_table=1" width="100%" height="80%" frameborder="0"' .
                     ' marginwidth="0" marginheight="0"></iframe>';
             } else {
-                echo '<br /><img src="bug_graph_bycategory.php?width=600&interval=' . $f_interval . 
-                    '&start_date=' . $f_start . '&end_date=' . $f_end .
-                    '&summary=' . $t_summary . '&show_table=0" alt="Bug Graph"';
+                echo '<br /><img src="bug_graph_bycategory.php?width=600&amp;interval=' . $f_interval . 
+                    '&amp;start_date=' . $f_start . '&amp;end_date=' . $f_end .
+                    '&amp;summary=' . $t_summary . '&amp;show_table=0" alt="Bug Graph">';
             }
         }
     }
diff --git a/core/print_api.php b/core/print_api.php
index b99557ad96..eabe6b2ff3 100644
--- a/core/print_api.php
+++ b/core/print_api.php
@@ -1608,14 +1608,14 @@ function print_recently_visited() {
 function get_dropdown( $p_control_array, $p_control_name, $p_match = '', $p_add_any = false, $p_multiple = false, $p_change_script = '' ) {
 	$t_control_array = $p_control_array;
 	if( $p_multiple ) {
-		$t_size = ' SIZE="5"';
-		$t_multiple = ' MULTIPLE';
+		$t_size = ' size="5"';
+		$t_multiple = ' multiple="multiple"';
 	} else {
 		$t_size = '';
 		$t_multiple = '';
 	}
 	$t_script = ( $p_change_script == '' ? '' : ' onchange="' . $p_change_script . '"' );
-	$t_info = sprintf( "<SELECT %s NAME=\"%s\" id=\"%s\"%s%s>", $t_multiple, $p_control_name, $p_control_name, $t_size, $t_script );
+	$t_info = sprintf( "<select %s name=\"%s\" id=\"%s\"%s%s>", $t_multiple, $p_control_name, $p_control_name, $t_size, $t_script );
 	if( $p_add_any ) {
 		array_unshift_assoc( $t_control_array, FILTER_META_ANY, lang_trans( '[any]' ) );
 	}
@@ -1623,16 +1623,16 @@ function get_dropdown( $p_control_array, $p_control_name, $p_match = '', $p_add_
 		$t_sel = "";
 		if( is_array( $p_match ) ) {
 			if( in_array( $t_name, array_values( $p_match ) ) || in_array( $t_desc, array_values( $p_match ) ) ) {
-				$t_sel = " SELECTED";
+				$t_sel = ' selected="selected"';
 			}
 		} else {
 			if(( $t_name === $p_match ) || ( $t_desc === $p_match ) ) {
-				$t_sel = " SELECTED";
+				$t_sel = ' selected="selected"';
 			}
 		}
-		$t_info .= sprintf( "<OPTION%s VALUE=\"%s\">%s", $t_sel, $t_name, $t_desc );
+		$t_info .= sprintf( "<option%s value=\"%s\">%s</option>", $t_sel, $t_name, $t_desc );
 	}
-	$t_info .= "</SELECT>\n";
+	$t_info .= "</select>\n";
 	return $t_info;
 }