Navigation Menu

Skip to content

Commit

Permalink
Display all current SQL upgrade instructions on execution failure
Browse files Browse the repository at this point in the history
When executing SQL commands which failed, the installation page only
displayed the first SQL command. This was incorrect and confusing.
  • Loading branch information
rombert committed May 17, 2010
1 parent b8b2114 commit 87448db
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion admin/install.php
Expand Up @@ -763,7 +763,10 @@ function InsertData( $p_table, $p_data ) {
print_test_result( GOOD );
config_set( 'database_version', $i );
} else {
print_test_result( BAD, true, $sqlarray[0] . '<br />' . $g_db->ErrorMsg() );
$all_sql = '';
foreach ( $sqlarray as $single_sql )
$all_sql .= $single_sql . '<br>';
print_test_result( BAD, true, $all_sql . $g_db->ErrorMsg() );
}
echo '</tr>';
}
Expand Down

0 comments on commit 87448db

Please sign in to comment.