From ac22c041e16c46ede836159e028eaac064322d1d Mon Sep 17 00:00:00 2001 From: Damien Regad Date: Sun, 22 Nov 2020 00:17:37 +0100 Subject: [PATCH] Handle invalid user id Failure to check user_get_row()'s return value results in system notice 'Trying to access array offset on value of type bool' when an invalid user_id parameter is given to manage_user_edit_page.php. Fixes #27573 --- manage_user_edit_page.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/manage_user_edit_page.php b/manage_user_edit_page.php index 812d276fa7..3a22d0e45f 100644 --- a/manage_user_edit_page.php +++ b/manage_user_edit_page.php @@ -80,6 +80,10 @@ } $t_user = user_get_row( $t_user_id ); +if( !$t_user ) { + error_parameters( $t_user_id ); + trigger_error( ERROR_USER_BY_ID_NOT_FOUND, ERROR); +} # Ensure that the account to be updated is of equal or lower access to the # current user.