Keep anonymous access as core feature only

Remove control for anonymous access for auth flags.

core/authentication_api.php

@@ -138,17 +138,15 @@ function auth_signup_access_level() {
  * @return bool true: enabled; false: otherwise.
  */
 function auth_anonymous_enabled() {
-	$t_auth_flags = auth_flags();
-	return $t_auth_flags->getAnonymousEnabled();
+	return config_get_global( 'allow_anonymous_login' );
 }
 
 /**
  * Get the anonymous account username.
  * @return string Anonymous account username.
  */
 function auth_anonymous_account() {
-	$t_auth_flags = auth_flags();
-	return $t_auth_flags->getAnonymousAccount();
+	return config_get_global( 'anonymous_account' );
 }
 
 /**

core/classes/AuthFlags.class.php

@@ -50,20 +50,6 @@ class AuthFlags {
 	 */
 	private $signup_access_level = null;
 
-	/**
-	 * Core anonymous login functionality is enabled.
-	 * @see $anonymous_account
-	 * @var bool|null
-	 */
-	private $anonymous_enabled = null;
-
-	/**
-	 * User account to designate as the anonymous / guest account.
-	 * @see $anonymous_enabled
-	 * @var string|null
-	 */
-	private $anonymous_account = null;
-
 	/**
 	 * The access level or array of access levels that can leverage MantisBT native passwords.
 	 * @var int|array|null
@@ -179,30 +165,6 @@ function getSignupAccessLevel() {
 		return $this->signup_access_level;
 	}
 
-	function setAnonymousEnabled( $p_enabled ) {
-		$this->anonymous_enabled = $p_enabled;
-	}
-
-	function getAnonymousEnabled() {
-		if( is_null( $this->anonymous_enabled ) ) {
-			return config_get_global( 'allow_anonymous_login' );
-		}
-
-		return $this->anonymous_enabled;
-	}
-
-	function setAnonymousAccount( $p_username ) {
-		$this->anonymous_account = $p_username;
-	}
-
-	function getAnonymousAccount() {
-		if( is_null( $this->anonymous_account ) ) {
-			return config_get_global( 'anonymous_account' );
-		}
-
-		return $this->anonymous_account;
-	}
-
 	function setSetPasswordThreshold( $p_threshold ) {
 		$this->access_level_set_password = $p_threshold;
 	}